mbox series

[0/2] drm/meson: add resume/suspend hooks

Message ID 20190827095825.21015-1-narmstrong@baylibre.com (mailing list archive)
Headers show
Series drm/meson: add resume/suspend hooks | expand

Message

Neil Armstrong Aug. 27, 2019, 9:58 a.m. UTC
This serie adds the resume/suspend hooks in the Amlogic Meson VPU main driver
and the DW-HDMI Glue driver to correctly save state and disable HW before
suspend, and succesfully re-init the HW to recover functionnal display
after resume.

This serie has been tested on Amlogic G12A based SEI510 board, using
the newly accepted VRTC driver and the rtcwake utility.

Neil Armstrong (2):
  drm/meson: dw_hdmi: add resume/suspend hooks
  drm/meson: add resume/suspend hooks

 drivers/gpu/drm/meson/meson_drv.c     |  32 ++++++++
 drivers/gpu/drm/meson/meson_dw_hdmi.c | 110 ++++++++++++++++++--------
 2 files changed, 108 insertions(+), 34 deletions(-)

Comments

Daniel Vetter Aug. 27, 2019, 4:44 p.m. UTC | #1
On Tue, Aug 27, 2019 at 11:58:23AM +0200, Neil Armstrong wrote:
> This serie adds the resume/suspend hooks in the Amlogic Meson VPU main driver
> and the DW-HDMI Glue driver to correctly save state and disable HW before
> suspend, and succesfully re-init the HW to recover functionnal display
> after resume.
> 
> This serie has been tested on Amlogic G12A based SEI510 board, using
> the newly accepted VRTC driver and the rtcwake utility.

No idea about the hw, but looks all neatly integrated into pm stuff, so on
both patches:

Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> Neil Armstrong (2):
>   drm/meson: dw_hdmi: add resume/suspend hooks
>   drm/meson: add resume/suspend hooks
> 
>  drivers/gpu/drm/meson/meson_drv.c     |  32 ++++++++
>  drivers/gpu/drm/meson/meson_dw_hdmi.c | 110 ++++++++++++++++++--------
>  2 files changed, 108 insertions(+), 34 deletions(-)
> 
> -- 
> 2.22.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Kevin Hilman Aug. 27, 2019, 7:17 p.m. UTC | #2
Neil Armstrong <narmstrong@baylibre.com> writes:

> This serie adds the resume/suspend hooks in the Amlogic Meson VPU main driver
> and the DW-HDMI Glue driver to correctly save state and disable HW before
> suspend, and succesfully re-init the HW to recover functionnal display
> after resume.
>
> This serie has been tested on Amlogic G12A based SEI510 board, using
> the newly accepted VRTC driver and the rtcwake utility.

Tested-by: Kevin Hilman <khilman@baylibre.com>

Tested on my G12A SEI510 board, and I verified that it fixes
suspend/resume issues previously seen.

Kevin
Neil Armstrong Aug. 28, 2019, 8:05 a.m. UTC | #3
On 27/08/2019 21:17, Kevin Hilman wrote:
> Neil Armstrong <narmstrong@baylibre.com> writes:
> 
>> This serie adds the resume/suspend hooks in the Amlogic Meson VPU main driver
>> and the DW-HDMI Glue driver to correctly save state and disable HW before
>> suspend, and succesfully re-init the HW to recover functionnal display
>> after resume.
>>
>> This serie has been tested on Amlogic G12A based SEI510 board, using
>> the newly accepted VRTC driver and the rtcwake utility.
> 
> Tested-by: Kevin Hilman <khilman@baylibre.com>
> 
> Tested on my G12A SEI510 board, and I verified that it fixes
> suspend/resume issues previously seen.
> 
> Kevin
> 

Thanks,

Applying to drm-misc-next (for v5.5), with a typo fix in the first patch commit log:
s/suspens/suspend

Neil
Kevin Hilman Aug. 28, 2019, 3:12 p.m. UTC | #4
Neil Armstrong <narmstrong@baylibre.com> writes:

> On 27/08/2019 21:17, Kevin Hilman wrote:
>> Neil Armstrong <narmstrong@baylibre.com> writes:
>> 
>>> This serie adds the resume/suspend hooks in the Amlogic Meson VPU main driver
>>> and the DW-HDMI Glue driver to correctly save state and disable HW before
>>> suspend, and succesfully re-init the HW to recover functionnal display
>>> after resume.
>>>
>>> This serie has been tested on Amlogic G12A based SEI510 board, using
>>> the newly accepted VRTC driver and the rtcwake utility.
>> 
>> Tested-by: Kevin Hilman <khilman@baylibre.com>
>> 
>> Tested on my G12A SEI510 board, and I verified that it fixes
>> suspend/resume issues previously seen.
>> 
>> Kevin
>> 
>
> Thanks,
>
> Applying to drm-misc-next (for v5.5), with a typo fix in the first patch commit log:
> s/suspens/suspend

Is there any chance of getting this in a a fix for v5.4 so we have a
working suspend/resume in v5.4?

Thanks,

Kevin
Neil Armstrong Aug. 28, 2019, 3:14 p.m. UTC | #5
On 28/08/2019 17:12, Kevin Hilman wrote:
> Neil Armstrong <narmstrong@baylibre.com> writes:
> 
>> On 27/08/2019 21:17, Kevin Hilman wrote:
>>> Neil Armstrong <narmstrong@baylibre.com> writes:
>>>
>>>> This serie adds the resume/suspend hooks in the Amlogic Meson VPU main driver
>>>> and the DW-HDMI Glue driver to correctly save state and disable HW before
>>>> suspend, and succesfully re-init the HW to recover functionnal display
>>>> after resume.
>>>>
>>>> This serie has been tested on Amlogic G12A based SEI510 board, using
>>>> the newly accepted VRTC driver and the rtcwake utility.
>>>
>>> Tested-by: Kevin Hilman <khilman@baylibre.com>
>>>
>>> Tested on my G12A SEI510 board, and I verified that it fixes
>>> suspend/resume issues previously seen.
>>>
>>> Kevin
>>>
>>
>> Thanks,
>>
>> Applying to drm-misc-next (for v5.5), with a typo fix in the first patch commit log:
>> s/suspens/suspend
> 
> Is there any chance of getting this in a a fix for v5.4 so we have a
> working suspend/resume in v5.4?

Nop, it's already applied to drm-misc-next and is already out of the window
for 5.4 anyway.

Neil

> 
> Thanks,
> 
> Kevin
>