| Message ID | 20190904132804.29680-1-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/panel: Extend panels to report their types | expand |
Hi Laurent. On Wed, Sep 04, 2019 at 04:28:02PM +0300, Laurent Pinchart wrote: > Hello, > > This series, whose previous version was named "[PATCH v2 0/4] drm/panel: > Extend panels to report their types" and is available at > https://www.spinics.net/lists/dri-devel/msg224579.html, allows panels to > report their type, in order to create drm_connector instances with > appropriate types in the upper layers. > > In patch 1/2 the drm_panel structure receives a new connector_type field > to report its type, set through drm_panel_init(), and all connector > drivers are updated accordingly. The panel-simple driver however only > reports the LVDS connector type for known-to-be-LVDS panels, while all > other leave the field initialised to 0, corresponding to > DRM_MODE_CONNECTOR_Unknown. Panels supported by that driver will need to > be reviewed one by one and their type updated. This was done to avoid > reporting an incorrect type, allowing upper layers to catch > DRM_MODE_CONNECTOR_Unknown and WARN() to trigger an update of the > corresponding panel. > > Patch 2/2 then modifies drm_panel_bridge_add() and its devm_ counterpart > to replace the connector type argument with the type reported by the > panel. This can't unfortunately be forced upon all drivers as several of > them hardcode a DRM_MODE_CONNECTOR_Unknown type, and would then change > the connector type reported to userspace, leading to possible breakages. > A new function, drm_panel_bridge_add_typed(), is added with the existing > behaviour of drm_panel_bridge_add() to create a panel bridge with a > forced connector type, and drivers are switched to using that function. > They should then be switched back one by one to drm_panel_bridge_add() > after careful review (and clever handling of the connector type change > issue). The drm_panel_bridge_add_typed() function is marked as > deprecated and should not be used in new code. > > During review of v2, the question of whether to introduce a new > DRM_MODE_CONNECTOR_PANEL was raised. This is still being discussed, but > such a change would still need to expose the existing panel types for > backward compatibility, and this series wouldn't hinder this in any way. > I thus believe that we should merge it sooner than later without waiting > for the DRM_MODE_CONNECTOR_PANEL discussion to settle. Agreed. > > The patches are available at > > git://linuxtv.org/pinchartl/media.git omapdrm/panels > > Laurent Pinchart (2): > drm/panel: Add and fill drm_panel type field > drm/bridge: panel: Infer connector type from panel by default Applied all three patches (despite this shortlog only shows two patches). Pushed to drm-misc-next. Sam
Hi Laurent. > > Laurent Pinchart (2): > > drm/panel: Add and fill drm_panel type field > > drm/bridge: panel: Infer connector type from panel by default > > Applied all three patches (despite this shortlog only shows two > patches). I guess you noticed that I have been away a little. This will continue for at least another week. day-time job + some travelling ahead. Sam
Hi Sam, On Sun, Sep 08, 2019 at 07:17:48PM +0200, Sam Ravnborg wrote: > Hi Laurent. > > > > Laurent Pinchart (2): > > > drm/panel: Add and fill drm_panel type field > > > drm/bridge: panel: Infer connector type from panel by default > > > > Applied all three patches (despite this shortlog only shows two > > patches). > > I guess you noticed that I have been away a little. > This will continue for at least another week. > day-time job + some travelling ahead. No worries at all. Thanks for your work and for picking those patches, and have a safe (and if possible enjoyable) travel.