From patchwork Tue Oct 22 08:36:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 11205857 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4F7A6112C for ; Wed, 23 Oct 2019 08:09:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37C7121920 for ; Wed, 23 Oct 2019 08:09:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37C7121920 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E2136E98B; Wed, 23 Oct 2019 08:09:39 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E8B76E457 for ; Tue, 22 Oct 2019 08:36:39 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id c22so6159112wmd.1 for ; Tue, 22 Oct 2019 01:36:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lPnRL6NpoSqZohNp9zgeBMxysYnhgrlrtuMJ1IcmiO4=; b=SQoxiI56uGiuE+pY5wZNiwKSK3nxjb7paigKiCqVNX+i5EDp3e0aHYTkKQwfgRri7Q cHhDAa2aFAG18AFbgNT8i2o/QboE8/+EZ+imy0uhsKlW+U/1Kx1MItrlQ0kNIGo4g8Kv CKsGx6pB/3xAP7Xffs0NpzzzEwHgh8nu+Bda2VmRzm6qaMniK96nfN6Ok2xNwaKSK5Z6 mUzfILPKouL9Aw9EXIRUJNKJIkFQn8W92RoIGDTMhvtJBqGjxFF5zMolAdHm69NvuVR7 9JBscjQXt5C8nkO3PGx81OQ3YT/FdEqkCwJlBrIoW5GM+MBj8bZcQhO/6KHhROIJO4j3 bUUw== X-Gm-Message-State: APjAAAXD7zJfUjRUuQrB8IHTWvNrtBXYdmIsvdbfiGdaTXw676wsLYmS JOFKBntOBxFJcvOWnE886LoTlA== X-Google-Smtp-Source: APXvYqwin7FI5BQUaoLOJ1m7zw/wr3yxBZOmxIPUtoJU2kMR7WARJaTrWbmN83nJqNw4l2Y2RU1QXA== X-Received: by 2002:a1c:2cc4:: with SMTP id s187mr1901269wms.166.1571733396580; Tue, 22 Oct 2019 01:36:36 -0700 (PDT) Received: from localhost.localdomain (amontpellier-652-1-281-69.w109-210.abo.wanadoo.fr. [109.210.96.69]) by smtp.gmail.com with ESMTPSA id g17sm17115253wrq.58.2019.10.22.01.36.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2019 01:36:36 -0700 (PDT) From: Bartosz Golaszewski To: Yoshinori Sato , Rich Felker , Lee Jones , Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , Linus Walleij , Andy Shevchenko , Jacopo Mondi Subject: [PATCH v7 0/9] backlight: gpio: simplify the driver Date: Tue, 22 Oct 2019 10:36:21 +0200 Message-Id: <20191022083630.28175-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 23 Oct 2019 08:09:38 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lPnRL6NpoSqZohNp9zgeBMxysYnhgrlrtuMJ1IcmiO4=; b=OVaxqkiV3r66rCJJ/etx7RcDaFZpH+qujz5COsDg5e2kyosZzs1ammXKSMfEvWjVqo 5LUTARizfYH78ZKf1AjSkhJ0vaerruSVrLdmnWd1/zJHjTY+TRrXeiUYXKp+Mh0NSrpJ ieQMAoZO59R40dcP9klGlFS/jeZ5AHtdTzMf7i1wsVdXIYsmQEad9sLN2lqxuSfVkAHT jtFE85+X8jX1kAEtQ7n4IB0VXYKse0OXHrwGcPpbLaoY7Ofm1rbcAqCXB0uErCYA/D0a HZJjTK9CEXfvyAbhVNTtWRYxSdiyGshcerExV5YXr8ylFkySuMNC1oQV/N5DrJWJZmHD ycUA== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartosz Golaszewski , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Bartosz Golaszewski While working on my other series related to gpio-backlight[1] I noticed that we could simplify the driver if we made the only user of platform data use GPIO lookups and device properties. This series tries to do that. First two patches contain minor fixes. Third patch makes the driver explicitly drive the GPIO line. Fourth patch adds all necessary data structures to ecovec24. Patch 5/9 unifies much of the code for both pdata and non-pdata cases. Patches 6-7/9 remove unused platform data fields. Last two patches contain additional improvements for the GPIO backlight driver while we're already modifying it. I don't have access to this HW but hopefully this works. Only compile tested. [1] https://lkml.org/lkml/2019/6/25/900 v1 -> v2: - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy - added additional two patches with minor improvements v2 -> v3: - in patch 7/7: used initializers to set values for pdata and dev local vars v3 -> v4: - rebased on top of v5.4-rc1 - removed changes that are no longer relevant after commit ec665b756e6f ("backlight: gpio-backlight: Correct initial power state handling") - added patch 7/7 v4 -> v5: - in patch 7/7: added a comment replacing the name of the function being pulled into probe() v5 -> v6: - added a patch making the driver explicitly set the direction of the GPIO to output - added a patch removing a redundant newline v6 -> v7: - renamed the function calculating the new GPIO value for status update - collected more tags Bartosz Golaszewski (9): backlight: gpio: remove unneeded include backlight: gpio: remove stray newline backlight: gpio: explicitly set the direction of the GPIO sh: ecovec24: add additional properties to the backlight device backlight: gpio: simplify the platform data handling sh: ecovec24: don't set unused fields in platform data backlight: gpio: remove unused fields from platform data backlight: gpio: use a helper variable for &pdev->dev backlight: gpio: pull gpio_backlight_initial_power_state() into probe arch/sh/boards/mach-ecovec24/setup.c | 33 +++-- drivers/video/backlight/gpio_backlight.c | 128 +++++++------------ include/linux/platform_data/gpio_backlight.h | 3 - 3 files changed, 69 insertions(+), 95 deletions(-) Tested-by: Jacopo Mondi