mbox series

[0/5] drm/udl: Convert to GEM framebuffer helpers

Message ID 20191114141025.32198-1-tzimmermann@suse.de (mailing list archive)
Headers show
Series drm/udl: Convert to GEM framebuffer helpers | expand

Message

Thomas Zimmermann Nov. 14, 2019, 2:10 p.m. UTC
Udl uses struct udl_framebuffer for representing its framebuffer. The
type can be replaced by the standard DRM framebuffer structure.

Patches 1 to 4 prepare the driver for the conversion. Patch 5 replaces
the structure.

The patchset has been tested by running the fb console, X11 and Weston
on a DisplayLink adapter.

Thomas Zimmermann (5):
  drm/udl: Unmap buffer object after damage update
  drm/udl: Remove udl implementation of GEM's free_object()
  drm/udl: Store active framebuffer in device structure
  drm/udl: Call udl_handle_damage() with DRM framebuffer
  drm/udl: Replace struct udl_framebuffer with generic implementation

 drivers/gpu/drm/udl/udl_drv.h     |  14 ++--
 drivers/gpu/drm/udl/udl_fb.c      | 131 +++++++++++-------------------
 drivers/gpu/drm/udl/udl_gem.c     |  18 +---
 drivers/gpu/drm/udl/udl_main.c    |   3 +
 drivers/gpu/drm/udl/udl_modeset.c |  31 +++----
 5 files changed, 70 insertions(+), 127 deletions(-)

--
2.23.0

Comments

Sam Ravnborg Nov. 25, 2019, 6:39 p.m. UTC | #1
Hi Thomas.

On Thu, Nov 14, 2019 at 03:10:20PM +0100, Thomas Zimmermann wrote:
> Udl uses struct udl_framebuffer for representing its framebuffer. The
> type can be replaced by the standard DRM framebuffer structure.
> 
> Patches 1 to 4 prepare the driver for the conversion. Patch 5 replaces
> the structure.
> 
> The patchset has been tested by running the fb console, X11 and Weston
> on a DisplayLink adapter.

Series looks good, with some nice cleanup to prepare for the
removal of udl_framebuffer.

Whole series is:
Acked-by: Sam Ravnborg <sam@ravnborg.org>

> 
> Thomas Zimmermann (5):
>   drm/udl: Unmap buffer object after damage update
>   drm/udl: Remove udl implementation of GEM's free_object()
>   drm/udl: Store active framebuffer in device structure
>   drm/udl: Call udl_handle_damage() with DRM framebuffer
>   drm/udl: Replace struct udl_framebuffer with generic implementation
> 
>  drivers/gpu/drm/udl/udl_drv.h     |  14 ++--
>  drivers/gpu/drm/udl/udl_fb.c      | 131 +++++++++++-------------------
>  drivers/gpu/drm/udl/udl_gem.c     |  18 +---
>  drivers/gpu/drm/udl/udl_main.c    |   3 +
>  drivers/gpu/drm/udl/udl_modeset.c |  31 +++----
>  5 files changed, 70 insertions(+), 127 deletions(-)
> 
> --
> 2.23.0
Thomas Zimmermann Nov. 26, 2019, 8:49 a.m. UTC | #2
Am 25.11.19 um 19:39 schrieb Sam Ravnborg:
> Hi Thomas.
> 
> On Thu, Nov 14, 2019 at 03:10:20PM +0100, Thomas Zimmermann wrote:
>> Udl uses struct udl_framebuffer for representing its framebuffer. The
>> type can be replaced by the standard DRM framebuffer structure.
>>
>> Patches 1 to 4 prepare the driver for the conversion. Patch 5 replaces
>> the structure.
>>
>> The patchset has been tested by running the fb console, X11 and Weston
>> on a DisplayLink adapter.
> 
> Series looks good, with some nice cleanup to prepare for the
> removal of udl_framebuffer.
> 
> Whole series is:
> Acked-by: Sam Ravnborg <sam@ravnborg.org>

Thanks!

> 
>>
>> Thomas Zimmermann (5):
>>   drm/udl: Unmap buffer object after damage update
>>   drm/udl: Remove udl implementation of GEM's free_object()
>>   drm/udl: Store active framebuffer in device structure
>>   drm/udl: Call udl_handle_damage() with DRM framebuffer
>>   drm/udl: Replace struct udl_framebuffer with generic implementation
>>
>>  drivers/gpu/drm/udl/udl_drv.h     |  14 ++--
>>  drivers/gpu/drm/udl/udl_fb.c      | 131 +++++++++++-------------------
>>  drivers/gpu/drm/udl/udl_gem.c     |  18 +---
>>  drivers/gpu/drm/udl/udl_main.c    |   3 +
>>  drivers/gpu/drm/udl/udl_modeset.c |  31 +++----
>>  5 files changed, 70 insertions(+), 127 deletions(-)
>>
>> --
>> 2.23.0