mbox series

[0/4] Replace hibmc code with generic implmentation

Message ID 20191122083044.6627-1-tzimmermann@suse.de (mailing list archive)
Headers show
Series Replace hibmc code with generic implmentation | expand

Message

Thomas Zimmermann Nov. 22, 2019, 8:30 a.m. UTC
The patch set replaces code in hibmc with generic implementation.

Patches 1 to 3 replace fbdev emuation, framebuffer and creation of
dumb buffers with respective code from DRM helpers. Patch 4 adds an
additional interface to debugfs that displays the allocated and free
areas in video memory.

The patches have only been compile-tested. Further testing is
appreciated.

Thomas Zimmermann (4):
  drm/hisilicon/hibmc: Switch to generic fbdev emulation
  drm/hisilicon/hibmc: Replace struct hibmc_framebuffer with generic
    code
  drm/hisilicon/hibmc: Implement hibmc_dumb_create() with generic
    helpers
  drm/hisilicon/hibmc: Export VRAM MM information to debugfs

 drivers/gpu/drm/drm_gem_vram_helper.c         |  10 +-
 drivers/gpu/drm/hisilicon/hibmc/Makefile      |   2 +-
 .../gpu/drm/hisilicon/hibmc/hibmc_drm_de.c    |   4 +-
 .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c   |   6 +-
 .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h   |  26 --
 .../gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 240 ------------------
 drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c   | 117 +--------
 include/drm/drm_gem_vram_helper.h             |   1 +
 8 files changed, 17 insertions(+), 389 deletions(-)
 delete mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c

--
2.23.0

Comments

Sam Ravnborg Nov. 23, 2019, 8:59 a.m. UTC | #1
Hi Thomas.


> The patch set replaces code in hibmc with generic implementation.
> 
> Patches 1 to 3 replace fbdev emuation, framebuffer and creation of
> dumb buffers with respective code from DRM helpers. Patch 4 adds an
> additional interface to debugfs that displays the allocated and free
> areas in video memory.
> 
> The patches have only been compile-tested. Further testing is
> appreciated.

Changes looks good and diffstat is very nice.
From my quick browsing everything was fine, a small comment on
one of the patches.

You can add my:
Acked-by: Sam Ravnborg <sam@ravnborg.org>

to the whole series.

	Sam