[0/7] drm/udl: Prepare damage handler for simple-pipe KMS

Message

Thomas Zimmermann Dec. 4, 2019, 1:24 p.m. UTC

Udl's damage-handling code requires clean up before switching the driver
to simple-pipe helpers. Patches 1, 2 and 7 remove unused state variables
and statistics. Patches 3 to 5 reorganizes the damage handler to be more
readable. Patch 6 moves dma-buf begin/end calls into the damage handler,
so it will run during page-flip andmodeset operations.

The patchset has been tested by running fbdev console emulation, X11, and
Weston with a DisplayLink adapter.

Thomas Zimmermann (7):
  drm/udl: Remove unused statistics counters
  drm/udl: Don't track number of identical and sent pixels per line
  drm/udl: Vmap framebuffer after all tests succeeded in damage handling
  drm/udl: Move clip-rectangle code out of udl_handle_damage()
  drm/udl: Move log-cpp code out of udl_damage_handler()
  drm/udl: Begin/end access to imported buffers in damage-handler
  drm/udl: Remove field lost_pixels from struct udl_device

 drivers/gpu/drm/udl/udl_drv.h      |   8 +-
 drivers/gpu/drm/udl/udl_fb.c       | 129 +++++++++++++++--------------
 drivers/gpu/drm/udl/udl_main.c     |   3 -
 drivers/gpu/drm/udl/udl_transfer.c |  12 ++-
 4 files changed, 72 insertions(+), 80 deletions(-)

--
2.23.0

Comments

Gerd Hoffmann Dec. 5, 2019, 8:15 a.m. UTC | #1

On Wed, Dec 04, 2019 at 02:24:23PM +0100, Thomas Zimmermann wrote:
> Udl's damage-handling code requires clean up before switching the driver
> to simple-pipe helpers. Patches 1, 2 and 7 remove unused state variables
> and statistics. Patches 3 to 5 reorganizes the damage handler to be more
> readable. Patch 6 moves dma-buf begin/end calls into the damage handler,
> so it will run during page-flip andmodeset operations.

Nice cleanups.

Acked-by: Gerd Hoffmann <[e-mail]>

cheers,
  Gerd

Emil Velikov Dec. 5, 2019, 1:31 p.m. UTC | #2

On Wed, 4 Dec 2019 at 13:24, Thomas Zimmermann <[e-mail]> wrote:
>
> Udl's damage-handling code requires clean up before switching the driver
> to simple-pipe helpers. Patches 1, 2 and 7 remove unused state variables
> and statistics. Patches 3 to 5 reorganizes the damage handler to be more
> readable. Patch 6 moves dma-buf begin/end calls into the damage handler,
> so it will run during page-flip andmodeset operations.
>
> The patchset has been tested by running fbdev console emulation, X11, and
> Weston with a DisplayLink adapter.
>
> Thomas Zimmermann (7):
>   drm/udl: Remove unused statistics counters
>   drm/udl: Don't track number of identical and sent pixels per line
>   drm/udl: Vmap framebuffer after all tests succeeded in damage handling
>   drm/udl: Move clip-rectangle code out of udl_handle_damage()
>   drm/udl: Move log-cpp code out of udl_damage_handler()
>   drm/udl: Begin/end access to imported buffers in damage-handler
>   drm/udl: Remove field lost_pixels from struct udl_device
>
There's a bugfix request in 6/7.

Regardless if you squash it in or choose to keep it separate, the series is:
Reviewed-by: Emil Velikov <[e-mail]>

Thanks
Emil