Message ID | 20200101112444.16250-1-jagan@amarulasolutions.com (mailing list archive) |
---|---|
Headers | show |
Series | dt-bindings: display: Update few panel bindings with YAML | expand |
Hi Jagan. On Wed, Jan 01, 2020 at 04:54:38PM +0530, Jagan Teki wrote: > These panel bindings are owned by me, so updated all of them into > YAML DT schema. > > Any inputs? Thanks for doing the conversion. dt_binding_check was not happy: Documentation/devicetree/bindings/display/panel/rocktech,rk070er9427.example.dt.yaml: panel: 'backlight', 'port' do not match any of the regexes: 'pinctrl-[0-9]+' DTC Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml CHECK Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml: panel: 'backlight', 'port' do not match any of the regexes: 'pinctrl-[0-9]+' Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml: panel: compatible: Additional items are not allowed ('simple-panel' was unexpected) Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml: panel: compatible: ['friendlyarm,hd702e', 'simple-panel'] is too long DTC Documentation/devicetree/bindings/display/panel/sitronix,st7701.example.dt.yaml Error: Documentation/devicetree/bindings/display/panel/sitronix,st7701.example.dts:22.42-43 syntax error FATAL ERROR: Unable to parse input tree Please fix and check the bindings using dt_binding_check before resubmit. I had to install libyaml-dev (as least I recall this was the name) before dt_binding_check worked OK for me. Sam
Hi Sam, On Sat, Jan 4, 2020 at 8:47 PM Sam Ravnborg <sam@ravnborg.org> wrote: > > Hi Jagan. > On Wed, Jan 01, 2020 at 04:54:38PM +0530, Jagan Teki wrote: > > These panel bindings are owned by me, so updated all of them into > > YAML DT schema. > > > > Any inputs? > Thanks for doing the conversion. > > dt_binding_check was not happy: > Documentation/devicetree/bindings/display/panel/rocktech,rk070er9427.example.dt.yaml: panel: 'backlight', 'port' do not match any of the regexes: 'pinctrl-[0-9]+' > DTC Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml > CHECK Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml > Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml: panel: 'backlight', 'port' do not match any of the regexes: 'pinctrl-[0-9]+' > Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml: panel: compatible: Additional items are not allowed ('simple-panel' was unexpected) > Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml: panel: compatible: ['friendlyarm,hd702e', 'simple-panel'] is too long > DTC Documentation/devicetree/bindings/display/panel/sitronix,st7701.example.dt.yaml > Error: Documentation/devicetree/bindings/display/panel/sitronix,st7701.example.dts:22.42-43 syntax error > FATAL ERROR: Unable to parse input tree > > Please fix and check the bindings using dt_binding_check before > resubmit. > > I had to install libyaml-dev (as least I recall this was the name) > before dt_binding_check worked OK for me. I did check dt_binfing_check with this series. Here is the complete build log and you can see the panels related to this series are checked fine. Let me know if I miss anything here? ₹ make dt_binding_check arch/x86/Makefile:147: CONFIG_X86_X32 enabled but no binutils support SCHEMA Documentation/devicetree/bindings/processed-schema.yaml /home/jagan/work/code/drm-misc/Documentation/devicetree/bindings/firmware/intel,ixp4xx-network-processing-engine.yaml: ignoring, error in schema: properties: reg: minItems warning: no schema found in file: Documentation/devicetree/bindings/firmware/intel,ixp4xx-network-processing-engine.yaml /home/jagan/work/code/drm-misc/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml: ignoring, error in schema: properties: ppi-partitions: patternProperties: ^interrupt-partition-[0-9]+$ warning: no schema found in file: Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml /home/jagan/work/code/drm-misc/Documentation/devicetree/bindings/net/snps,dwmac.yaml: ignoring, error in schema: allOf: 2: then warning: no schema found in file: Documentation/devicetree/bindings/net/snps,dwmac.yaml /home/jagan/work/code/drm-misc/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml: ignoring, error in schema: properties: compatible: enum: 0 warning: no schema found in file: Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /home/jagan/work/code/drm-misc/Documentation/devicetree/bindings/riscv/cpus.yaml: ignoring, error in schema: properties: timebase-frequency: type warning: no schema found in file: Documentation/devicetree/bindings/riscv/cpus.yaml CHKDT Documentation/devicetree/bindings/arm/pmu.yaml CHKDT Documentation/devicetree/bindings/arm/rockchip.yaml CHKDT Documentation/devicetree/bindings/arm/sirf.yaml CHKDT Documentation/devicetree/bindings/arm/vt8500.yaml CHKDT Documentation/devicetree/bindings/arm/calxeda.yaml CHKDT Documentation/devicetree/bindings/arm/atmel-at91.yaml CHKDT Documentation/devicetree/bindings/arm/sunxi.yaml CHKDT Documentation/devicetree/bindings/arm/xilinx.yaml CHKDT Documentation/devicetree/bindings/arm/moxart.yaml CHKDT Documentation/devicetree/bindings/arm/stm32/stm32.yaml CHKDT Documentation/devicetree/bindings/arm/spear.yaml CHKDT Documentation/devicetree/bindings/arm/al,alpine.yaml CHKDT Documentation/devicetree/bindings/arm/digicolor.yaml CHKDT Documentation/devicetree/bindings/arm/altera/socfpga-clk-manager.yaml CHKDT Documentation/devicetree/bindings/arm/altera.yaml CHKDT Documentation/devicetree/bindings/arm/bitmain.yaml CHKDT Documentation/devicetree/bindings/arm/nxp/lpc32xx.yaml CHKDT Documentation/devicetree/bindings/arm/fsl.yaml CHKDT Documentation/devicetree/bindings/arm/axxia.yaml CHKDT Documentation/devicetree/bindings/arm/psci.yaml CHKDT Documentation/devicetree/bindings/arm/qcom.yaml CHKDT Documentation/devicetree/bindings/arm/zte.yaml CHKDT Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml CHKDT Documentation/devicetree/bindings/arm/mediatek.yaml CHKDT Documentation/devicetree/bindings/arm/socionext/milbeaut.yaml CHKDT Documentation/devicetree/bindings/arm/ti/nspire.yaml CHKDT Documentation/devicetree/bindings/arm/ti/ti,davinci.yaml CHKDT Documentation/devicetree/bindings/arm/realtek.yaml CHKDT Documentation/devicetree/bindings/arm/rda.yaml CHKDT Documentation/devicetree/bindings/arm/actions.yaml CHKDT Documentation/devicetree/bindings/arm/l2c2x0.yaml CHKDT Documentation/devicetree/bindings/arm/renesas.yaml CHKDT Documentation/devicetree/bindings/arm/tegra.yaml CHKDT Documentation/devicetree/bindings/arm/amlogic.yaml CHKDT Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml CHKDT Documentation/devicetree/bindings/arm/sti.yaml CHKDT Documentation/devicetree/bindings/arm/primecell.yaml CHKDT Documentation/devicetree/bindings/arm/cpus.yaml CHKDT Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml CHKDT Documentation/devicetree/bindings/bus/allwinner,sun8i-a23-rsb.yaml CHKDT Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml CHKDT Documentation/devicetree/bindings/clock/milbeaut-clock.yaml CHKDT Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml CHKDT Documentation/devicetree/bindings/clock/imx8mn-clock.yaml CHKDT Documentation/devicetree/bindings/clock/fixed-clock.yaml CHKDT Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml CHKDT Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml CHKDT Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml CHKDT Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.yaml CHKDT Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml CHKDT Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml CHKDT Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.yaml CHKDT Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.yaml CHKDT Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml CHKDT Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml CHKDT Documentation/devicetree/bindings/display/panel/koe,tx31d200vm0baa.yaml CHKDT Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml CHKDT Documentation/devicetree/bindings/display/panel/sony,acx424akp.yaml CHKDT Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml CHKDT Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.yaml CHKDT Documentation/devicetree/bindings/display/panel/ti,nspire.yaml CHKDT Documentation/devicetree/bindings/display/panel/tpo,tpg110.yaml CHKDT Documentation/devicetree/bindings/display/panel/rocktech,rk070er9427.yaml CHKDT Documentation/devicetree/bindings/display/panel/armadeus,st0700-adapt.yaml CHKDT Documentation/devicetree/bindings/display/panel/raspberrypi,7inch-touchscreen.yaml CHKDT Documentation/devicetree/bindings/display/panel/lvds.yaml CHKDT Documentation/devicetree/bindings/display/panel/panel-common.yaml CHKDT Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml CHKDT Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml CHKDT Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml CHKDT Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml CHKDT Documentation/devicetree/bindings/display/dsi-controller.yaml CHKDT Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml CHKDT Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml CHKDT Documentation/devicetree/bindings/display/simple-framebuffer.yaml CHKDT Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml CHKDT Documentation/devicetree/bindings/dma/dma-router.yaml CHKDT Documentation/devicetree/bindings/dma/dma-controller.yaml CHKDT Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml CHKDT Documentation/devicetree/bindings/dma/allwinner,sun4i-a10-dma.yaml CHKDT Documentation/devicetree/bindings/dma/dma-common.yaml CHKDT Documentation/devicetree/bindings/dma/allwinner,sun6i-a31-dma.yaml CHKDT Documentation/devicetree/bindings/dsp/fsl,dsp.yaml CHKDT Documentation/devicetree/bindings/example-schema.yaml CHKDT Documentation/devicetree/bindings/firmware/intel,ixp4xx-network-processing-engine.yaml /home/jagan/work/code/drm-misc/Documentation/devicetree/bindings/firmware/intel,ixp4xx-network-processing-engine.yaml: properties:reg:minItems: False schema does not allow 3 /home/jagan/work/code/drm-misc/Documentation/devicetree/bindings/firmware/intel,ixp4xx-network-processing-engine.yaml: properties:reg:maxItems: False schema does not allow 3 Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/firmware/intel,ixp4xx-network-processing-engine.example.dts' failed make[1]: *** [Documentation/devicetree/bindings/firmware/intel,ixp4xx-network-processing-engine.example.dts] Error 1 Makefile:1263: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2
Hi Jagan. On Mon, Jan 06, 2020 at 03:41:40PM +0530, Jagan Teki wrote: > Hi Sam, > > On Sat, Jan 4, 2020 at 8:47 PM Sam Ravnborg <sam@ravnborg.org> wrote: > > > > Hi Jagan. > > On Wed, Jan 01, 2020 at 04:54:38PM +0530, Jagan Teki wrote: > > > These panel bindings are owned by me, so updated all of them into > > > YAML DT schema. > > > > > > Any inputs? > > Thanks for doing the conversion. > > > > dt_binding_check was not happy: > > Documentation/devicetree/bindings/display/panel/rocktech,rk070er9427.example.dt.yaml: panel: 'backlight', 'port' do not match any of the regexes: 'pinctrl-[0-9]+' > > DTC Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml > > CHECK Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml > > Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml: panel: 'backlight', 'port' do not match any of the regexes: 'pinctrl-[0-9]+' > > Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml: panel: compatible: Additional items are not allowed ('simple-panel' was unexpected) > > Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml: panel: compatible: ['friendlyarm,hd702e', 'simple-panel'] is too long > > DTC Documentation/devicetree/bindings/display/panel/sitronix,st7701.example.dt.yaml > > Error: Documentation/devicetree/bindings/display/panel/sitronix,st7701.example.dts:22.42-43 syntax error > > FATAL ERROR: Unable to parse input tree > > > > Please fix and check the bindings using dt_binding_check before > > resubmit. > > > > I had to install libyaml-dev (as least I recall this was the name) > > before dt_binding_check worked OK for me. > > I did check dt_binfing_check with this series. Here is the complete > build log and you can see the panels related to this series are > checked fine. Let me know if I miss anything here? Due to other errors you never reached the poart that checks the example. I use the following to focus on a single binding: (from my script, but you get the idea) domake ${arch} ${config} dt_binding_check DT_SCHEMA_FILES=${bindings}/display/panel/feixin,k101-im2ba02.yaml In this way I can ignore all the bindings that otherwise fails. Note: I sometimes have to clean my ouput directory to force that the examples are tested. It is also a good idea to introduce errors on purpose in the example, in this way you can check that they are tested. Sam