mbox series

[00/15] amdgpu: remove load and unload callbacks (v3)

Message ID 20200207195058.2354-1-alexander.deucher@amd.com (mailing list archive)
Headers show
Series amdgpu: remove load and unload callbacks (v3) | expand

Message

Alex Deucher Feb. 7, 2020, 7:50 p.m. UTC
These are deprecated and the drm will soon start warning when drivers still
use them.  It was a long and twisty road, but seems to work.

v2: Add additional patch (13/15) which should fix the crash reported by
Thomas Zimmermann.
v3: Fix dp aux registration harder, add missing kconfig guard

Alex Deucher (15):
  drm/amdgpu: rename amdgpu_debugfs_preempt_cleanup
  drm/amdgpu/ttm: move debugfs init into core amdgpu debugfs
  drm/amdgpu/pm: move debugfs init into core amdgpu debugfs
  drm/amdgpu/sa: move debugfs init into core amdgpu debugfs
  drm/amdgpu/fence: move debugfs init into core amdgpu debugfs
  drm/amdgpu/gem: move debugfs init into core amdgpu debugfs
  drm/amdgpu/regs: move debugfs init into core amdgpu debugfs
  drm/amdgpu/firmware: move debugfs init into core amdgpu debugfs
  drm/amdgpu: don't call drm_connector_register for non-MST ports
  drm/amdgpu/display: move debugfs init into core amdgpu debugfs (v2)
  drm/amd/display: move dpcd debugfs members setup
  drm/amdgpu/display: add a late register connector callback
  drm/amdgpu/display: split dp connector registration (v2)
  drm/amdgpu/ring: move debugfs init into core amdgpu debugfs
  drm/amdgpu: drop legacy drm load and unload callbacks

 .../gpu/drm/amd/amdgpu/amdgpu_connectors.c    | 17 ++++-
 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c   | 69 ++++++++++++++++++-
 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.h   |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    | 17 -----
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c       | 13 +++-
 drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c     |  3 -
 drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c        |  7 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_object.h    |  1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c        |  9 +--
 drivers/gpu/drm/amd/amdgpu/amdgpu_pm.h        |  2 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c      | 15 +---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h      |  4 ++
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c       | 14 +---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h       |  3 +
 drivers/gpu/drm/amd/amdgpu/atombios_dp.c      | 10 +--
 drivers/gpu/drm/amd/amdgpu/dce_virtual.c      |  1 -
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 26 +++----
 .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c |  3 +
 .../display/amdgpu_dm/amdgpu_dm_mst_types.c   | 13 ++--
 19 files changed, 140 insertions(+), 89 deletions(-)

Comments

Thomas Zimmermann Feb. 10, 2020, 10:39 a.m. UTC | #1
Hi

Am 07.02.20 um 20:50 schrieb Alex Deucher:
> These are deprecated and the drm will soon start warning when drivers still
> use them.  It was a long and twisty road, but seems to work.
> 
> v2: Add additional patch (13/15) which should fix the crash reported by
> Thomas Zimmermann.
> v3: Fix dp aux registration harder, add missing kconfig guard

No more stacktraces.

Tested-by: Thomas Zimmermann <tzimmermann@suse.de>

> 
> Alex Deucher (15):
>   drm/amdgpu: rename amdgpu_debugfs_preempt_cleanup
>   drm/amdgpu/ttm: move debugfs init into core amdgpu debugfs
>   drm/amdgpu/pm: move debugfs init into core amdgpu debugfs
>   drm/amdgpu/sa: move debugfs init into core amdgpu debugfs
>   drm/amdgpu/fence: move debugfs init into core amdgpu debugfs
>   drm/amdgpu/gem: move debugfs init into core amdgpu debugfs
>   drm/amdgpu/regs: move debugfs init into core amdgpu debugfs
>   drm/amdgpu/firmware: move debugfs init into core amdgpu debugfs
>   drm/amdgpu: don't call drm_connector_register for non-MST ports
>   drm/amdgpu/display: move debugfs init into core amdgpu debugfs (v2)
>   drm/amd/display: move dpcd debugfs members setup
>   drm/amdgpu/display: add a late register connector callback
>   drm/amdgpu/display: split dp connector registration (v2)
>   drm/amdgpu/ring: move debugfs init into core amdgpu debugfs
>   drm/amdgpu: drop legacy drm load and unload callbacks
> 
>  .../gpu/drm/amd/amdgpu/amdgpu_connectors.c    | 17 ++++-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c   | 69 ++++++++++++++++++-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.h   |  2 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    | 17 -----
>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c       | 13 +++-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c     |  3 -
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c        |  7 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_object.h    |  1 +
>  drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c        |  9 +--
>  drivers/gpu/drm/amd/amdgpu/amdgpu_pm.h        |  2 +
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c      | 15 +---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h      |  4 ++
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c       | 14 +---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h       |  3 +
>  drivers/gpu/drm/amd/amdgpu/atombios_dp.c      | 10 +--
>  drivers/gpu/drm/amd/amdgpu/dce_virtual.c      |  1 -
>  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 26 +++----
>  .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c |  3 +
>  .../display/amdgpu_dm/amdgpu_dm_mst_types.c   | 13 ++--
>  19 files changed, 140 insertions(+), 89 deletions(-)
>
Thomas Zimmermann April 8, 2020, 7:38 a.m. UTC | #2
Hi Alex

Am 07.02.20 um 20:50 schrieb Alex Deucher:
> These are deprecated and the drm will soon start warning when drivers still
> use them.  It was a long and twisty road, but seems to work.

Are you going to convert radeon as well? It's the only remaining KMS
driver that uses load.

Best regards
Thomas

> 
> v2: Add additional patch (13/15) which should fix the crash reported by
> Thomas Zimmermann.
> v3: Fix dp aux registration harder, add missing kconfig guard
> 
> Alex Deucher (15):
>   drm/amdgpu: rename amdgpu_debugfs_preempt_cleanup
>   drm/amdgpu/ttm: move debugfs init into core amdgpu debugfs
>   drm/amdgpu/pm: move debugfs init into core amdgpu debugfs
>   drm/amdgpu/sa: move debugfs init into core amdgpu debugfs
>   drm/amdgpu/fence: move debugfs init into core amdgpu debugfs
>   drm/amdgpu/gem: move debugfs init into core amdgpu debugfs
>   drm/amdgpu/regs: move debugfs init into core amdgpu debugfs
>   drm/amdgpu/firmware: move debugfs init into core amdgpu debugfs
>   drm/amdgpu: don't call drm_connector_register for non-MST ports
>   drm/amdgpu/display: move debugfs init into core amdgpu debugfs (v2)
>   drm/amd/display: move dpcd debugfs members setup
>   drm/amdgpu/display: add a late register connector callback
>   drm/amdgpu/display: split dp connector registration (v2)
>   drm/amdgpu/ring: move debugfs init into core amdgpu debugfs
>   drm/amdgpu: drop legacy drm load and unload callbacks
> 
>  .../gpu/drm/amd/amdgpu/amdgpu_connectors.c    | 17 ++++-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c   | 69 ++++++++++++++++++-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.h   |  2 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    | 17 -----
>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c       | 13 +++-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c     |  3 -
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c        |  7 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_object.h    |  1 +
>  drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c        |  9 +--
>  drivers/gpu/drm/amd/amdgpu/amdgpu_pm.h        |  2 +
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c      | 15 +---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h      |  4 ++
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c       | 14 +---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h       |  3 +
>  drivers/gpu/drm/amd/amdgpu/atombios_dp.c      | 10 +--
>  drivers/gpu/drm/amd/amdgpu/dce_virtual.c      |  1 -
>  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 26 +++----
>  .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c |  3 +
>  .../display/amdgpu_dm/amdgpu_dm_mst_types.c   | 13 ++--
>  19 files changed, 140 insertions(+), 89 deletions(-)
>
Alex Deucher April 8, 2020, 1:51 p.m. UTC | #3
On Wed, Apr 8, 2020 at 3:38 AM Thomas Zimmermann <tzimmermann@suse.de> wrote:
>
> Hi Alex
>
> Am 07.02.20 um 20:50 schrieb Alex Deucher:
> > These are deprecated and the drm will soon start warning when drivers still
> > use them.  It was a long and twisty road, but seems to work.
>
> Are you going to convert radeon as well? It's the only remaining KMS
> driver that uses load.

It's on my todo list, hopefully this kernel cycle.

Alex

>
> Best regards
> Thomas
>
> >
> > v2: Add additional patch (13/15) which should fix the crash reported by
> > Thomas Zimmermann.
> > v3: Fix dp aux registration harder, add missing kconfig guard
> >
> > Alex Deucher (15):
> >   drm/amdgpu: rename amdgpu_debugfs_preempt_cleanup
> >   drm/amdgpu/ttm: move debugfs init into core amdgpu debugfs
> >   drm/amdgpu/pm: move debugfs init into core amdgpu debugfs
> >   drm/amdgpu/sa: move debugfs init into core amdgpu debugfs
> >   drm/amdgpu/fence: move debugfs init into core amdgpu debugfs
> >   drm/amdgpu/gem: move debugfs init into core amdgpu debugfs
> >   drm/amdgpu/regs: move debugfs init into core amdgpu debugfs
> >   drm/amdgpu/firmware: move debugfs init into core amdgpu debugfs
> >   drm/amdgpu: don't call drm_connector_register for non-MST ports
> >   drm/amdgpu/display: move debugfs init into core amdgpu debugfs (v2)
> >   drm/amd/display: move dpcd debugfs members setup
> >   drm/amdgpu/display: add a late register connector callback
> >   drm/amdgpu/display: split dp connector registration (v2)
> >   drm/amdgpu/ring: move debugfs init into core amdgpu debugfs
> >   drm/amdgpu: drop legacy drm load and unload callbacks
> >
> >  .../gpu/drm/amd/amdgpu/amdgpu_connectors.c    | 17 ++++-
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c   | 69 ++++++++++++++++++-
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.h   |  2 +-
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    | 17 -----
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c       | 13 +++-
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c     |  3 -
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c        |  7 +-
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_object.h    |  1 +
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c        |  9 +--
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_pm.h        |  2 +
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c      | 15 +---
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h      |  4 ++
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c       | 14 +---
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h       |  3 +
> >  drivers/gpu/drm/amd/amdgpu/atombios_dp.c      | 10 +--
> >  drivers/gpu/drm/amd/amdgpu/dce_virtual.c      |  1 -
> >  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 26 +++----
> >  .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c |  3 +
> >  .../display/amdgpu_dm/amdgpu_dm_mst_types.c   | 13 ++--
> >  19 files changed, 140 insertions(+), 89 deletions(-)
> >
>
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Felix Imendörffer
>