| Message ID | 20200306234623.547525-1-lyude@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/dp_mst: Fix bandwidth checking regressions from DSC patches | expand |
Hi, On 3/7/20 12:46 AM, Lyude Paul wrote: > AMD's patch series for adding DSC support to the MST helpers > unfortunately introduced a few regressions into the kernel that I didn't > get around to fixing until just now. I would have reverted the changes > earlier, but seeing as that would have reverted all of amd's DSC support > + everything that was done on top of that I realllllly wanted to avoid > doing that. > > Anyway, this should fix everything bandwidth-check related as far as I > can tell (I found some other regressions unrelated to AMD's DSC patches > which I'll be sending out patches for shortly). Note that I don't have > any DSC displays locally yet, so if someone from AMD could sanity check > this I would appreciate it ♥. I can confirm that this series fixes only of the 2 FHD monitors on my Lenovo TB3 gen 2 dock lighting up, thank you! This series is: Tested-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > > Cc: Mikita Lipski <mikita.lipski@amd.com> > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: Sean Paul <seanpaul@google.com> > Cc: Hans de Goede <hdegoede@redhat.com> > > Lyude Paul (4): > drm/dp_mst: Rename drm_dp_mst_is_dp_mst_end_device() to be less > redundant > drm/dp_mst: Use full_pbn instead of available_pbn for bandwidth checks > drm/dp_mst: Reprobe path resources in CSN handler > drm/dp_mst: Rewrite and fix bandwidth limit checks > > drivers/gpu/drm/drm_dp_mst_topology.c | 185 ++++++++++++++++++-------- > include/drm/drm_dp_mst_helper.h | 4 +- > 2 files changed, 129 insertions(+), 60 deletions(-) >
On 3/6/20 6:46 PM, Lyude Paul wrote: > AMD's patch series for adding DSC support to the MST helpers > unfortunately introduced a few regressions into the kernel that I didn't > get around to fixing until just now. I would have reverted the changes > earlier, but seeing as that would have reverted all of amd's DSC support > + everything that was done on top of that I realllllly wanted to avoid > doing that. > > Anyway, this should fix everything bandwidth-check related as far as I > can tell (I found some other regressions unrelated to AMD's DSC patches > which I'll be sending out patches for shortly). Note that I don't have > any DSC displays locally yet, so if someone from AMD could sanity check > this I would appreciate it ♥. The series is tested and verified with MST DSC Realtek board. Tested-by: Mikita Lipski <mikita.lipski@amd.com> > > Cc: Mikita Lipski <mikita.lipski@amd.com> > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: Sean Paul <seanpaul@google.com> > Cc: Hans de Goede <hdegoede@redhat.com> > > Lyude Paul (4): > drm/dp_mst: Rename drm_dp_mst_is_dp_mst_end_device() to be less > redundant > drm/dp_mst: Use full_pbn instead of available_pbn for bandwidth checks > drm/dp_mst: Reprobe path resources in CSN handler > drm/dp_mst: Rewrite and fix bandwidth limit checks > > drivers/gpu/drm/drm_dp_mst_topology.c | 185 ++++++++++++++++++-------- > include/drm/drm_dp_mst_helper.h | 4 +- > 2 files changed, 129 insertions(+), 60 deletions(-) >
AMD's patch series for adding DSC support to the MST helpers unfortunately introduced a few regressions into the kernel that I didn't get around to fixing until just now. I would have reverted the changes earlier, but seeing as that would have reverted all of amd's DSC support + everything that was done on top of that I realllllly wanted to avoid doing that. Anyway, this should fix everything bandwidth-check related as far as I can tell (I found some other regressions unrelated to AMD's DSC patches which I'll be sending out patches for shortly). Note that I don't have any DSC displays locally yet, so if someone from AMD could sanity check this I would appreciate it ♥. Cc: Mikita Lipski <mikita.lipski@amd.com> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: Sean Paul <seanpaul@google.com> Cc: Hans de Goede <hdegoede@redhat.com> Lyude Paul (4): drm/dp_mst: Rename drm_dp_mst_is_dp_mst_end_device() to be less redundant drm/dp_mst: Use full_pbn instead of available_pbn for bandwidth checks drm/dp_mst: Reprobe path resources in CSN handler drm/dp_mst: Rewrite and fix bandwidth limit checks drivers/gpu/drm/drm_dp_mst_topology.c | 185 ++++++++++++++++++-------- include/drm/drm_dp_mst_helper.h | 4 +- 2 files changed, 129 insertions(+), 60 deletions(-)