mbox series

[v2,0/2] drm/udl: Map pages with SHMEM helpers

Message ID 20200519080423.21695-1-tzimmermann@suse.de (mailing list archive)
Headers show
Series drm/udl: Map pages with SHMEM helpers | expand

Message

Thomas Zimmermann May 19, 2020, 8:04 a.m. UTC
(was: Default to cachable mappings for GEM SHMEM)

Udl implments cached mappings. Convert it to SHMEM's default helpers.

v2:
	* keep writecombine mappings as the default
	* add SHMEM helper for creating BOs with cached mappings
	* update udl on the new helper

Thomas Zimmermann (2):
  drm/shmem-helper: Add .gem_create_object helper that sets map_cached
    flag
  drm/udl: Use GEM vmap/mmap function from SHMEM helpers

 drivers/gpu/drm/drm_gem_shmem_helper.c |  27 +++++++
 drivers/gpu/drm/udl/Makefile           |   2 +-
 drivers/gpu/drm/udl/udl_drv.c          |   4 +-
 drivers/gpu/drm/udl/udl_drv.h          |   3 -
 drivers/gpu/drm/udl/udl_gem.c          | 106 -------------------------
 include/drm/drm_gem_shmem_helper.h     |   4 +
 6 files changed, 34 insertions(+), 112 deletions(-)
 delete mode 100644 drivers/gpu/drm/udl/udl_gem.c

--
2.26.2

Comments

Emil Velikov May 19, 2020, 8:25 p.m. UTC | #1
On Tue, 19 May 2020 at 09:04, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>
> (was: Default to cachable mappings for GEM SHMEM)
>
> Udl implments cached mappings. Convert it to SHMEM's default helpers.
>
> v2:
>         * keep writecombine mappings as the default
>         * add SHMEM helper for creating BOs with cached mappings
>         * update udl on the new helper
>
> Thomas Zimmermann (2):
>   drm/shmem-helper: Add .gem_create_object helper that sets map_cached
>     flag
>   drm/udl: Use GEM vmap/mmap function from SHMEM helpers
>
For the series:
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

>  drivers/gpu/drm/drm_gem_shmem_helper.c |  27 +++++++
>  drivers/gpu/drm/udl/Makefile           |   2 +-
>  drivers/gpu/drm/udl/udl_drv.c          |   4 +-
>  drivers/gpu/drm/udl/udl_drv.h          |   3 -
>  drivers/gpu/drm/udl/udl_gem.c          | 106 -------------------------
>  include/drm/drm_gem_shmem_helper.h     |   4 +
>  6 files changed, 34 insertions(+), 112 deletions(-)
>  delete mode 100644 drivers/gpu/drm/udl/udl_gem.c
>
Please keep going with these nice stats \o/

-Emil