| Message ID | 20200609012518.198908-1-stevensd@chromium.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Support virtio cross-device resources | expand |
On Tue, Jun 09, 2020 at 10:25:15AM +0900, David Stevens wrote: > This patchset implements the current proposal for virtio cross-device > resource sharing [1]. It will be used to import virtio resources into > the virtio-video driver currently under discussion [2]. The patch > under consideration to add support in the virtio-video driver is [3]. > It uses the APIs from v3 of this series, but the changes to update it > are relatively minor. > > This patchset adds a new flavor of dma-bufs that supports querying the > underlying virtio object UUID, as well as adding support for exporting > resources from virtgpu. Gerd, David, if possible, please test this in configuration with virtual VTD enabled but with iommu_platform=off to make sure we didn't break this config. Besides that, for virtio parts: Acked-by: Michael S. Tsirkin <mst@redhat.com> > [1] https://markmail.org/thread/2ypjt5cfeu3m6lxu > [2] https://markmail.org/thread/p5d3k566srtdtute > [3] https://markmail.org/thread/j4xlqaaim266qpks > > v4 -> v5 changes: > - Remove virtio_dma_buf_export_info. > > David Stevens (3): > virtio: add dma-buf support for exported objects > virtio-gpu: add VIRTIO_GPU_F_RESOURCE_UUID feature > drm/virtio: Support virtgpu exported resources > > drivers/gpu/drm/virtio/virtgpu_drv.c | 3 + > drivers/gpu/drm/virtio/virtgpu_drv.h | 20 ++++++ > drivers/gpu/drm/virtio/virtgpu_kms.c | 4 ++ > drivers/gpu/drm/virtio/virtgpu_prime.c | 96 +++++++++++++++++++++++++- > drivers/gpu/drm/virtio/virtgpu_vq.c | 55 +++++++++++++++ > drivers/virtio/Makefile | 2 +- > drivers/virtio/virtio.c | 6 ++ > drivers/virtio/virtio_dma_buf.c | 82 ++++++++++++++++++++++ > include/linux/virtio.h | 1 + > include/linux/virtio_dma_buf.h | 37 ++++++++++ > include/uapi/linux/virtio_gpu.h | 19 +++++ > 11 files changed, 321 insertions(+), 4 deletions(-) > create mode 100644 drivers/virtio/virtio_dma_buf.c > create mode 100644 include/linux/virtio_dma_buf.h > > -- > 2.27.0.278.ge193c7cf3a9-goog
Unless there are any remaining objections to these patches, what are the next steps towards getting these merged? Sorry, I'm not familiar with the workflow for contributing patches to Linux. Thanks, David On Tue, Jun 9, 2020 at 6:53 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > On Tue, Jun 09, 2020 at 10:25:15AM +0900, David Stevens wrote: > > This patchset implements the current proposal for virtio cross-device > > resource sharing [1]. It will be used to import virtio resources into > > the virtio-video driver currently under discussion [2]. The patch > > under consideration to add support in the virtio-video driver is [3]. > > It uses the APIs from v3 of this series, but the changes to update it > > are relatively minor. > > > > This patchset adds a new flavor of dma-bufs that supports querying the > > underlying virtio object UUID, as well as adding support for exporting > > resources from virtgpu. > > Gerd, David, if possible, please test this in configuration with > virtual VTD enabled but with iommu_platform=off > to make sure we didn't break this config. > > > Besides that, for virtio parts: > > Acked-by: Michael S. Tsirkin <mst@redhat.com> > > > > [1] https://markmail.org/thread/2ypjt5cfeu3m6lxu > > [2] https://markmail.org/thread/p5d3k566srtdtute > > [3] https://markmail.org/thread/j4xlqaaim266qpks > > > > v4 -> v5 changes: > > - Remove virtio_dma_buf_export_info. > > > > David Stevens (3): > > virtio: add dma-buf support for exported objects > > virtio-gpu: add VIRTIO_GPU_F_RESOURCE_UUID feature > > drm/virtio: Support virtgpu exported resources > > > > drivers/gpu/drm/virtio/virtgpu_drv.c | 3 + > > drivers/gpu/drm/virtio/virtgpu_drv.h | 20 ++++++ > > drivers/gpu/drm/virtio/virtgpu_kms.c | 4 ++ > > drivers/gpu/drm/virtio/virtgpu_prime.c | 96 +++++++++++++++++++++++++- > > drivers/gpu/drm/virtio/virtgpu_vq.c | 55 +++++++++++++++ > > drivers/virtio/Makefile | 2 +- > > drivers/virtio/virtio.c | 6 ++ > > drivers/virtio/virtio_dma_buf.c | 82 ++++++++++++++++++++++ > > include/linux/virtio.h | 1 + > > include/linux/virtio_dma_buf.h | 37 ++++++++++ > > include/uapi/linux/virtio_gpu.h | 19 +++++ > > 11 files changed, 321 insertions(+), 4 deletions(-) > > create mode 100644 drivers/virtio/virtio_dma_buf.c > > create mode 100644 include/linux/virtio_dma_buf.h > > > > -- > > 2.27.0.278.ge193c7cf3a9-goog > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org >
On Tue, Jun 23, 2020 at 10:31:28AM +0900, David Stevens wrote: > Unless there are any remaining objections to these patches, what are > the next steps towards getting these merged? Sorry, I'm not familiar > with the workflow for contributing patches to Linux. Sorry, just have been busy and not paying as much attention to drm patches as usual. Playing catch-up now. Queued for drm-misc-next, unless something goes wrong in my testing the patches should land in linux-next soon and be merged upstream in the next merge window. take care, Gerd
On Mon, Aug 17, 2020 at 12:50:08PM +0200, Gerd Hoffmann wrote: > On Tue, Jun 23, 2020 at 10:31:28AM +0900, David Stevens wrote: > > Unless there are any remaining objections to these patches, what are > > the next steps towards getting these merged? Sorry, I'm not familiar > > with the workflow for contributing patches to Linux. > > Sorry, just have been busy and not paying as much attention to drm > patches as usual. Playing catch-up now. Queued for drm-misc-next, > unless something goes wrong in my testing the patches should land > in linux-next soon and be merged upstream in the next merge window. Oh, spoke too soon. scripts/checkpatch.pl has a bunch of codestyle warnings. Can you fix them and resend? thanks, Gerd
On Mon, Aug 17, 2020 at 4:12 AM Gerd Hoffmann <kraxel@redhat.com> wrote: > > On Mon, Aug 17, 2020 at 12:50:08PM +0200, Gerd Hoffmann wrote: > > On Tue, Jun 23, 2020 at 10:31:28AM +0900, David Stevens wrote: > > > Unless there are any remaining objections to these patches, what are > > > the next steps towards getting these merged? Sorry, I'm not familiar > > > with the workflow for contributing patches to Linux. > > > > Sorry, just have been busy and not paying as much attention to drm > > patches as usual. Playing catch-up now. Queued for drm-misc-next, > > unless something goes wrong in my testing the patches should land > > in linux-next soon and be merged upstream in the next merge window. > > Oh, spoke too soon. scripts/checkpatch.pl has a bunch of codestyle > warnings. Can you fix them and resend? Sent a new version to fix the line length warning. There's still a MAINTAINER warning, but I think the new virtio_dma_buf file can fall under virtio core (and the existing wildcards do match it), rather than get its own MAINTAINER entry. I can break it out into its own thing if that's better, though. -David