| Message ID | 20200612015030.16072-1-tanmay@codeaurora.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support for DisplayPort driver on | expand |
Quoting Tanmay Shah (2020-06-11 18:50:25) > These patches add support for Display-Port driver on SnapDragon > hardware. It adds > DP driver and DP PLL driver files along with the needed device-tree > bindings. > > The block diagram of DP driver is shown below: > > > +-------------+ > |DRM FRAMEWORK| > +------+------+ > | > +----v----+ > | DP DRM | > +----+----+ > | > +----v----+ > +------------+| DP +----------++------+ > + +---+| DISPLAY |+---+ | | > | + +-+-----+-+ | | | > | | | | | | | > | | | | | | | > | | | | | | | > v v v v v v v > +------+ +------+ +---+ +----+ +----+ +---+ +-----+ > | DP | | DP | |DP | | DP | | DP | |DP | | DP | > |PARSER| | HPD | |AUX| |LINK| |CTRL| |PHY| |POWER| > +--+---+ +---+--+ +---+ +----+ +--+-+ +-+-+ +-----+ > | | | > +--v---+ +v-----v+ > |DEVICE| | DP | > | TREE | |CATALOG| > +------+ +---+---+ > | > +---v----+ > |CTRL/PHY| > | HW | > +--------+ > I've never seen a block diagram for a driver before... > > These patches have dependency on clock driver changes mentioned below: > https://patchwork.kernel.org/patch/11245895/ > https://patchwork.kernel.org/cover/11069083/ These are merged right? Don't need to include this if it's already merged. Can you include a changelog in the cover letter too so we know what has changed between versions of the patchset? > > Chandan Uddaraju (4): > dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon > drm: add constant N value in helper file > drm/msm/dp: add displayPort driver support > drm/msm/dp: add support for DP PLL driver > > Jeykumar Sankaran (1): > drm/msm/dpu: add display port support in DPU > [...] > > > base-commit: 48f99181fc118d82dc8bf6c7221ad1c654cb8bc2 What is this commit? I don't see it in linux-next.
On 2020-06-12 16:26, Stephen Boyd wrote: Thanks for reviews Stephen. > Quoting Tanmay Shah (2020-06-11 18:50:25) >> These patches add support for Display-Port driver on SnapDragon >> hardware. It adds >> DP driver and DP PLL driver files along with the needed device-tree >> bindings. >> >> The block diagram of DP driver is shown below: >> >> >> +-------------+ >> |DRM FRAMEWORK| >> +------+------+ >> | >> +----v----+ >> | DP DRM | >> +----+----+ >> | >> +----v----+ >> +------------+| DP +----------++------+ >> + +---+| DISPLAY |+---+ | | >> | + +-+-----+-+ | | | >> | | | | | | | >> | | | | | | | >> | | | | | | | >> v v v v v v v >> +------+ +------+ +---+ +----+ +----+ +---+ +-----+ >> | DP | | DP | |DP | | DP | | DP | |DP | | DP | >> |PARSER| | HPD | |AUX| |LINK| |CTRL| |PHY| |POWER| >> +--+---+ +---+--+ +---+ +----+ +--+-+ +-+-+ +-----+ >> | | | >> +--v---+ +v-----v+ >> |DEVICE| | DP | >> | TREE | |CATALOG| >> +------+ +---+---+ >> | >> +---v----+ >> |CTRL/PHY| >> | HW | >> +--------+ >> > > I've never seen a block diagram for a driver before... > It is here for v5. https://patchwork.freedesktop.org/series/74312/ >> >> These patches have dependency on clock driver changes mentioned below: >> https://patchwork.kernel.org/patch/11245895/ >> https://patchwork.kernel.org/cover/11069083/ > > These are merged right? Don't need to include this if it's already > merged. > Ok Thanks. > Can you include a changelog in the cover letter too so we know what has > changed between versions of the patchset? > Sure. >> >> Chandan Uddaraju (4): >> dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon >> drm: add constant N value in helper file >> drm/msm/dp: add displayPort driver support >> drm/msm/dp: add support for DP PLL driver >> >> Jeykumar Sankaran (1): >> drm/msm/dpu: add display port support in DPU >> > [...] >> >> >> base-commit: 48f99181fc118d82dc8bf6c7221ad1c654cb8bc2 > > What is this commit? I don't see it in linux-next. Here: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20200603&id=48f99181fc118d82dc8bf6c7221ad1c654cb8bc2
On Mon, Jun 15, 2020 at 4:51 PM <tanmay@codeaurora.org> wrote: > > On 2020-06-12 16:26, Stephen Boyd wrote: > > Thanks for reviews Stephen. > > > Quoting Tanmay Shah (2020-06-11 18:50:25) > >> These patches add support for Display-Port driver on SnapDragon > >> hardware. It adds > >> DP driver and DP PLL driver files along with the needed device-tree > >> bindings. > >> > >> The block diagram of DP driver is shown below: > >> > >> > >> +-------------+ > >> |DRM FRAMEWORK| > >> +------+------+ > >> | > >> +----v----+ > >> | DP DRM | > >> +----+----+ > >> | > >> +----v----+ > >> +------------+| DP +----------++------+ > >> + +---+| DISPLAY |+---+ | | > >> | + +-+-----+-+ | | | > >> | | | | | | | > >> | | | | | | | > >> | | | | | | | > >> v v v v v v v > >> +------+ +------+ +---+ +----+ +----+ +---+ +-----+ > >> | DP | | DP | |DP | | DP | | DP | |DP | | DP | > >> |PARSER| | HPD | |AUX| |LINK| |CTRL| |PHY| |POWER| > >> +--+---+ +---+--+ +---+ +----+ +--+-+ +-+-+ +-----+ > >> | | | > >> +--v---+ +v-----v+ > >> |DEVICE| | DP | > >> | TREE | |CATALOG| > >> +------+ +---+---+ > >> | > >> +---v----+ > >> |CTRL/PHY| > >> | HW | > >> +--------+ > >> > > > > I've never seen a block diagram for a driver before... > > > It is here for v5. https://patchwork.freedesktop.org/series/74312/ I think Stephen is nitpicking your wording, and you seem to not be understanding his comment. I'm sorry if I am mistaken. The "DP driver" would seem to refer to the linux software driver you are proposing patches for, however this diagram looks like a hardware diagram of the various hardware blocks that the Linux driver code (the "DP driver") is expected to interact with. I believe you should re-word "The block diagram of DP driver is shown below:" to be more specific of what you are describing with your figure. IE your words say this is a block diagram of the software, when it looks like it is a block diagram of the hardware.
On 2020-06-15 16:04, Jeffrey Hugo wrote: > On Mon, Jun 15, 2020 at 4:51 PM <tanmay@codeaurora.org> wrote: >> >> On 2020-06-12 16:26, Stephen Boyd wrote: >> >> Thanks for reviews Stephen. >> >> > Quoting Tanmay Shah (2020-06-11 18:50:25) >> >> These patches add support for Display-Port driver on SnapDragon >> >> hardware. It adds >> >> DP driver and DP PLL driver files along with the needed device-tree >> >> bindings. >> >> >> >> The block diagram of DP driver is shown below: >> >> >> >> >> >> +-------------+ >> >> |DRM FRAMEWORK| >> >> +------+------+ >> >> | >> >> +----v----+ >> >> | DP DRM | >> >> +----+----+ >> >> | >> >> +----v----+ >> >> +------------+| DP +----------++------+ >> >> + +---+| DISPLAY |+---+ | | >> >> | + +-+-----+-+ | | | >> >> | | | | | | | >> >> | | | | | | | >> >> | | | | | | | >> >> v v v v v v v >> >> +------+ +------+ +---+ +----+ +----+ +---+ +-----+ >> >> | DP | | DP | |DP | | DP | | DP | |DP | | DP | >> >> |PARSER| | HPD | |AUX| |LINK| |CTRL| |PHY| |POWER| >> >> +--+---+ +---+--+ +---+ +----+ +--+-+ +-+-+ +-----+ >> >> | | | >> >> +--v---+ +v-----v+ >> >> |DEVICE| | DP | >> >> | TREE | |CATALOG| >> >> +------+ +---+---+ >> >> | >> >> +---v----+ >> >> |CTRL/PHY| >> >> | HW | >> >> +--------+ >> >> >> > >> > I've never seen a block diagram for a driver before... >> > >> It is here for v5. https://patchwork.freedesktop.org/series/74312/ > > I think Stephen is nitpicking your wording, and you seem to not be > understanding his comment. I'm sorry if I am mistaken. > > The "DP driver" would seem to refer to the linux software driver you > are proposing patches for, however this diagram looks like a hardware > diagram of the various hardware blocks that the Linux driver code (the > "DP driver") is expected to interact with. I believe you should > re-word "The block diagram of DP driver is shown below:" to be more > specific of what you are describing with your figure. IE your words > say this is a block diagram of the software, when it looks like it is > a block diagram of the hardware. Thanks for reviews. I am not sure what Stephen meant, but this diagram was available before. Just for clarification this is not hardware diagram at all. This is modeling of DP driver for msm. Each box name above except "DRM framework", is file name in driver i.e. software module. Each line and arrow shows how modules interact with each other. For example, "DP PARSER" Box is pointing towards "DEVICE TREE" Box, that means dp_parser.c file contains functions which are parsing device tree properties and so on...
Quoting tanmay@codeaurora.org (2020-06-15 16:36:52) > On 2020-06-15 16:04, Jeffrey Hugo wrote: > >> > > >> > I've never seen a block diagram for a driver before... > >> > > >> It is here for v5. https://patchwork.freedesktop.org/series/74312/ > > > > I think Stephen is nitpicking your wording, and you seem to not be > > understanding his comment. I'm sorry if I am mistaken. > > > > The "DP driver" would seem to refer to the linux software driver you > > are proposing patches for, however this diagram looks like a hardware > > diagram of the various hardware blocks that the Linux driver code (the > > "DP driver") is expected to interact with. I believe you should > > re-word "The block diagram of DP driver is shown below:" to be more > > specific of what you are describing with your figure. IE your words > > say this is a block diagram of the software, when it looks like it is > > a block diagram of the hardware. > > Thanks for reviews. > > I am not sure what Stephen meant, but this diagram was available before. > > Just for clarification this is not hardware diagram at all. > This is modeling of DP driver for msm. > Each box name above except "DRM framework", is file name in driver i.e. > software module. > Each line and arrow shows how modules interact with each other. > > For example, "DP PARSER" Box is pointing towards "DEVICE TREE" Box, that > means > dp_parser.c file contains functions which are parsing device tree > properties and so on... Yes sorry for being obtuse. To be more direct I'll just say that needing to have a block diagram for a device driver is not a great start. Device drivers shouldn't be as complicated to need a block diagram to guide the reviewer. If we need them then we've failed to consolidate enough logic into the core device driver frameworks.
These patches add support for Display-Port driver on SnapDragon hardware. It adds DP driver and DP PLL driver files along with the needed device-tree bindings. The block diagram of DP driver is shown below: +-------------+ |DRM FRAMEWORK| +------+------+ | +----v----+ | DP DRM | +----+----+ | +----v----+ +------------+| DP +----------++------+ + +---+| DISPLAY |+---+ | | | + +-+-----+-+ | | | | | | | | | | | | | | | | | | | | | | | | v v v v v v v +------+ +------+ +---+ +----+ +----+ +---+ +-----+ | DP | | DP | |DP | | DP | | DP | |DP | | DP | |PARSER| | HPD | |AUX| |LINK| |CTRL| |PHY| |POWER| +--+---+ +---+--+ +---+ +----+ +--+-+ +-+-+ +-----+ | | | +--v---+ +v-----v+ |DEVICE| | DP | | TREE | |CATALOG| +------+ +---+---+ | +---v----+ |CTRL/PHY| | HW | +--------+ These patches have dependency on clock driver changes mentioned below: https://patchwork.kernel.org/patch/11245895/ https://patchwork.kernel.org/cover/11069083/ Chandan Uddaraju (4): dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon drm: add constant N value in helper file drm/msm/dp: add displayPort driver support drm/msm/dp: add support for DP PLL driver Jeykumar Sankaran (1): drm/msm/dpu: add display port support in DPU .../bindings/display/msm/dp-sc7180.yaml | 142 ++ .../devicetree/bindings/display/msm/dpu.txt | 8 + drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/msm/Kconfig | 21 + drivers/gpu/drm/msm/Makefile | 15 + drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 29 +- .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 8 + drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 65 +- drivers/gpu/drm/msm/dp/dp_aux.c | 530 +++++ drivers/gpu/drm/msm/dp/dp_aux.h | 35 + drivers/gpu/drm/msm/dp/dp_catalog.c | 1025 ++++++++++ drivers/gpu/drm/msm/dp/dp_catalog.h | 86 + drivers/gpu/drm/msm/dp/dp_ctrl.c | 1709 +++++++++++++++++ drivers/gpu/drm/msm/dp/dp_ctrl.h | 35 + drivers/gpu/drm/msm/dp/dp_display.c | 912 +++++++++ drivers/gpu/drm/msm/dp/dp_display.h | 31 + drivers/gpu/drm/msm/dp/dp_drm.c | 170 ++ drivers/gpu/drm/msm/dp/dp_drm.h | 18 + drivers/gpu/drm/msm/dp/dp_hpd.c | 69 + drivers/gpu/drm/msm/dp/dp_hpd.h | 79 + drivers/gpu/drm/msm/dp/dp_link.c | 1216 ++++++++++++ drivers/gpu/drm/msm/dp/dp_link.h | 132 ++ drivers/gpu/drm/msm/dp/dp_panel.c | 490 +++++ drivers/gpu/drm/msm/dp/dp_panel.h | 95 + drivers/gpu/drm/msm/dp/dp_parser.c | 390 ++++ drivers/gpu/drm/msm/dp/dp_parser.h | 204 ++ drivers/gpu/drm/msm/dp/dp_pll.c | 93 + drivers/gpu/drm/msm/dp/dp_pll.h | 59 + drivers/gpu/drm/msm/dp/dp_pll_10nm.c | 903 +++++++++ drivers/gpu/drm/msm/dp/dp_pll_private.h | 103 + drivers/gpu/drm/msm/dp/dp_power.c | 422 ++++ drivers/gpu/drm/msm/dp/dp_power.h | 115 ++ drivers/gpu/drm/msm/dp/dp_reg.h | 505 +++++ drivers/gpu/drm/msm/msm_drv.c | 2 + drivers/gpu/drm/msm/msm_drv.h | 53 +- include/drm/drm_dp_helper.h | 1 + 36 files changed, 9753 insertions(+), 19 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.c create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.h create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.c create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.h create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.c create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.h create mode 100644 drivers/gpu/drm/msm/dp/dp_display.c create mode 100644 drivers/gpu/drm/msm/dp/dp_display.h create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.c create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.h create mode 100644 drivers/gpu/drm/msm/dp/dp_hpd.c create mode 100644 drivers/gpu/drm/msm/dp/dp_hpd.h create mode 100644 drivers/gpu/drm/msm/dp/dp_link.c create mode 100644 drivers/gpu/drm/msm/dp/dp_link.h create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.c create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.h create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.c create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.h create mode 100644 drivers/gpu/drm/msm/dp/dp_pll.c create mode 100644 drivers/gpu/drm/msm/dp/dp_pll.h create mode 100644 drivers/gpu/drm/msm/dp/dp_pll_10nm.c create mode 100644 drivers/gpu/drm/msm/dp/dp_pll_private.h create mode 100644 drivers/gpu/drm/msm/dp/dp_power.c create mode 100644 drivers/gpu/drm/msm/dp/dp_power.h create mode 100644 drivers/gpu/drm/msm/dp/dp_reg.h base-commit: 48f99181fc118d82dc8bf6c7221ad1c654cb8bc2