| Message ID | 20200918100812.1447443-1-arnd@arndb.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | fbdev: stop using compat_alloc_user_space | expand |
On Fri, Sep 18, 2020 at 12:08:10PM +0200, Arnd Bergmann wrote: > The fbdev code uses compat_alloc_user_space in a few of its > compat_ioctl handlers, which tends to be a bit more complicated > and error-prone than calling the underlying handlers directly, > so I would like to remove it completely. > > This modifies two such functions in fbdev, and removes another > one that is completely unused. > > Arnd > > Arnd Bergmann (3): > fbdev: simplify fb_getput_cmap() > fbdev: sbuslib: remove unused FBIOSCURSOR32 helper > fbdev: sbuslib: remove compat_alloc_user_space usage Looks all good, but we're also kinda looking for a new volunteer for handling fbdev patches ... drm-misc commit rights, still not interested? -Daniel > > drivers/video/fbdev/core/fbmem.c | 44 +++++------ > drivers/video/fbdev/sbuslib.c | 124 ++++++++++++++++++------------- > 2 files changed, 90 insertions(+), 78 deletions(-) > > -- > 2.27.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Daniel/Arnd. On Fri, Sep 18, 2020 at 02:48:08PM +0200, Daniel Vetter wrote: > On Fri, Sep 18, 2020 at 12:08:10PM +0200, Arnd Bergmann wrote: > > The fbdev code uses compat_alloc_user_space in a few of its > > compat_ioctl handlers, which tends to be a bit more complicated > > and error-prone than calling the underlying handlers directly, > > so I would like to remove it completely. > > > > This modifies two such functions in fbdev, and removes another > > one that is completely unused. > > > > Arnd > > > > Arnd Bergmann (3): > > fbdev: simplify fb_getput_cmap() > > fbdev: sbuslib: remove unused FBIOSCURSOR32 helper > > fbdev: sbuslib: remove compat_alloc_user_space usage > > Looks all good, but we're also kinda looking for a new volunteer for > handling fbdev patches ... drm-misc commit rights, still not interested? Hi Daniel - I read the above as an a-b. And Arnd did not take the bait it seems. Hi Arnd. checkpatch complained about some whitespace, which I fixed while applying. Will push to drm-misc-next tomorrow unless I hear anything else. Sam > -Daniel > > > > > drivers/video/fbdev/core/fbmem.c | 44 +++++------ > > drivers/video/fbdev/sbuslib.c | 124 ++++++++++++++++++------------- > > 2 files changed, 90 insertions(+), 78 deletions(-) > > > > -- > > 2.27.0 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Thu, Sep 24, 2020 at 10:54 PM Sam Ravnborg <sam@ravnborg.org> wrote: > > Hi Daniel/Arnd. > > On Fri, Sep 18, 2020 at 02:48:08PM +0200, Daniel Vetter wrote: > > On Fri, Sep 18, 2020 at 12:08:10PM +0200, Arnd Bergmann wrote: > > > The fbdev code uses compat_alloc_user_space in a few of its > > > compat_ioctl handlers, which tends to be a bit more complicated > > > and error-prone than calling the underlying handlers directly, > > > so I would like to remove it completely. > > > > > > This modifies two such functions in fbdev, and removes another > > > one that is completely unused. > > > > > > Arnd > > > > > > Arnd Bergmann (3): > > > fbdev: simplify fb_getput_cmap() > > > fbdev: sbuslib: remove unused FBIOSCURSOR32 helper > > > fbdev: sbuslib: remove compat_alloc_user_space usage > > > > Looks all good, but we're also kinda looking for a new volunteer for > > handling fbdev patches ... drm-misc commit rights, still not interested? > > Hi Daniel - I read the above as an a-b. And Arnd did not take the bait > it seems. Ah right, I meant to reply but then forgot about it. I don't really want commit access, thanks for the offer. > Hi Arnd. checkpatch complained about some whitespace, which I fixed > while applying. > Will push to drm-misc-next tomorrow unless I hear anything else. Great, thanks! Arnd
On Fri, Sep 25, 2020 at 01:31:51PM +0200, Arnd Bergmann wrote: > On Thu, Sep 24, 2020 at 10:54 PM Sam Ravnborg <sam@ravnborg.org> wrote: > > > > Hi Daniel/Arnd. > > > > On Fri, Sep 18, 2020 at 02:48:08PM +0200, Daniel Vetter wrote: > > > On Fri, Sep 18, 2020 at 12:08:10PM +0200, Arnd Bergmann wrote: > > > > The fbdev code uses compat_alloc_user_space in a few of its > > > > compat_ioctl handlers, which tends to be a bit more complicated > > > > and error-prone than calling the underlying handlers directly, > > > > so I would like to remove it completely. > > > > > > > > This modifies two such functions in fbdev, and removes another > > > > one that is completely unused. > > > > > > > > Arnd > > > > > > > > Arnd Bergmann (3): > > > > fbdev: simplify fb_getput_cmap() > > > > fbdev: sbuslib: remove unused FBIOSCURSOR32 helper > > > > fbdev: sbuslib: remove compat_alloc_user_space usage > > > > > > Looks all good, but we're also kinda looking for a new volunteer for > > > handling fbdev patches ... drm-misc commit rights, still not interested? > > > > Hi Daniel - I read the above as an a-b. And Arnd did not take the bait > > it seems. > > Ah right, I meant to reply but then forgot about it. > > I don't really want commit access, thanks for the offer. > > > Hi Arnd. checkpatch complained about some whitespace, which I fixed > > while applying. > > Will push to drm-misc-next tomorrow unless I hear anything else. > > Great, thanks! Pushed now. Sam
The fbdev code uses compat_alloc_user_space in a few of its compat_ioctl handlers, which tends to be a bit more complicated and error-prone than calling the underlying handlers directly, so I would like to remove it completely. This modifies two such functions in fbdev, and removes another one that is completely unused. Arnd Arnd Bergmann (3): fbdev: simplify fb_getput_cmap() fbdev: sbuslib: remove unused FBIOSCURSOR32 helper fbdev: sbuslib: remove compat_alloc_user_space usage drivers/video/fbdev/core/fbmem.c | 44 +++++------ drivers/video/fbdev/sbuslib.c | 124 ++++++++++++++++++------------- 2 files changed, 90 insertions(+), 78 deletions(-)