mbox series

[v3,0/4] Fixes to bridge/panel and ingenic-drm

Message ID 20210124085552.29146-1-paul@crapouillou.net (mailing list archive)
Headers show
Series Fixes to bridge/panel and ingenic-drm | expand

Message

Paul Cercueil Jan. 24, 2021, 8:55 a.m. UTC
Hi,

Here are three independent fixes. The first one addresses a
use-after-free in bridge/panel.c; the second one addresses a
use-after-free in the ingenic-drm driver; finally, the third one makes
the ingenic-drm driver work again on older Ingenic SoCs.

Changes from v2:
- patch [1/4] added a FIXME.
- patch [2/4] is new. It introduces a drmm_plain_simple_encoder_alloc()
  macro that will be used in patch [3/4].
- patch [3/4] uses the macro introduced in patch [2/4].
- patch [4/4] is unmodified.

Note to linux-stable guys: patch [v2 2/3] will only apply on the current
drm-misc-next branch, to fix it for v5.11 and older kernels, use the V1
of that patch.

Cheers,
-Paul

Paul Cercueil (4):
  drm: bridge/panel: Cleanup connector on bridge detach
  drm/simple_kms_helper: Add macro drmm_plain_simple_encoder_alloc()
  drm/ingenic: Register devm action to cleanup encoders
  drm/ingenic: Fix non-OSD mode

 drivers/gpu/drm/bridge/panel.c            | 12 +++++++++++
 drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 26 +++++++++++------------
 include/drm/drm_simple_kms_helper.h       | 17 +++++++++++++++
 3 files changed, 42 insertions(+), 13 deletions(-)

Comments

Paul Cercueil Feb. 24, 2021, 1:44 p.m. UTC | #1
Hi,

Some feedback for patches 1-3? Laurent?

Cheers,
-Paul


Le dim. 24 janv. 2021 à 8:55, Paul Cercueil <paul@crapouillou.net> a 
écrit :
> Hi,
> 
> Here are three independent fixes. The first one addresses a
> use-after-free in bridge/panel.c; the second one addresses a
> use-after-free in the ingenic-drm driver; finally, the third one makes
> the ingenic-drm driver work again on older Ingenic SoCs.
> 
> Changes from v2:
> - patch [1/4] added a FIXME.
> - patch [2/4] is new. It introduces a 
> drmm_plain_simple_encoder_alloc()
>   macro that will be used in patch [3/4].
> - patch [3/4] uses the macro introduced in patch [2/4].
> - patch [4/4] is unmodified.
> 
> Note to linux-stable guys: patch [v2 2/3] will only apply on the 
> current
> drm-misc-next branch, to fix it for v5.11 and older kernels, use the 
> V1
> of that patch.
> 
> Cheers,
> -Paul
> 
> Paul Cercueil (4):
>   drm: bridge/panel: Cleanup connector on bridge detach
>   drm/simple_kms_helper: Add macro drmm_plain_simple_encoder_alloc()
>   drm/ingenic: Register devm action to cleanup encoders
>   drm/ingenic: Fix non-OSD mode
> 
>  drivers/gpu/drm/bridge/panel.c            | 12 +++++++++++
>  drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 26 
> +++++++++++------------
>  include/drm/drm_simple_kms_helper.h       | 17 +++++++++++++++
>  3 files changed, 42 insertions(+), 13 deletions(-)
> 
> --
> 2.29.2
>
Paul Cercueil March 23, 2021, 4:03 p.m. UTC | #2
Le mer. 24 févr. 2021 à 13:44, Paul Cercueil <paul@crapouillou.net> a 
écrit :
> Hi,
> 
> Some feedback for patches 1-3? Laurent?

1-month anniversary ping :)

Cheers,
-Paul

> Cheers,
> -Paul
> 
> 
> Le dim. 24 janv. 2021 à 8:55, Paul Cercueil <paul@crapouillou.net> a 
> écrit :
>> Hi,
>> 
>> Here are three independent fixes. The first one addresses a
>> use-after-free in bridge/panel.c; the second one addresses a
>> use-after-free in the ingenic-drm driver; finally, the third one 
>> makes
>> the ingenic-drm driver work again on older Ingenic SoCs.
>> 
>> Changes from v2:
>> - patch [1/4] added a FIXME.
>> - patch [2/4] is new. It introduces a 
>> drmm_plain_simple_encoder_alloc()
>>   macro that will be used in patch [3/4].
>> - patch [3/4] uses the macro introduced in patch [2/4].
>> - patch [4/4] is unmodified.
>> 
>> Note to linux-stable guys: patch [v2 2/3] will only apply on the 
>> current
>> drm-misc-next branch, to fix it for v5.11 and older kernels, use the 
>> V1
>> of that patch.
>> 
>> Cheers,
>> -Paul
>> 
>> Paul Cercueil (4):
>>   drm: bridge/panel: Cleanup connector on bridge detach
>>   drm/simple_kms_helper: Add macro drmm_plain_simple_encoder_alloc()
>>   drm/ingenic: Register devm action to cleanup encoders
>>   drm/ingenic: Fix non-OSD mode
>> 
>>  drivers/gpu/drm/bridge/panel.c            | 12 +++++++++++
>>  drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 26 
>> +++++++++++------------
>>  include/drm/drm_simple_kms_helper.h       | 17 +++++++++++++++
>>  3 files changed, 42 insertions(+), 13 deletions(-)
>> 
>> --
>> 2.29.2
>> 
>
Laurent Pinchart March 24, 2021, 2:32 a.m. UTC | #3
On Tue, Mar 23, 2021 at 04:03:00PM +0000, Paul Cercueil wrote:
> Le mer. 24 févr. 2021 à 13:44, Paul Cercueil a écrit :
> > Hi,
> > 
> > Some feedback for patches 1-3? Laurent?
> 
> 1-month anniversary ping :)

Haaappy birth-day toooo youuuuuuu :-)

Patches reviewed.

> > Le dim. 24 janv. 2021 à 8:55, Paul Cercueil a  écrit :
> >> Hi,
> >> 
> >> Here are three independent fixes. The first one addresses a
> >> use-after-free in bridge/panel.c; the second one addresses a
> >> use-after-free in the ingenic-drm driver; finally, the third one makes
> >> the ingenic-drm driver work again on older Ingenic SoCs.
> >> 
> >> Changes from v2:
> >> - patch [1/4] added a FIXME.
> >> - patch [2/4] is new. It introduces a drmm_plain_simple_encoder_alloc()
> >>   macro that will be used in patch [3/4].
> >> - patch [3/4] uses the macro introduced in patch [2/4].
> >> - patch [4/4] is unmodified.
> >> 
> >> Note to linux-stable guys: patch [v2 2/3] will only apply on the current
> >> drm-misc-next branch, to fix it for v5.11 and older kernels, use the V1
> >> of that patch.
> >> 
> >> Cheers,
> >> -Paul
> >> 
> >> Paul Cercueil (4):
> >>   drm: bridge/panel: Cleanup connector on bridge detach
> >>   drm/simple_kms_helper: Add macro drmm_plain_simple_encoder_alloc()
> >>   drm/ingenic: Register devm action to cleanup encoders
> >>   drm/ingenic: Fix non-OSD mode
> >> 
> >>  drivers/gpu/drm/bridge/panel.c            | 12 +++++++++++
> >>  drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 26 +++++++++++------------
> >>  include/drm/drm_simple_kms_helper.h       | 17 +++++++++++++++
> >>  3 files changed, 42 insertions(+), 13 deletions(-)
> >>