mbox series

[0/4] drm: Replace in_interrupt() usage.

Message ID 20210208233119.391103-1-bigeasy@linutronix.de (mailing list archive)
Headers show
Series drm: Replace in_interrupt() usage. | expand

Message

Sebastian Andrzej Siewior Feb. 8, 2021, 11:31 p.m. UTC 
Folks,

in the discussion about preempt count consistency across kernel
configurations:

 https://lore.kernel.org/r/20200914204209.256266093@linutronix.de/

it was concluded that the usage of in_interrupt() and related context
checks should be removed from non-core code.

In the long run, usage of 'preemptible, in_*irq etc.' should be banned from
driver code completely.

This series addresses the gma500 driver and parts of the amdgpu driver.
There are still call sites left in in the amdgpu driver.

Sebastian

Comments

Christian König Feb. 9, 2021, 8:05 a.m. UTC | #1 
The amdgou changes look mostly good to me.

But please send them out as separate patch set than the gma500 changes 
and please simplify boolean checks and don't use "x == true" or "x == 
false".

Regards,
Christian.

Am 09.02.21 um 00:31 schrieb Sebastian Andrzej Siewior:
> Folks,
>
> in the discussion about preempt count consistency across kernel
> configurations:
>
>   https://lore.kernel.org/r/20200914204209.256266093@linutronix.de/
>
> it was concluded that the usage of in_interrupt() and related context
> checks should be removed from non-core code.
>
> In the long run, usage of 'preemptible, in_*irq etc.' should be banned from
> driver code completely.
>
> This series addresses the gma500 driver and parts of the amdgpu driver.
> There are still call sites left in in the amdgpu driver.
>
> Sebastian
>
>