mbox series

[0/4] delete useless function return values & remove meaningless if(r) check code

Message ID 20210619064349.26676-1-bernard@vivo.com (mailing list archive)
Headers show
Series delete useless function return values & remove meaningless if(r) check code | expand

Message

Bernard Zhao June 19, 2021, 6:43 a.m. UTC 
Function radeon_fence_driver_init always returns success,
the function type maybe coule be changed to void.
This patch series will first delete the check of the return
value of the function call radeon_fence_driver_init, then,
optimise the function declaration and function to void type.

Signed-off-by: Bernard Zhao <bernard@vivo.com>

Bernard Zhao (4):
  drm/radeon: remove meaningless if(r) check code
  drm/radeon: remove meaningless if(r) check code
  drm/radeon: remove meaningless if(r) check code
  drm/radeon: delete useless return values

 drivers/gpu/drm/radeon/cik.c          | 4 +---
 drivers/gpu/drm/radeon/evergreen.c    | 4 +---
 drivers/gpu/drm/radeon/ni.c           | 4 +---
 drivers/gpu/drm/radeon/r100.c         | 4 +---
 drivers/gpu/drm/radeon/r300.c         | 4 +---
 drivers/gpu/drm/radeon/r420.c         | 5 +----
 drivers/gpu/drm/radeon/r520.c         | 4 +---
 drivers/gpu/drm/radeon/r600.c         | 4 +---
 drivers/gpu/drm/radeon/radeon.h       | 2 +-
 drivers/gpu/drm/radeon/radeon_fence.c | 5 +----
 drivers/gpu/drm/radeon/rs400.c        | 4 +---
 drivers/gpu/drm/radeon/rs600.c        | 4 +---
 drivers/gpu/drm/radeon/rs690.c        | 4 +---
 drivers/gpu/drm/radeon/rv515.c        | 4 +---
 drivers/gpu/drm/radeon/rv770.c        | 4 +---
 drivers/gpu/drm/radeon/si.c           | 4 +---
 16 files changed, 16 insertions(+), 48 deletions(-)

Comments

Christian König June 20, 2021, 4:59 p.m. UTC | #1 
Am 19.06.21 um 08:43 schrieb Bernard Zhao:
> Function radeon_fence_driver_init always returns success,
> the function type maybe coule be changed to void.
> This patch series will first delete the check of the return
> value of the function call radeon_fence_driver_init, then,
> optimise the function declaration and function to void type.

Please merge all of this into a single patch, I don't see any point 
separating this.

Christian.

>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
>
> Bernard Zhao (4):
>    drm/radeon: remove meaningless if(r) check code
>    drm/radeon: remove meaningless if(r) check code
>    drm/radeon: remove meaningless if(r) check code
>    drm/radeon: delete useless return values
>
>   drivers/gpu/drm/radeon/cik.c          | 4 +---
>   drivers/gpu/drm/radeon/evergreen.c    | 4 +---
>   drivers/gpu/drm/radeon/ni.c           | 4 +---
>   drivers/gpu/drm/radeon/r100.c         | 4 +---
>   drivers/gpu/drm/radeon/r300.c         | 4 +---
>   drivers/gpu/drm/radeon/r420.c         | 5 +----
>   drivers/gpu/drm/radeon/r520.c         | 4 +---
>   drivers/gpu/drm/radeon/r600.c         | 4 +---
>   drivers/gpu/drm/radeon/radeon.h       | 2 +-
>   drivers/gpu/drm/radeon/radeon_fence.c | 5 +----
>   drivers/gpu/drm/radeon/rs400.c        | 4 +---
>   drivers/gpu/drm/radeon/rs600.c        | 4 +---
>   drivers/gpu/drm/radeon/rs690.c        | 4 +---
>   drivers/gpu/drm/radeon/rv515.c        | 4 +---
>   drivers/gpu/drm/radeon/rv770.c        | 4 +---
>   drivers/gpu/drm/radeon/si.c           | 4 +---
>   16 files changed, 16 insertions(+), 48 deletions(-)
>
Bernard Zhao June 21, 2021, 1:33 a.m. UTC | #2 
From: "Christian König" <christian.koenig@amd.com>
Date: 2021-06-21 00:59:27
To:  Bernard Zhao <bernard@vivo.com>,Alex Deucher <alexander.deucher@amd.com>,David Airlie <airlied@linux.ie>,Daniel Vetter <daniel@ffwll.ch>,amd-gfx@lists.freedesktop.org,dri-devel@lists.freedesktop.org,linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] delete useless function return values & remove meaningless if(r) check code>Am 19.06.21 um 08:43 schrieb Bernard Zhao:
>> Function radeon_fence_driver_init always returns success,
>> the function type maybe coule be changed to void.
>> This patch series will first delete the check of the return
>> value of the function call radeon_fence_driver_init, then,
>> optimise the function declaration and function to void type.
>
>Please merge all of this into a single patch, I don't see any point 
>separating this.
>
>Christian.

Hi
Sure, i will resubmit one new ptach, thanks!
BR//Bernard

>>
>> Signed-off-by: Bernard Zhao <bernard@vivo.com>
>>
>> Bernard Zhao (4):
>>    drm/radeon: remove meaningless if(r) check code
>>    drm/radeon: remove meaningless if(r) check code
>>    drm/radeon: remove meaningless if(r) check code
>>    drm/radeon: delete useless return values
>>
>>   drivers/gpu/drm/radeon/cik.c          | 4 +---
>>   drivers/gpu/drm/radeon/evergreen.c    | 4 +---
>>   drivers/gpu/drm/radeon/ni.c           | 4 +---
>>   drivers/gpu/drm/radeon/r100.c         | 4 +---
>>   drivers/gpu/drm/radeon/r300.c         | 4 +---
>>   drivers/gpu/drm/radeon/r420.c         | 5 +----
>>   drivers/gpu/drm/radeon/r520.c         | 4 +---
>>   drivers/gpu/drm/radeon/r600.c         | 4 +---
>>   drivers/gpu/drm/radeon/radeon.h       | 2 +-
>>   drivers/gpu/drm/radeon/radeon_fence.c | 5 +----
>>   drivers/gpu/drm/radeon/rs400.c        | 4 +---
>>   drivers/gpu/drm/radeon/rs600.c        | 4 +---
>>   drivers/gpu/drm/radeon/rs690.c        | 4 +---
>>   drivers/gpu/drm/radeon/rv515.c        | 4 +---
>>   drivers/gpu/drm/radeon/rv770.c        | 4 +---
>>   drivers/gpu/drm/radeon/si.c           | 4 +---
>>   16 files changed, 16 insertions(+), 48 deletions(-)
>>
>