| Message ID | 20210728153736.15240-1-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm: Extend COMPILE_TEST support to some ARM drivers | expand |
On 28/07/2021 18:37, Laurent Pinchart wrote: > Hello, > > This patch series stems from subsystem-wide changes I wanted to > compile-test with an ARM64 cross-compiler. My laziness to fire a 32-bit > ARM build probably resulted in more time being spent writing these > patches, but hopefully they'll turn out to be useful for more people :-) > > Patches 1/7 and 2/7 are fixes for compilation warnings on 64-bit > platforms in the omapdrm and sti-drm drivers. They are a dependency for > the Kconfig changes that follow to avoid introducing build warnings, but > could also be merged before. > > Patches 3/7 to 7/7 enable compilation of the imx-dcss, omapdrm, sti-drm, > tegra-drm and tilcdc drivers on ARM64 with COMPILE_TEST. The patches are > independent from each other, so they can be picked by their respective > maintainers. > > We could also extend test compilation to more architecture, but I didn't > want to remove all dependencies on ARM or ARM64 at this point for fear > or triggering build warnings that I wouldn't be able to catch locally. > If there's a consensus that fully relaxing the platform requirement is > better, I can submit a new version that does so and rely on the 0day bot > to catch issues. I would allow compilation for any architecture if COMPILE_TEST is enabled. I think git grep shows that is how COMPILE_TEST is usually used. Tomi
Hi Laurent, On Wed, Jul 28, 2021 at 06:37:29PM +0300, Laurent Pinchart wrote: > Hello, > > This patch series stems from subsystem-wide changes I wanted to > compile-test with an ARM64 cross-compiler. My laziness to fire a 32-bit > ARM build probably resulted in more time being spent writing these > patches, but hopefully they'll turn out to be useful for more people :-) > > Patches 1/7 and 2/7 are fixes for compilation warnings on 64-bit > platforms in the omapdrm and sti-drm drivers. They are a dependency for > the Kconfig changes that follow to avoid introducing build warnings, but > could also be merged before. > > Patches 3/7 to 7/7 enable compilation of the imx-dcss, omapdrm, sti-drm, > tegra-drm and tilcdc drivers on ARM64 with COMPILE_TEST. The patches are > independent from each other, so they can be picked by their respective > maintainers. > > We could also extend test compilation to more architecture, but I didn't > want to remove all dependencies on ARM or ARM64 at this point for fear > or triggering build warnings that I wouldn't be able to catch locally. > If there's a consensus that fully relaxing the platform requirement is > better, I can submit a new version that does so and rely on the 0day bot > to catch issues. I have alpha, sparc64, and a few more so we can get pretty good coverage before it hits -next. If we enable more build coverage then please address all W=1 warnings first. I for once always builds with W=1 these days, and I see more and more warnings sneaking in again. So lets try to keep the noise level down. Sam
Hi Sam, On Thu, Jul 29, 2021 at 06:53:33PM +0200, Sam Ravnborg wrote: > On Wed, Jul 28, 2021 at 06:37:29PM +0300, Laurent Pinchart wrote: > > Hello, > > > > This patch series stems from subsystem-wide changes I wanted to > > compile-test with an ARM64 cross-compiler. My laziness to fire a 32-bit > > ARM build probably resulted in more time being spent writing these > > patches, but hopefully they'll turn out to be useful for more people :-) > > > > Patches 1/7 and 2/7 are fixes for compilation warnings on 64-bit > > platforms in the omapdrm and sti-drm drivers. They are a dependency for > > the Kconfig changes that follow to avoid introducing build warnings, but > > could also be merged before. > > > > Patches 3/7 to 7/7 enable compilation of the imx-dcss, omapdrm, sti-drm, > > tegra-drm and tilcdc drivers on ARM64 with COMPILE_TEST. The patches are > > independent from each other, so they can be picked by their respective > > maintainers. > > > > We could also extend test compilation to more architecture, but I didn't > > want to remove all dependencies on ARM or ARM64 at this point for fear > > or triggering build warnings that I wouldn't be able to catch locally. > > If there's a consensus that fully relaxing the platform requirement is > > better, I can submit a new version that does so and rely on the 0day bot > > to catch issues. > > I have alpha, sparc64, and a few more so we can get pretty good coverage > before it hits -next. It seems that the consensus is to enable COMPILE_TEST on all platforms, so I'll do that. > If we enable more build coverage then please address all W=1 warnings > first. > > I for once always builds with W=1 these days, and I see more and more > warnings sneaking in again. > So lets try to keep the noise level down. Hmmmm... I build my kernel with -Werror to make sure I catch all warnings. W=1 doesn't play well with that :-S I'll see if I can turn the additional warnings into non-errors, but that may become a game of whack-a-mole.