From patchwork Wed Nov 17 09:45:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 12624235 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C36EC433EF for ; Wed, 17 Nov 2021 09:45:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 464D861A07 for ; Wed, 17 Nov 2021 09:45:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 464D861A07 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 78BDC6EA16; Wed, 17 Nov 2021 09:45:37 +0000 (UTC) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A0D96E92D for ; Wed, 17 Nov 2021 09:45:35 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id CDDA258082C; Wed, 17 Nov 2021 04:45:31 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 17 Nov 2021 04:45:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= from:to:cc:subject:date:message-id:content-type:mime-version :content-transfer-encoding; s=fm1; bh=ekf9vvCWfLNoSjVEXV4DBI29ZU qfpHxwPzoBJFFnGlc=; b=P4evg08MecqlLumYRn8QndAEXrs+/iJm6R0Ty+x7UM 62Q59fp0ynTFDMk5aFR04apSz1VADfOO5ZSop0rYeIvd/EwmOHsA/Fysuo4YMjH2 0iN/o+ypkq8v6fRBygaM1haaDv5eNkP+4ZO1xYvmyXKDBCSQUsUkKfgzHaX80+8m vd8uMcuZZyf0t69m5+EXEGgNZ1p+5E6yklmaZhbxM3pp+RGjRpvs2SOBp5hOjj9D TRLwh9RI9pA8FSk85XcBrIdSSZJr5t3gYNhMM0wxXIaELRQp6yElnFtYejkeikGM XxuYd8H100UE66mIY2cFkfii5vWrDlhrwJFv27NUw8gg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ekf9vv CWfLNoSjVEXV4DBI29ZUqfpHxwPzoBJFFnGlc=; b=HpHRdddOKEdflxjZDdIf9N HvgdZdbjhRv+6H0Istn4yNtuLqBsb2m2y5PpGYK0kV1QiC+NedcQ0XSYWEiAKisW t5HnF+WLfZ9tHkFncsQ5QGeu/2KP2FrU3T422Ym827Qg9RjqafaHVXk//eiINLH3 /kzJxGJw1Q338yi6PRjv8+1cjIu1F+uFZU5IubtubhShL4a7+M4e8H9PV1Qew4sk MYU3JYIoq+nSy5OSiUw+rkwzvW7Wg+0l4vI5oaTHUc7qO67h9diz3Ywp3Gm/Gr1w JNfuGu1+5l01rewxxuJ/byq+2g9ixiXodW9kmaeaNYIIReE8NrVt1fgYdLSNgDUQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrfeeggddtfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgtggfgsehtqhertdertdejnecuhfhrohhmpeforgigihhmvgcu tfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrthhtvg hrnhepteeikefgffekgeekledtheduteetjefgkeeuvefhhfetgedugfektdeugeffgfef necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrgi himhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 17 Nov 2021 04:45:30 -0500 (EST) From: Maxime Ripard To: Maarten Lankhorst , Thomas Zimmermann , Maxime Ripard , Daniel Vetter , David Airlie Subject: [PATCH v2 0/6] drm/vc4: kms: Misc fixes for HVS commits Date: Wed, 17 Nov 2021 10:45:21 +0100 Message-Id: <20211117094527.146275-1-maxime@cerno.tech> X-Mailer: git-send-email 2.33.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dom Cobley , Tim Gover , Dave Stevenson , Jian-Hong Pan , dri-devel@lists.freedesktop.org, Phil Elwell Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, The conversion to DRM commit helpers (f3c420fe19f8, "drm/vc4: kms: Convert to atomic helpers") introduced a number of issues in corner cases, most of them showing themselves in the form of either a vblank timeout or use-after-free error. These patches should fix most of them, some of them still being debugged. Maxime Changes from v1: - Prevent a null pointer dereference Maxime Ripard (6): drm/vc4: kms: Wait for the commit before increasing our clock rate drm/vc4: kms: Fix return code check drm/vc4: kms: Add missing drm_crtc_commit_put drm/vc4: kms: Clear the HVS FIFO commit pointer once done drm/vc4: kms: Don't duplicate pending commit drm/vc4: kms: Fix previous HVS commit wait drivers/gpu/drm/vc4/vc4_kms.c | 42 ++++++++++++++++------------------- 1 file changed, 19 insertions(+), 23 deletions(-) Tested-by: Jian-Hong Pan