[v3,00/16] drm/vc4: hdmi: Yet Another Approach to HDMI YUV output

Message

Maxime Ripard Jan. 13, 2022, 2:07 p.m. UTC

Hi,

This is another attempt at supporting the HDMI YUV output in the vc4 HDMI
driver.

This is a follow-up of
https://lore.kernel.org/dri-devel/[e-mail]/

And the discussions that occured recently on the mailing lists and IRC about
this.

The series mentioned above had multiple issues, the main one being that it was
a bit too much complicated for what we wanted to achieve. This series is taking
a much simpler approach with an ad-hoc solution.

I think some parts of it could still be moved to KMS helpers (notably, the
output format enum, and the helper to set the infoframe for it) and structures
(the output format stored in drm_connector_state). This would also interact
nicely with the work done here:

https://lore.kernel.org/dri-devel/[e-mail]/

This can come as a second step though.

The other issues with the first attempt was that nothing was reported to
userspace about the decision we made about the format, and that this decision
was essentially policy, without any way for the userspace to influence it.

Those two points however are being worked on by Werner in a cross-driver
effort:

https://lore.kernel.org/dri-devel/[e-mail]/

Since it's a KMS decision, I don't think we should hold off any driver as long
as it's consistent with what the other drivers are doing.

Let me know what you think,
Maxime

---

Changes from v2:
  - Rename the output format enum
  - Split the edid_hdmi_dc_modes in two for RGB444 and YUV444
  - Remove color_formats modifications from _parse_deep_color entirely
  - Fixed comment formatting
  - Fixed mode_valid that would always return true
  - Fixed max_tmds_clock handling

Changes from v1:
  - Fixed an EDID parsing error for YUV422
  - Fixed the scrambling setup when using a bpc > 8
  - Added some logging
  - Fixed some build-bot warnings
  - Fixed a number of HDMI specifications and EDID issues
  - Try to max out the bpc every time

Maxime Ripard (16):
  drm/edid: Rename drm_hdmi_avi_infoframe_colorspace to _colorimetry
  drm/edid: Don't clear formats if using deep color
  drm/edid: Split deep color modes between RGB and YUV444
  drm/connector: Fix typo in output format
  drm/vc4: hdmi: Add full range RGB helper
  drm/vc4: hdmi: Use full range helper in csc functions
  drm/vc4: hdmi: Move XBAR setup to csc_setup
  drm/vc4: hdmi: Replace CSC_CTL hardcoded value by defines
  drm/vc4: hdmi: Define colorspace matrices
  drm/vc4: hdmi: Change CSC callback prototype
  drm/vc4: hdmi: Move clock validation to its own function
  drm/vc4: hdmi: Move clock calculation into its own function
  drm/vc4: hdmi: Take the sink maximum TMDS clock into account
  drm/vc4: hdmi: Take bpp into account for the scrambler
  drm/vc4: hdmi: Always try to have the highest bpc
  drm/vc4: hdmi: Support HDMI YUV output

 .../gpu/drm/amd/amdgpu/amdgpu_connectors.c    |   2 +-
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |   2 +-
 .../arm/display/komeda/d71/d71_component.c    |  12 +-
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c  |   2 +-
 .../drm/bridge/analogix/analogix_dp_core.c    |   4 +-
 .../drm/bridge/cadence/cdns-mhdp8546-core.c   |  18 +-
 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c     |  16 +-
 drivers/gpu/drm/drm_edid.c                    |  39 +-
 drivers/gpu/drm/i915/display/intel_hdmi.c     |   6 +-
 drivers/gpu/drm/i915/display/intel_lspcon.c   |   2 +-
 drivers/gpu/drm/radeon/radeon_connectors.c    |   2 +-
 .../gpu/drm/rockchip/analogix_dp-rockchip.c   |   2 +-
 drivers/gpu/drm/vc4/vc4_hdmi.c                | 522 +++++++++++++++---
 drivers/gpu/drm/vc4/vc4_hdmi.h                |  26 +-
 drivers/gpu/drm/vc4/vc4_hdmi_regs.h           |   6 +
 drivers/gpu/drm/vc4/vc4_regs.h                |  19 +
 include/drm/drm_connector.h                   |  18 +-
 include/drm/drm_edid.h                        |   4 +-
 18 files changed, 552 insertions(+), 150 deletions(-)