| Message ID | 20220225035610.2552144-1-keescook@chromium.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/dp: Fix out-of-bounds reads | expand |
On Thu, Feb 24, 2022 at 07:56:08PM -0800, Kees Cook wrote: > Hi, > > I'm sending these again, as they still need fixing. They have been > rebased due to the drm_dp_helper code being moved into a subdirectory. Yeah, I noticed the other day that this had been partially reverted by the DP code move. I've applied this now, though it didn't apply cleanly, so I'll do a couple of test builds to make sure my resolution is correct and will push this out later on. Thanks, Thierry
On Fri, Feb 25, 2022 at 10:30:19AM +0100, Thierry Reding wrote: > On Thu, Feb 24, 2022 at 07:56:08PM -0800, Kees Cook wrote: > > Hi, > > > > I'm sending these again, as they still need fixing. They have been > > rebased due to the drm_dp_helper code being moved into a subdirectory. > > Yeah, I noticed the other day that this had been partially reverted by > the DP code move. I've applied this now, though it didn't apply cleanly, > so I'll do a couple of test builds to make sure my resolution is correct > and will push this out later on. Awesome; thank you! Yeah, I had based on drm/drm-next rather than drm-misc/drm-misc-next. I wasn't sure which tree I needed to base on after the files moved. FWIW, the resulting patches look good to me. Thanks for fixing them up! -Kees
Hi, I'm sending these again, as they still need fixing. They have been rebased due to the drm_dp_helper code being moved into a subdirectory. Can someone please apply these? :) Thanks! -Kees v1: https://patchwork.freedesktop.org/patch/465200/ https://patchwork.freedesktop.org/patch/465201/ v2: https://patchwork.freedesktop.org/patch/468350/ https://patchwork.freedesktop.org/patch/468351/ v3: - add review tags - rebase to drm/drm-next Kees Cook (2): drm/dp: Fix off-by-one in register cache size drm/dp: Fix OOB read when handling Post Cursor2 register drivers/gpu/drm/dp/drm_dp.c | 10 ---------- drivers/gpu/drm/tegra/dp.c | 11 ++++++++++- include/drm/dp/drm_dp_helper.h | 4 +--- 3 files changed, 11 insertions(+), 14 deletions(-)