mbox series

[0/2] drm: bridge: adv7511: CEC support for ADV7535

Message ID 20220319151016.983348-1-alvin@pqrs.dk (mailing list archive)
Headers show
Series drm: bridge: adv7511: CEC support for ADV7535 | expand

Message

Alvin Šipraga March 19, 2022, 3:10 p.m. UTC
From: Alvin Šipraga <alsi@bang-olufsen.dk>

We have an ADV7535 which is nominally supported by this driver. These
two patches fix up the driver to get CEC working too.

The first adds the basic support by correcting some register offsets.

The second addresses an issue we saw with CEC RX on the ADV7535. It
hasn't been tested with the other chips (e.g. ADV7533), although it
should be compatible. I'm sending it against drm-misc-next because the
issue wasn't reported for other chips, and ADV7535 didn't have CEC
support before. But feel free to take it into -fixes instead.

Alvin Šipraga (2):
  drm: bridge: adv7511: enable CEC support for ADV7535
  drm: bridge: adv7511: use non-legacy mode for CEC RX

 drivers/gpu/drm/bridge/adv7511/adv7511.h     |  27 ++++-
 drivers/gpu/drm/bridge/adv7511/adv7511_cec.c | 116 +++++++++++++------
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c |  22 +++-
 3 files changed, 119 insertions(+), 46 deletions(-)

Comments

Robert Foss Aug. 29, 2022, 4:02 p.m. UTC | #1
Hi Alvin,

Sorry about being slow to get to this series.

Can you rebase it on drm-misc-next and send out the next version?

On Sat, 19 Mar 2022 at 16:10, Alvin Šipraga <alvin@pqrs.dk> wrote:
>
> From: Alvin Šipraga <alsi@bang-olufsen.dk>
>
> We have an ADV7535 which is nominally supported by this driver. These
> two patches fix up the driver to get CEC working too.
>
> The first adds the basic support by correcting some register offsets.
>
> The second addresses an issue we saw with CEC RX on the ADV7535. It
> hasn't been tested with the other chips (e.g. ADV7533), although it
> should be compatible. I'm sending it against drm-misc-next because the
> issue wasn't reported for other chips, and ADV7535 didn't have CEC
> support before. But feel free to take it into -fixes instead.
>
> Alvin Šipraga (2):
>   drm: bridge: adv7511: enable CEC support for ADV7535
>   drm: bridge: adv7511: use non-legacy mode for CEC RX
>
>  drivers/gpu/drm/bridge/adv7511/adv7511.h     |  27 ++++-
>  drivers/gpu/drm/bridge/adv7511/adv7511_cec.c | 116 +++++++++++++------
>  drivers/gpu/drm/bridge/adv7511/adv7511_drv.c |  22 +++-
>  3 files changed, 119 insertions(+), 46 deletions(-)
>
> --
> 2.35.1
>
Alvin Šipraga Aug. 30, 2022, 7:54 a.m. UTC | #2
Hi Robert,

On Mon, Aug 29, 2022 at 06:02:17PM +0200, Robert Foss wrote:
> Hi Alvin,
> 
> Sorry about being slow to get to this series.

Nothing to be sorry about - in fact it was already applied! ;-)

ab0af093bf90 drm: bridge: adv7511: use non-legacy mode for CEC RX
0aae7623b495 drm: bridge: adv7511: enable CEC support for ADV7535

The one patch I am still waiting for feedback on is here:

https://lore.kernel.org/all/20220319152932.995904-1-alvin@pqrs.dk/

But it is an RFC patch and not of an urgent nature.

Thanks!

Kind regards,
Alvin

> 
> Can you rebase it on drm-misc-next and send out the next version?
> 
> On Sat, 19 Mar 2022 at 16:10, Alvin Šipraga <alvin@pqrs.dk> wrote:
> >
> > From: Alvin Šipraga <alsi@bang-olufsen.dk>
> >
> > We have an ADV7535 which is nominally supported by this driver. These
> > two patches fix up the driver to get CEC working too.
> >
> > The first adds the basic support by correcting some register offsets.
> >
> > The second addresses an issue we saw with CEC RX on the ADV7535. It
> > hasn't been tested with the other chips (e.g. ADV7533), although it
> > should be compatible. I'm sending it against drm-misc-next because the
> > issue wasn't reported for other chips, and ADV7535 didn't have CEC
> > support before. But feel free to take it into -fixes instead.
> >
> > Alvin Šipraga (2):
> >   drm: bridge: adv7511: enable CEC support for ADV7535
> >   drm: bridge: adv7511: use non-legacy mode for CEC RX
> >
> >  drivers/gpu/drm/bridge/adv7511/adv7511.h     |  27 ++++-
> >  drivers/gpu/drm/bridge/adv7511/adv7511_cec.c | 116 +++++++++++++------
> >  drivers/gpu/drm/bridge/adv7511/adv7511_drv.c |  22 +++-
> >  3 files changed, 119 insertions(+), 46 deletions(-)
> >
> > --
> > 2.35.1
> >