mbox series

[0/3] drm/msm/dp: simplify dp_connector_get_modes()

Message ID 20220323103546.1772673-1-dmitry.baryshkov@linaro.org (mailing list archive)
Headers show
Series drm/msm/dp: simplify dp_connector_get_modes() | expand

Message

Dmitry Baryshkov March 23, 2022, 10:35 a.m. UTC 
As noted by Ville Syrjälä [1] the dp_connector_get_modes() has weird
on-stack interim copy of the mode. When reviewing the mentioned patch I
noticed that the rest of the code in dp_connector_get_modes() is weird,
unused since September of 2020 and can be removed. This series removes
dead weird code leaving dp_connector_get_modes() simple enough.

[1] https://lore.kernel.org/linux-arm-msm/20220218100403.7028-11-ville.syrjala@linux.intel.com/

*** BLURB HERE ***

Dmitry Baryshkov (3):
  drm/msm/dp: drop dp_mode argument from dp_panel_get_modes()
  drm/msm/dp: simplify dp_connector_get_modes()
  drm/msm/dp: remove max_pclk_khz field from dp_panel/dp_display

 drivers/gpu/drm/msm/dp/dp_debug.c   |  2 --
 drivers/gpu/drm/msm/dp/dp_display.c | 11 +++-------
 drivers/gpu/drm/msm/dp/dp_display.h |  5 +----
 drivers/gpu/drm/msm/dp/dp_drm.c     | 33 ++---------------------------
 drivers/gpu/drm/msm/dp/dp_panel.c   |  2 +-
 drivers/gpu/drm/msm/dp/dp_panel.h   |  3 +--
 6 files changed, 8 insertions(+), 48 deletions(-)

Comments

Abhinav Kumar March 23, 2022, 8:48 p.m. UTC | #1 
On 3/23/2022 3:35 AM, Dmitry Baryshkov wrote:
> As noted by Ville Syrjälä [1] the dp_connector_get_modes() has weird
> on-stack interim copy of the mode. When reviewing the mentioned patch I
> noticed that the rest of the code in dp_connector_get_modes() is weird,
> unused since September of 2020 and can be removed. This series removes
> dead weird code leaving dp_connector_get_modes() simple enough.
> 
> [1] https://lore.kernel.org/linux-arm-msm/20220218100403.7028-11-ville.syrjala@linux.intel.com/
For the series,
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> 
> *** BLURB HERE ***
> 
> Dmitry Baryshkov (3):
>    drm/msm/dp: drop dp_mode argument from dp_panel_get_modes()
>    drm/msm/dp: simplify dp_connector_get_modes()
>    drm/msm/dp: remove max_pclk_khz field from dp_panel/dp_display
> 
>   drivers/gpu/drm/msm/dp/dp_debug.c   |  2 --
>   drivers/gpu/drm/msm/dp/dp_display.c | 11 +++-------
>   drivers/gpu/drm/msm/dp/dp_display.h |  5 +----
>   drivers/gpu/drm/msm/dp/dp_drm.c     | 33 ++---------------------------
>   drivers/gpu/drm/msm/dp/dp_panel.c   |  2 +-
>   drivers/gpu/drm/msm/dp/dp_panel.h   |  3 +--
>   6 files changed, 8 insertions(+), 48 deletions(-)
>