mbox series

[v2,0/3] add Pine64 touch panel support to rockpro64

Message ID 20220511113517.4172962-1-pgwipeout@gmail.com (mailing list archive)
Headers show
Series add Pine64 touch panel support to rockpro64 | expand

Message

Peter Geis May 11, 2022, 11:35 a.m. UTC
Good Morning,

Apologies Heiko on taking so long for this v2.

This patch series adds support for the Pine64 touch panel to the
rockpro64 single board computer.
This panel attaches to the dsi port and includes an i2c touch screen.

The first two patches involve making the reset pin to the Feiyang
fy07024di26a30d panel optional. On the rockpro64 and quartz64-a this pin
is tied to dvdd and automatically comes high when power is applied.
The third patch adds the device tree nodes to rockpro64 to permit the
panel to be used.

Changelog:
v2:
- Drop patch 4 so we don't "enable" the nodes
- Drop the unnecessary null checks
- Rebase to 5.18-rc1

Peter Geis (3):
  dt-bindings: display: panel: feiyang, fy07024di26a30d: make reset gpio
    optional
  drm/panel: feiyang-fy07024di26a30d: make reset gpio optional
  arm64: dts: rockchip: add pine64 touch panel display to rockpro64

 .../panel/feiyang,fy07024di26a30d.yaml        |  1 -
 .../boot/dts/rockchip/rk3399-rockpro64.dtsi   | 80 ++++++++++++++++++-
 .../drm/panel/panel-feiyang-fy07024di26a30d.c |  2 +-
 3 files changed, 77 insertions(+), 6 deletions(-)

Comments

Heiko Stübner May 15, 2022, 7:32 p.m. UTC | #1
On Wed, 11 May 2022 07:35:13 -0400, Peter Geis wrote:
> Good Morning,
> 
> Apologies Heiko on taking so long for this v2.
> 
> This patch series adds support for the Pine64 touch panel to the
> rockpro64 single board computer.
> This panel attaches to the dsi port and includes an i2c touch screen.
> 
> [...]

Applied, thanks!

[1/3] dt-bindings: display: panel: feiyang, fy07024di26a30d: make reset gpio optional
      commit: d0956e2c520c9d730979a9669f27a77d40acac13
[2/3] drm/panel: feiyang-fy07024di26a30d: make reset gpio optional
      commit: de5db71e4c8c35ed5e92006e3064ce9230881ece

Best regards,
Heiko Stübner May 15, 2022, 7:47 p.m. UTC | #2
On Wed, 11 May 2022 07:35:13 -0400, Peter Geis wrote:
> Good Morning,
> 
> Apologies Heiko on taking so long for this v2.
> 
> This patch series adds support for the Pine64 touch panel to the
> rockpro64 single board computer.
> This panel attaches to the dsi port and includes an i2c touch screen.
> 
> [...]

Applied, thanks!

[3/3] arm64: dts: rockchip: add pine64 touch panel display to rockpro64
 ... for 5.20 .

The binding- and driver-change most likely won't reach drm-main and thus
the next merge-window in time, so I've put the dts patch on a branch for
5.20 instead.

I've also made some ordering changes and dropped both the "force X to vopY"
parts. DT is a hardware-description and not a configuration space ;-) .
And a devicetree should definitly not try to work around implementation
deficits of the kernel driver.

Both VOPs are capable of driving both hdmi and dsi with their relevant
deficiencies being in terms of resolution or clock rates I guess, so
anything related to selecting a matching VOP should be done in code in
the kernel.


Best regards,