mbox series

[V2,0/5] I2S driver changes for Jadeite platform

Message ID 20220701114107.1105948-1-Vijendar.Mukunda@amd.com (mailing list archive)
Headers show
Series I2S driver changes for Jadeite platform | expand

Message

Vijendar Mukunda July 1, 2022, 11:41 a.m. UTC
Jadeite(JD) platform is Stoney APU varaint which uses I2S MICSP
instance and ES8336 Codec.
This patch series creates I2S platform devices for JD platform,
adds I2S MICSP instance support and Machine driver support

This patch set depends on:
        --checkpatch warnings patch
	--https://patchwork.kernel.org/project/alsa-devel/patch/20220627125834.481731-1-Vijendar.Mukunda@amd.com/

changes since v1:
      - removed hw_params() callback in machine driver and
        moved sysclk programming logic to startup() callback.
      - Modified ACPI & I2C flag depedency checks in Kconfig file

Vijendar Mukunda (5):
  drm/amdgpu: add dmi check for jadeite platform
  drm/amdgpu: create I2S platform devices for Jadeite platform
  ASoC: amd: add I2S MICSP instance support
  ASoC: amd: add Machine driver for Jadeite platform
  ASoC: amd: enable machine driver build for Jadeite platform

 drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 329 ++++++++++++++++--------
 sound/soc/amd/Kconfig                   |  13 +
 sound/soc/amd/Makefile                  |   2 +
 sound/soc/amd/acp-es8336.c              | 324 +++++++++++++++++++++++
 sound/soc/amd/acp-pcm-dma.c             |  50 +++-
 sound/soc/amd/acp.h                     |  13 +
 6 files changed, 620 insertions(+), 111 deletions(-)
 create mode 100644 sound/soc/amd/acp-es8336.c

Comments

Mark Brown July 1, 2022, 11:51 a.m. UTC | #1
On Fri, Jul 01, 2022 at 05:11:02PM +0530, Vijendar Mukunda wrote:

> This patch set depends on:
>         --checkpatch warnings patch
> 	--https://patchwork.kernel.org/project/alsa-devel/patch/20220627125834.481731-1-Vijendar.Mukunda@amd.com/

That's "drm: amd: amdgpu: fix checkpatch warnings", but it looks like
there's no build time dependencies for patch 3 so I could go ahead with
it and the DRM changes go through the DRM tree I think?

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.
Vijendar Mukunda July 1, 2022, 12:17 p.m. UTC | #2
On 7/1/22 5:21 PM, Mark Brown wrote:
> On Fri, Jul 01, 2022 at 05:11:02PM +0530, Vijendar Mukunda wrote:
> 
>> This patch set depends on:
>>         --checkpatch warnings patch
>> 	--https://patchwork.kernel.org/project/alsa-devel/patch/20220627125834.481731-1-Vijendar.Mukunda@amd.com/
> 
> That's "drm: amd: amdgpu: fix checkpatch warnings", but it looks like
> there's no build time dependencies for patch 3 so I could go ahead with
> it and the DRM changes go through the DRM tree I think?
> 
correct. First two patches including dependent patch should through DRM
tree. There is no build dependencies for AsoC tree patches. From patch 3
on wards, it can be picked for upstream review for ASoC tree.

It's my bad. Patch series should be split in to two. one should go
through ASoC tree and another one through DRM tree.

> Please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet access.
> I do frequently catch up on my mail on flights or while otherwise
> travelling so this is even more pressing for me than just being about
> making things a bit easier to read.
I agree. will take care about patch commit descriptions.
Mark Brown July 6, 2022, 11:07 a.m. UTC | #3
On Fri, 1 Jul 2022 17:11:02 +0530, Vijendar Mukunda wrote:
> Jadeite(JD) platform is Stoney APU varaint which uses I2S MICSP
> instance and ES8336 Codec.
> This patch series creates I2S platform devices for JD platform,
> adds I2S MICSP instance support and Machine driver support
> 
> This patch set depends on:
>         --checkpatch warnings patch
> 	--https://patchwork.kernel.org/project/alsa-devel/patch/20220627125834.481731-1-Vijendar.Mukunda@amd.com/
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[3/5] ASoC: amd: add I2S MICSP instance support
      commit: 3eb8440d0d268437202ccbd28a3ca3212e02e57f
[4/5] ASoC: amd: add Machine driver for Jadeite platform
      commit: 02527c3f2300100a25524c8c020d98c7957e485e
[5/5] ASoC: amd: enable machine driver build for Jadeite platform
      commit: f94fa84058014f81ad526641f1b1f583ca2cf32f

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark