| Message ID | 20220906174823.28561-1-macroalpha82@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | rockchip-dsi for rk3568 | expand |
Hello, What other patches would I need to apply to test this series on Anbernic RG503? Best Regards, Maya Matuszczyk wt., 6 wrz 2022 o 19:52 Chris Morgan <macroalpha82@gmail.com> napisał(a): > > From: Chris Morgan <macromorgan@hotmail.com> > > This series adds support for the dsi and dphy controllers on the > Rockchip RK3568. I can confirm that for the Rockchip RK3568 this > current series DOES WORK now, but it requires rolling back clk changes > made for the HDMI driver. If the clock changes are not rolled back, the > image on the screen is shifted about 100 pixels to the right. > > Clk changes in question: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/clk/rockchip/clk-rk3568.c?id=ff3187eabb5ce478d15b6ed62eb286756adefac3 > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/clk/rockchip/clk-rk3568.c?id=6e69052f01d9131388cfcfaee929120118a267f4 > > Tested on an Anbernic RG503 and RG353P with clock changes rolled back, > the hardware works correctly on both devices. > > Changes since RFCv1: > - Identified cause of image shift (clock changes). > - Noted that driver works now. > - Added devicetree nodes for rk356x.dtsi. > > Chris Morgan (5): > dt-bindings: display: rockchip-dsi: add rk3568 compatible > dt-bindings: phy-rockchip-inno-dsidphy: add compatible for rk3568 > drm/rockchip: dsi: add rk3568 support > phy/rockchip: inno-dsidphy: Add support for rk3568 > arm64: dts: rockchip: Add DSI and DSI-DPHY nodes to rk356x > > .../display/rockchip/dw_mipi_dsi_rockchip.txt | 1 + > .../bindings/phy/rockchip,px30-dsi-dphy.yaml | 1 + > arch/arm64/boot/dts/rockchip/rk356x.dtsi | 72 +++++++ > .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 51 ++++- > .../phy/rockchip/phy-rockchip-inno-dsidphy.c | 204 ++++++++++++++---- > 5 files changed, 281 insertions(+), 48 deletions(-) > > -- > 2.25.1 > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
On Tue, Sep 06, 2022 at 07:57:28PM +0200, Maya Matuszczyk wrote: > Hello, > What other patches would I need to apply to test this series > on Anbernic RG503? In addition to these patches you'd need the devicetree series: https://lore.kernel.org/linux-rockchip/20220906210324.28986-1-macroalpha82@gmail.com/ You'd need the panel driver: https://lore.kernel.org/dri-devel/20220906183642.12505-1-macroalpha82@gmail.com/ And you'd need to update the binding for the panel in the devicetree (example here): https://gist.github.com/macromorgan/caff01bfe4df6995d5f74cef701ede6d If you apply these patches and roll back the clock driver changes the panel should start working for you as it does for me. I tested by nuking my build-tree and starting fresh with just these patches. https://cdn.discordapp.com/attachments/973914035890290718/1015350475152949248/IMG_2028.jpg Thank you. > > Best Regards, > Maya Matuszczyk > > > wt., 6 wrz 2022 o 19:52 Chris Morgan <macroalpha82@gmail.com> napisał(a): > > > > From: Chris Morgan <macromorgan@hotmail.com> > > > > This series adds support for the dsi and dphy controllers on the > > Rockchip RK3568. I can confirm that for the Rockchip RK3568 this > > current series DOES WORK now, but it requires rolling back clk changes > > made for the HDMI driver. If the clock changes are not rolled back, the > > image on the screen is shifted about 100 pixels to the right. > > > > Clk changes in question: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/clk/rockchip/clk-rk3568.c?id=ff3187eabb5ce478d15b6ed62eb286756adefac3 > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/clk/rockchip/clk-rk3568.c?id=6e69052f01d9131388cfcfaee929120118a267f4 > > > > Tested on an Anbernic RG503 and RG353P with clock changes rolled back, > > the hardware works correctly on both devices. > > > > Changes since RFCv1: > > - Identified cause of image shift (clock changes). > > - Noted that driver works now. > > - Added devicetree nodes for rk356x.dtsi. > > > > Chris Morgan (5): > > dt-bindings: display: rockchip-dsi: add rk3568 compatible > > dt-bindings: phy-rockchip-inno-dsidphy: add compatible for rk3568 > > drm/rockchip: dsi: add rk3568 support > > phy/rockchip: inno-dsidphy: Add support for rk3568 > > arm64: dts: rockchip: Add DSI and DSI-DPHY nodes to rk356x > > > > .../display/rockchip/dw_mipi_dsi_rockchip.txt | 1 + > > .../bindings/phy/rockchip,px30-dsi-dphy.yaml | 1 + > > arch/arm64/boot/dts/rockchip/rk356x.dtsi | 72 +++++++ > > .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 51 ++++- > > .../phy/rockchip/phy-rockchip-inno-dsidphy.c | 204 ++++++++++++++---- > > 5 files changed, 281 insertions(+), 48 deletions(-) > > > > -- > > 2.25.1 > > > > > > _______________________________________________ > > Linux-rockchip mailing list > > Linux-rockchip@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-rockchip
On Tue, 6 Sep 2022 12:48:18 -0500, Chris Morgan wrote: > This series adds support for the dsi and dphy controllers on the > Rockchip RK3568. I can confirm that for the Rockchip RK3568 this > current series DOES WORK now, but it requires rolling back clk changes > made for the HDMI driver. If the clock changes are not rolled back, the > image on the screen is shifted about 100 pixels to the right. > > Clk changes in question: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/clk/rockchip/clk-rk3568.c?id=ff3187eabb5ce478d15b6ed62eb286756adefac3 > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/clk/rockchip/clk-rk3568.c?id=6e69052f01d9131388cfcfaee929120118a267f4 > > [...] Applied, thanks! [1/5] dt-bindings: display: rockchip-dsi: add rk3568 compatible commit: 1c3b502e4327e8e24e617a6f922df72870c0cb5f [3/5] drm/rockchip: dsi: add rk3568 support commit: f3aaa6125b6f1532d3276d705b1a3791f18a872a Best regards,
From: Chris Morgan <macromorgan@hotmail.com> This series adds support for the dsi and dphy controllers on the Rockchip RK3568. I can confirm that for the Rockchip RK3568 this current series DOES WORK now, but it requires rolling back clk changes made for the HDMI driver. If the clock changes are not rolled back, the image on the screen is shifted about 100 pixels to the right. Clk changes in question: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/clk/rockchip/clk-rk3568.c?id=ff3187eabb5ce478d15b6ed62eb286756adefac3 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/clk/rockchip/clk-rk3568.c?id=6e69052f01d9131388cfcfaee929120118a267f4 Tested on an Anbernic RG503 and RG353P with clock changes rolled back, the hardware works correctly on both devices. Changes since RFCv1: - Identified cause of image shift (clock changes). - Noted that driver works now. - Added devicetree nodes for rk356x.dtsi. Chris Morgan (5): dt-bindings: display: rockchip-dsi: add rk3568 compatible dt-bindings: phy-rockchip-inno-dsidphy: add compatible for rk3568 drm/rockchip: dsi: add rk3568 support phy/rockchip: inno-dsidphy: Add support for rk3568 arm64: dts: rockchip: Add DSI and DSI-DPHY nodes to rk356x .../display/rockchip/dw_mipi_dsi_rockchip.txt | 1 + .../bindings/phy/rockchip,px30-dsi-dphy.yaml | 1 + arch/arm64/boot/dts/rockchip/rk356x.dtsi | 72 +++++++ .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 51 ++++- .../phy/rockchip/phy-rockchip-inno-dsidphy.c | 204 ++++++++++++++---- 5 files changed, 281 insertions(+), 48 deletions(-)