mbox series

[v2,0/7] drm: Review of mode copies

Message ID 20221107192545.9896-1-ville.syrjala@linux.intel.com (mailing list archive)
Headers show
Series drm: Review of mode copies | expand

Message

Ville Syrjälä Nov. 7, 2022, 7:25 p.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Repost of the stragglers from
https://patchwork.freedesktop.org/series/100393/

Note that I didn't rerun the cocci stuff, nor have I had
time to come up with something to inluce the cocci scripts
in the tree. So it's possible this is missing some new
things that have snuck in the meantime.

Ville Syrjälä (7):
  drm/amdgpu: Use drm_mode_init() for on-stack modes
  drm/hisilicon: Use drm_mode_init() for on-stack modes
  drm/msm: Use drm_mode_init() for on-stack modes
  drm/msm: Use drm_mode_copy()
  drm/mtk: Use drm_mode_init() for on-stack modes
  drm/rockchip: Use drm_mode_copy()
  drm/sti: Use drm_mode_copy()

 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c    | 3 ++-
 drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c         | 2 +-
 drivers/gpu/drm/mediatek/mtk_hdmi.c                  | 2 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 7 +++++--
 drivers/gpu/drm/msm/dp/dp_display.c                  | 2 +-
 drivers/gpu/drm/rockchip/cdn-dp-core.c               | 2 +-
 drivers/gpu/drm/rockchip/inno_hdmi.c                 | 2 +-
 drivers/gpu/drm/rockchip/rk3066_hdmi.c               | 2 +-
 drivers/gpu/drm/sti/sti_dvo.c                        | 2 +-
 drivers/gpu/drm/sti/sti_hda.c                        | 2 +-
 drivers/gpu/drm/sti/sti_hdmi.c                       | 2 +-
 11 files changed, 16 insertions(+), 12 deletions(-)

Comments

Daniel Vetter Nov. 8, 2022, 3:53 p.m. UTC | #1
On Mon, Nov 07, 2022 at 09:25:38PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Repost of the stragglers from
> https://patchwork.freedesktop.org/series/100393/
> 
> Note that I didn't rerun the cocci stuff, nor have I had
> time to come up with something to inluce the cocci scripts
> in the tree. So it's possible this is missing some new
> things that have snuck in the meantime.
> 
> Ville Syrjälä (7):
>   drm/amdgpu: Use drm_mode_init() for on-stack modes
>   drm/hisilicon: Use drm_mode_init() for on-stack modes
>   drm/msm: Use drm_mode_init() for on-stack modes
>   drm/msm: Use drm_mode_copy()
>   drm/mtk: Use drm_mode_init() for on-stack modes
>   drm/rockchip: Use drm_mode_copy()
>   drm/sti: Use drm_mode_copy()

On the series:

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Imo ping Alex/Rob and stuff everything left into drm-misc-next.
-Daniel

> 
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c    | 3 ++-
>  drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c         | 2 +-
>  drivers/gpu/drm/mediatek/mtk_hdmi.c                  | 2 +-
>  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 7 +++++--
>  drivers/gpu/drm/msm/dp/dp_display.c                  | 2 +-
>  drivers/gpu/drm/rockchip/cdn-dp-core.c               | 2 +-
>  drivers/gpu/drm/rockchip/inno_hdmi.c                 | 2 +-
>  drivers/gpu/drm/rockchip/rk3066_hdmi.c               | 2 +-
>  drivers/gpu/drm/sti/sti_dvo.c                        | 2 +-
>  drivers/gpu/drm/sti/sti_hda.c                        | 2 +-
>  drivers/gpu/drm/sti/sti_hdmi.c                       | 2 +-
>  11 files changed, 16 insertions(+), 12 deletions(-)
> 
> -- 
> 2.37.4
>
Alex Deucher Nov. 8, 2022, 10:13 p.m. UTC | #2
On Tue, Nov 8, 2022 at 10:54 AM Daniel Vetter <daniel@ffwll.ch> wrote:
>
> On Mon, Nov 07, 2022 at 09:25:38PM +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Repost of the stragglers from
> > https://patchwork.freedesktop.org/series/100393/
> >
> > Note that I didn't rerun the cocci stuff, nor have I had
> > time to come up with something to inluce the cocci scripts
> > in the tree. So it's possible this is missing some new
> > things that have snuck in the meantime.
> >
> > Ville Syrjälä (7):
> >   drm/amdgpu: Use drm_mode_init() for on-stack modes
> >   drm/hisilicon: Use drm_mode_init() for on-stack modes
> >   drm/msm: Use drm_mode_init() for on-stack modes
> >   drm/msm: Use drm_mode_copy()
> >   drm/mtk: Use drm_mode_init() for on-stack modes
> >   drm/rockchip: Use drm_mode_copy()
> >   drm/sti: Use drm_mode_copy()
>
> On the series:
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Imo ping Alex/Rob and stuff everything left into drm-misc-next.

Acked-by: Alex Deucher <alexander.deucher@amd.com>
Feel free to take this series through whatever tree makes sense.  If
you want me to pick up the amdgpu change directly, I can do that too.

Alex

> -Daniel
>
> >
> >  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c    | 3 ++-
> >  drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c         | 2 +-
> >  drivers/gpu/drm/mediatek/mtk_hdmi.c                  | 2 +-
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 7 +++++--
> >  drivers/gpu/drm/msm/dp/dp_display.c                  | 2 +-
> >  drivers/gpu/drm/rockchip/cdn-dp-core.c               | 2 +-
> >  drivers/gpu/drm/rockchip/inno_hdmi.c                 | 2 +-
> >  drivers/gpu/drm/rockchip/rk3066_hdmi.c               | 2 +-
> >  drivers/gpu/drm/sti/sti_dvo.c                        | 2 +-
> >  drivers/gpu/drm/sti/sti_hda.c                        | 2 +-
> >  drivers/gpu/drm/sti/sti_hdmi.c                       | 2 +-
> >  11 files changed, 16 insertions(+), 12 deletions(-)
> >
> > --
> > 2.37.4
> >
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
Ville Syrjälä Nov. 9, 2022, 11:17 a.m. UTC | #3
On Tue, Nov 08, 2022 at 05:13:37PM -0500, Alex Deucher wrote:
> On Tue, Nov 8, 2022 at 10:54 AM Daniel Vetter <daniel@ffwll.ch> wrote:
> >
> > On Mon, Nov 07, 2022 at 09:25:38PM +0200, Ville Syrjala wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > Repost of the stragglers from
> > > https://patchwork.freedesktop.org/series/100393/
> > >
> > > Note that I didn't rerun the cocci stuff, nor have I had
> > > time to come up with something to inluce the cocci scripts
> > > in the tree. So it's possible this is missing some new
> > > things that have snuck in the meantime.
> > >
> > > Ville Syrjälä (7):
> > >   drm/amdgpu: Use drm_mode_init() for on-stack modes
> > >   drm/hisilicon: Use drm_mode_init() for on-stack modes
> > >   drm/msm: Use drm_mode_init() for on-stack modes
> > >   drm/msm: Use drm_mode_copy()
> > >   drm/mtk: Use drm_mode_init() for on-stack modes
> > >   drm/rockchip: Use drm_mode_copy()
> > >   drm/sti: Use drm_mode_copy()
> >
> > On the series:
> >
> > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >
> > Imo ping Alex/Rob and stuff everything left into drm-misc-next.
> 
> Acked-by: Alex Deucher <alexander.deucher@amd.com>
> Feel free to take this series through whatever tree makes sense.  If
> you want me to pick up the amdgpu change directly, I can do that too.

Please do. Less work for me ;)