| Message ID | 20230119235200.441386-1-harry.wentland@amd.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix MST on amdgpu | expand |
For the whole series: Reviewed-by: Lyude Paul <lyude@redhat.com> So glad to have this fixed finally ♥ On Thu, 2023-01-19 at 18:51 -0500, Harry Wentland wrote: > MST has been broken on amdgpu after a refactor in drm_dp_mst > code that was aligning drm_dp_mst more closely with the atomic > model. > > The gitlab issue: https://gitlab.freedesktop.org/drm/amd/-/issues/2171 > > This series fixes it. > > It can be found at > https://gitlab.freedesktop.org/hwentland/linux/-/tree/mst_regression > > A stable-6.1.y rebase can be found at > https://gitlab.freedesktop.org/hwentland/linux/-/tree/mst_regression_6.1 > > Lyude Paul (1): > drm/amdgpu/display/mst: Fix mst_state->pbn_div and slot count > assignments > > Wayne Lin (6): > drm/amdgpu/display/mst: limit payload to be updated one by one > drm/amdgpu/display/mst: update mst_mgr relevant variable when long HPD > drm/drm_print: correct format problem > drm/display/dp_mst: Correct the kref of port. > drm/amdgpu/display/mst: adjust the naming of mst_port and port of > aconnector > drm/amdgpu/display/mst: adjust the logic in 2nd phase of updating > payload > > drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 4 +- > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 48 +++++++++--- > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 4 +- > .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 2 +- > .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 16 ++-- > .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 76 +++++++++++++------ > .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 53 ++++++------- > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 14 +++- > drivers/gpu/drm/display/drm_dp_mst_topology.c | 4 +- > include/drm/drm_print.h | 2 +- > 10 files changed, 143 insertions(+), 80 deletions(-) > > -- > 2.39.0 >
For the whole series, as rebased on v6.1.7. Tested on this Thinkpad X13 AMD Gen2: Tested-By: Didier Raboud <odyx@debian.org> Le vendredi, 20 janvier 2023, 00.51:53 h CET Harry Wentland a écrit : > MST has been broken on amdgpu after a refactor in drm_dp_mst > code that was aligning drm_dp_mst more closely with the atomic > model. > > The gitlab issue: https://gitlab.freedesktop.org/drm/amd/-/issues/2171 > > This series fixes it.
On 1/20/23 18:15, Lyude Paul wrote: > For the whole series: > > Reviewed-by: Lyude Paul <lyude@redhat.com> Thanks, series is merged to amd-staging-drm-next. Harry > > So glad to have this fixed finally ♥ > > On Thu, 2023-01-19 at 18:51 -0500, Harry Wentland wrote: >> MST has been broken on amdgpu after a refactor in drm_dp_mst >> code that was aligning drm_dp_mst more closely with the atomic >> model. >> >> The gitlab issue: https://gitlab.freedesktop.org/drm/amd/-/issues/2171 >> >> This series fixes it. >> >> It can be found at >> https://gitlab.freedesktop.org/hwentland/linux/-/tree/mst_regression >> >> A stable-6.1.y rebase can be found at >> https://gitlab.freedesktop.org/hwentland/linux/-/tree/mst_regression_6.1 >> >> Lyude Paul (1): >> drm/amdgpu/display/mst: Fix mst_state->pbn_div and slot count >> assignments >> >> Wayne Lin (6): >> drm/amdgpu/display/mst: limit payload to be updated one by one >> drm/amdgpu/display/mst: update mst_mgr relevant variable when long HPD >> drm/drm_print: correct format problem >> drm/display/dp_mst: Correct the kref of port. >> drm/amdgpu/display/mst: adjust the naming of mst_port and port of >> aconnector >> drm/amdgpu/display/mst: adjust the logic in 2nd phase of updating >> payload >> >> drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 4 +- >> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 48 +++++++++--- >> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 4 +- >> .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 2 +- >> .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 16 ++-- >> .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 76 +++++++++++++------ >> .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 53 ++++++------- >> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 14 +++- >> drivers/gpu/drm/display/drm_dp_mst_topology.c | 4 +- >> include/drm/drm_print.h | 2 +- >> 10 files changed, 143 insertions(+), 80 deletions(-) >> >> -- >> 2.39.0 >> >
On 1/22/23 14:12, Didier 'OdyX' Raboud wrote: > For the whole series, as rebased on v6.1.7. Tested on this Thinkpad X13 AMD > Gen2: > > Tested-By: Didier Raboud <odyx@debian.org> Thanks. Harry > > Le vendredi, 20 janvier 2023, 00.51:53 h CET Harry Wentland a écrit : >> MST has been broken on amdgpu after a refactor in drm_dp_mst >> code that was aligning drm_dp_mst more closely with the atomic >> model. >> >> The gitlab issue: https://gitlab.freedesktop.org/drm/amd/-/issues/2171 >> >> This series fixes it. > >
MST has been broken on amdgpu after a refactor in drm_dp_mst code that was aligning drm_dp_mst more closely with the atomic model. The gitlab issue: https://gitlab.freedesktop.org/drm/amd/-/issues/2171 This series fixes it. It can be found at https://gitlab.freedesktop.org/hwentland/linux/-/tree/mst_regression A stable-6.1.y rebase can be found at https://gitlab.freedesktop.org/hwentland/linux/-/tree/mst_regression_6.1 Lyude Paul (1): drm/amdgpu/display/mst: Fix mst_state->pbn_div and slot count assignments Wayne Lin (6): drm/amdgpu/display/mst: limit payload to be updated one by one drm/amdgpu/display/mst: update mst_mgr relevant variable when long HPD drm/drm_print: correct format problem drm/display/dp_mst: Correct the kref of port. drm/amdgpu/display/mst: adjust the naming of mst_port and port of aconnector drm/amdgpu/display/mst: adjust the logic in 2nd phase of updating payload drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 4 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 48 +++++++++--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 4 +- .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 2 +- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 16 ++-- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 76 +++++++++++++------ .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 53 ++++++------- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 14 +++- drivers/gpu/drm/display/drm_dp_mst_topology.c | 4 +- include/drm/drm_print.h | 2 +- 10 files changed, 143 insertions(+), 80 deletions(-) -- 2.39.0