From patchwork Thu Feb 23 10:51:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13150109 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B859C61DA4 for ; Thu, 23 Feb 2023 10:52:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E1C0910E04F; Thu, 23 Feb 2023 10:52:06 +0000 (UTC) Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by gabe.freedesktop.org (Postfix) with ESMTPS id E102A10E04F for ; Thu, 23 Feb 2023 10:52:05 +0000 (UTC) Received: by mail-lf1-x130.google.com with SMTP id i9so13106059lfc.6 for ; Thu, 23 Feb 2023 02:52:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=Fad0B/rhNAjnOyEdJToKazkQgow6CPI+KmVYb5YkBn0=; b=G+pOktPZ3zofS03mq097ipPC1zgnPvchdrSSIaeK0m1/MIDlAi7psnfHpQdA4+soTF dfeCd691t6AM9sdo02sZH2Orbn3jNKrK0K/ty3TbDosSbMdzU+7MKcHNPpdhwE+a8FEw x89eg2nTERzd3v/H1rArc+PYKPh3+LGR774etyJD64Zl3lrOH7iy6YMLW3i0f5x2sS+p bdf8hoDhFAM9H0WcCw8brd8j4nbgLmj/Mh0csJZaXSKLi1HQCXxDOoyXE+Sfa2AzEOpU 3bOK6qR7oHFxIz3+FfTENgXDsEdif7zTjWmKZWGnZ53CyoE12KKttd4hydoSFbZyVNRC t6ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Fad0B/rhNAjnOyEdJToKazkQgow6CPI+KmVYb5YkBn0=; b=ghkzEvUHSSdBcIgBxudMl3Il91Qrw4bibjdcGuRpssdKDNfSFm+8KJkyDJhXwAlgPJ lXGDbeDqE3dOWQkRIjk5oYDBcY3cBygs//9VRnCt+LDCWILmN5qKHZEdQXBRFZGvdKas ncXDiLzVhl5f273VC7U3aq4Qr/NIdD2JZBdm4fntSO3tWz1Mq1OoXxVJAdIo/AsmVi/P +6Fu/rZiI9QX5/8STFVbSkvAzu4lPgl/+8Wid8Mkp+sLv5Hmfc8VYIyf9N7ooafUs8aF eckwT0JdrwVehIn+bnVrvUuIKrSoi9pUy/xev+Z1Vx/w176t7/4yXEs4pOv2ybZskz0L //CA== X-Gm-Message-State: AO0yUKXyvKabVNwHqKEcc3aEEVyv1r1OzxAEobdS7zLYhgky9U6dolLo 9Fkhawe9wRBnT+b3z1hkMLzGuw== X-Google-Smtp-Source: AK7set9MrkjvA3PRtR+X++flPhHS8oJ3vWoTNNeAaB6kgOnBYe7J3pDG8j9GdeVhQgmYWEZ71490tQ== X-Received: by 2002:a05:6512:682:b0:4dc:790c:9100 with SMTP id t2-20020a056512068200b004dc790c9100mr4779511lfe.12.1677149524057; Thu, 23 Feb 2023 02:52:04 -0800 (PST) Received: from [192.168.1.101] (abxi151.neoplus.adsl.tpnet.pl. [83.9.2.151]) by smtp.gmail.com with ESMTPSA id m25-20020ac24ad9000000b004cf07a0051csm262304lfp.228.2023.02.23.02.52.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 02:52:03 -0800 (PST) From: Konrad Dybcio Subject: [PATCH v3 0/7] OPP and devfreq for all Adrenos Date: Thu, 23 Feb 2023 11:51:56 +0100 Message-Id: <20230223-topic-opp-v3-0-5f22163cd1df@linaro.org> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAExF92MC/22NTQ6CMBBGr0JmbU2ZohBX3sOwKO0Ik5C2mSLRE O5uZe3yvXw/G2QSpgy3agOhlTPHUMCcKnCTDSMp9oUBNRqNaNQSEzsVU1K6prauceiurYeSH2w mNYgNbiqN8JrnIpPQk9/HwaMvPHFeonyOvxV/9t/0ikorbMhj43xrLt195mAlnqOM0O/7/gUFU 7K3uAAAAA== To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1677149522; l=2895; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=1TrYwzypEOhtdRr9Ii2Om5YZnHZPr/HRHl6+KZECI8A=; b=RlXNdpwiG5uTIMPIsVD8Pi10qSkZDvcoBNOKno/DktqhHK7H907L54lQ6oxyQ2O4mvfEwDMSW/Q7 33APj/7SC4bZOjTunDWqJlT3WyiBJZMJsp11sfkpC2jUNHmWwHIv X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" v2 -> v3: - Add [2/7], x-ref with https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21484 - De-magic-ify the remaining BIT(6) in a2xx_busy (thanks Dmitry) - Drop unnecessary else{} level in [3/7] - Pick up tags v2: https://lore.kernel.org/linux-arm-msm/20230223-topic-opp-v2-0-24ed24cd7358@linaro.org/ v1 -> v2: - Move a2xx #defines to XML - Use dev_pm_opp_find_freq_floor in the common path in [2/6] - Clarify a comment in [2/6] - Move voting from a5xx to Adreno-wide [6/6] - Pick up tags v1: https://lore.kernel.org/linux-arm-msm/20230222-konrad-longbois-next-v1-0-01021425781b@linaro.org This series is a combination of [1] and a subset of [2] and some new stuff. With it, devfreq is used on all a2xx-a6xx (including gmu and gmu-wrapper) and all clk_set_rate(core clock) calls are dropped in favour of dev_pm_opp_set_rate, which - drumroll - lets us scale the voltage domain. DT patches making use of that will be sent separately. On top of that, a5xx gets a call to enable icc scaling from the OPP tables. No SoCs implementing a2xx have icc support yet and a3/4xx SoCs have separate logic for that, which will be updated at a later time. Getting this in for 6.4 early would be appreciated, as that would allow for getting GMU wrapper GPUs up (without VDD&icc scaling they can only run at lower freqs, which is.. ehhh..) Changes: - a3xx busy: use the _1 counter as per msm-3.x instead of _0 - a6xx-series-opp: basically rewrite, ensure compat with all gens - a2/4xx busy: new patch - a5xx icc: new patch [1] https://lore.kernel.org/linux-arm-msm/20230130093809.2079314-1-konrad.dybcio@linaro.org/ [2] https://lore.kernel.org/linux-arm-msm/20230214173145.2482651-1-konrad.dybcio@linaro.org/ Signed-off-by: Konrad Dybcio --- Konrad Dybcio (7): drm/msm/a2xx: Include perf counter reg values in XML drm/msm/a2xx: Add REG_A2XX_RBBM_PM_OVERRIDE2 to XML drm/msm/adreno: Use OPP for every GPU generation drm/msm/a2xx: Implement .gpu_busy drm/msm/a3xx: Implement .gpu_busy drm/msm/a4xx: Implement .gpu_busy drm/msm/adreno: Enable optional icc voting from OPP tables drivers/gpu/drm/msm/adreno/a2xx.xml.h | 18 ++++++ drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 26 ++++++++ drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 11 ++++ drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 11 ++++ drivers/gpu/drm/msm/adreno/adreno_device.c | 4 ++ drivers/gpu/drm/msm/adreno/adreno_gpu.c | 99 +++++++++++++----------------- drivers/gpu/drm/msm/msm_gpu.c | 4 +- drivers/gpu/drm/msm/msm_gpu_devfreq.c | 2 +- 8 files changed, 117 insertions(+), 58 deletions(-) --- base-commit: aaf70d5ad5e2b06a8050c51e278b0c3a14fabef5 change-id: 20230223-topic-opp-01e7112b867d Best regards,