| Message ID | 20230509093036.3303-1-a-bhatia1@ti.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/tidss: Use new connector model for tidss | expand |
On 09/05/2023 12:30, Aradhya Bhatia wrote: > Hi all, > > I have picked up this long standing series from Nikhil Devshatwar[1]. > > This series moves the tidss to using new connectoe model, where the SoC > driver (tidss) creates the connector and all the bridges are attached > with the flag DRM_BRIDGE_ATTACH_NO_CONNECTOR. It also now creates bridge > to support format negotiation and and 'simple' encoder to expose it to > the userspace. > > Since the bridges do not create the connector, the bus_format and > bus_flag is set via atomic hooks. > > Support format negotiations in the tfp410, sii902x and mhdp-8546 bridge > drivers as a first step before moving the connector model. > > These patches were tested on AM625-SK EVM, AM625 SoC based BeaglePlay, > and J721E-SK. Display support for AM625 SoC has not been added upstream > and is a WIP. To test this series on AM625 based platforms, basic > display support patches, (for driver + devicetree), can be found in > the "next_AttachNoConn" branch on my github fork[2]. Not exactly related to this series, but I was testing this with J7 EVM and a Dell DP monitor. I'm seeing DPCD errors quite often, which also sometimes cause link training errors. E.g.: cdns-mhdp8546 a000000.dp-bridge: Failed to read DPCD addr 0 cdns-mhdp8546 a000000.dp-bridge: Failed to adjust Link Training. I tested retrying the read/write when it fails, and that seemed to help a bit, but not always. Are you using the firmware that's on the upstream linux-firmware repo? Tomi
Hi all, I have picked up this long standing series from Nikhil Devshatwar[1]. This series moves the tidss to using new connectoe model, where the SoC driver (tidss) creates the connector and all the bridges are attached with the flag DRM_BRIDGE_ATTACH_NO_CONNECTOR. It also now creates bridge to support format negotiation and and 'simple' encoder to expose it to the userspace. Since the bridges do not create the connector, the bus_format and bus_flag is set via atomic hooks. Support format negotiations in the tfp410, sii902x and mhdp-8546 bridge drivers as a first step before moving the connector model. These patches were tested on AM625-SK EVM, AM625 SoC based BeaglePlay, and J721E-SK. Display support for AM625 SoC has not been added upstream and is a WIP. To test this series on AM625 based platforms, basic display support patches, (for driver + devicetree), can be found in the "next_AttachNoConn" branch on my github fork[2]. Thanks, Aradhya [1]: https://patchwork.freedesktop.org/series/82765/#rev5 [2]: https://github.com/aradhya07/linux-ab/tree/next_AttachNoConn Change Log: V5 -> V6 - Rebase and cosmetic changes - Dropped the output format check condition for tfp410 and hence, dropped Tomi Valkeinen's and Laurent Pinchart's R-b tags. - Based on Boris Brezillon's comments: dropped patches 5 and 6 from the series and instead created a single patch that, 1. Creates tidss bridge for format negotiation. 2. Creates 'simple' encoder for userspace exposure. 3. Creates a tidss connector. 4. Attaches the next-bridge to encoder with the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag. - Add format negotiation support for sii902x driver. Previous series: V1 to V5: https://patchwork.freedesktop.org/series/82765/ Aradhya Bhatia (3): drm/bridge: sii902x: Support format negotiation hooks drm/bridge: sii902x: Set input_bus_flags in atomic_check drm/tidss: Update encoder/bridge chain connect model Nikhil Devshatwar (5): drm/bridge: tfp410: Support format negotiation hooks drm/bridge: tfp410: Set input_bus_flags in atomic_check drm/bridge: mhdp8546: Add minimal format negotiation drm/bridge: mhdp8546: Set input_bus_flags from atomic_check drm/bridge: cdns-mhdp8546: Fix the interrupt enable/disable .../drm/bridge/cadence/cdns-mhdp8546-core.c | 80 ++++++---- .../drm/bridge/cadence/cdns-mhdp8546-core.h | 2 +- .../drm/bridge/cadence/cdns-mhdp8546-j721e.c | 9 +- .../drm/bridge/cadence/cdns-mhdp8546-j721e.h | 2 +- drivers/gpu/drm/bridge/sii902x.c | 41 +++++ drivers/gpu/drm/bridge/ti-tfp410.c | 42 ++++++ drivers/gpu/drm/tidss/tidss_encoder.c | 140 +++++++++++------- drivers/gpu/drm/tidss/tidss_encoder.h | 5 +- drivers/gpu/drm/tidss/tidss_kms.c | 12 +- 9 files changed, 238 insertions(+), 95 deletions(-)