mbox series

[0/3] drm/vkms: Minor Improvements

Message ID 20230515135204.115393-1-mcanal@igalia.com (mailing list archive)
Headers show
Series drm/vkms: Minor Improvements | expand

Message

Maíra Canal May 15, 2023, 1:52 p.m. UTC
This series addresses some minor improvements to the writeback
functionality. The first patch intends to reduce the critical section
of a spinlock by removing assignments that don't need to be protected
by a lock. The second patch enables the support for ARGB8888 on the
writeback. Finally, the third patch refactors the pixel conversion
functions of the writeback functionality. This patch is a follow-up of
a previous patchset [1], in which Melissa suggested to apply the same
refactor to the writeback pixel conversion functions.

[1] https://lore.kernel.org/dri-devel/20230418130525.128733-1-mcanal@igalia.com/T/

Best Regards,
- Maíra

Maíra Canal (3):
  drm/vkms: Reduce critical section
  drm/vkms: Enable ARGB8888 support for writeback
  drm/vkms: Isolate writeback pixel conversion functions

 drivers/gpu/drm/vkms/vkms_composer.c  |   4 +-
 drivers/gpu/drm/vkms/vkms_drv.h       |   4 +-
 drivers/gpu/drm/vkms/vkms_formats.c   | 140 +++++++++++---------------
 drivers/gpu/drm/vkms/vkms_formats.h   |   2 +-
 drivers/gpu/drm/vkms/vkms_writeback.c |   9 +-
 5 files changed, 68 insertions(+), 91 deletions(-)

Comments

Arthur Grillo May 16, 2023, 7:40 p.m. UTC | #1
On 15/05/23 10:52, Maíra Canal wrote:
> This series addresses some minor improvements to the writeback
> functionality. The first patch intends to reduce the critical section
> of a spinlock by removing assignments that don't need to be protected
> by a lock. The second patch enables the support for ARGB8888 on the
> writeback. Finally, the third patch refactors the pixel conversion
> functions of the writeback functionality. This patch is a follow-up of
> a previous patchset [1], in which Melissa suggested to apply the same
> refactor to the writeback pixel conversion functions.
> 
> [1] https://lore.kernel.org/dri-devel/20230418130525.128733-1-mcanal@igalia.com/T/
> 
> Best Regards,
> - Maíra

On the entire patchset,

Reviewed-by: Arthur Grillo <arthurgrillo@riseup.net>

Best Regards,
~Arthur Grillo

> 
> Maíra Canal (3):
>   drm/vkms: Reduce critical section
>   drm/vkms: Enable ARGB8888 support for writeback
>   drm/vkms: Isolate writeback pixel conversion functions
> 
>  drivers/gpu/drm/vkms/vkms_composer.c  |   4 +-
>  drivers/gpu/drm/vkms/vkms_drv.h       |   4 +-
>  drivers/gpu/drm/vkms/vkms_formats.c   | 140 +++++++++++---------------
>  drivers/gpu/drm/vkms/vkms_formats.h   |   2 +-
>  drivers/gpu/drm/vkms/vkms_writeback.c |   9 +-
>  5 files changed, 68 insertions(+), 91 deletions(-)
>