mbox series

[0/3] fbdev/hitfb: Various fixes

Message ID 20230606104056.29553-1-tzimmermann@suse.de (mailing list archive)
Headers show
Series fbdev/hitfb: Various fixes | expand

Message

Thomas Zimmermann June 6, 2023, 10:40 a.m. UTC 
Fix a number of minor warnings in the hitfb driver. I discovered
them while working on bb47f218fd01 ("fbdev/hitfb: Cast I/O offset
to address").

Thomas Zimmermann (3):
  fbdev/hitfb: Declare hitfb_blank() as static
  fbdev/hitfb: Fix integer-to-pointer cast
  fbdev/hitfb: Use NULL for pointers

 drivers/video/fbdev/hitfb.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)


base-commit: 29c0f369e17ba0abf08c65ca065417aebab208c6

Comments

Ruhl, Michael J June 6, 2023, 12:35 p.m. UTC | #1 
>-----Original Message-----
>From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of
>Thomas Zimmermann
>Sent: Tuesday, June 6, 2023 6:41 AM
>To: deller@gmx.de; David.Laight@ACULAB.COM
>Cc: linux-fbdev@vger.kernel.org; Thomas Zimmermann
><tzimmermann@suse.de>; dri-devel@lists.freedesktop.org; linux-
>sh@vger.kernel.org
>Subject: [PATCH 0/3] fbdev/hitfb: Various fixes
>
>Fix a number of minor warnings in the hitfb driver. I discovered
>them while working on bb47f218fd01 ("fbdev/hitfb: Cast I/O offset
>to address").
>
>Thomas Zimmermann (3):
>  fbdev/hitfb: Declare hitfb_blank() as static
>  fbdev/hitfb: Fix integer-to-pointer cast
>  fbdev/hitfb: Use NULL for pointers

These look reasonable to me.

For the series:

Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com>

> drivers/video/fbdev/hitfb.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>
>base-commit: 29c0f369e17ba0abf08c65ca065417aebab208c6
>--
>2.40.1
Thomas Zimmermann June 12, 2023, 2:59 p.m. UTC | #2 
Helge, do you take these patches?

Am 06.06.23 um 12:40 schrieb Thomas Zimmermann:
> Fix a number of minor warnings in the hitfb driver. I discovered
> them while working on bb47f218fd01 ("fbdev/hitfb: Cast I/O offset
> to address").
> 
> Thomas Zimmermann (3):
>    fbdev/hitfb: Declare hitfb_blank() as static
>    fbdev/hitfb: Fix integer-to-pointer cast
>    fbdev/hitfb: Use NULL for pointers
> 
>   drivers/video/fbdev/hitfb.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> 
> base-commit: 29c0f369e17ba0abf08c65ca065417aebab208c6