| Message ID | 20230710-kms-kunit-actions-rework-v1-0-722c58d72c72@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm: kunit: Switch to kunit actions | expand |
Hi, On 2023/7/10 15:47, Maxime Ripard wrote: > Hi, > > Since v6.5-rc1, kunit gained a devm/drmm-like mechanism that makes tests > resources much easier to cleanup. > > This series converts the existing tests to use those new actions were > relevant. Is the word 'were' here means that 'where' relevant ? Or it is means that it were relevant, after applied you patch it is not relevant anymore ? > Let me know what you think, > Maxime > > Signed-off-by: Maxime Ripard <mripard@kernel.org> > --- > Maxime Ripard (11): > drm/tests: helpers: Switch to kunit actions > drm/tests: client-modeset: Remove call to drm_kunit_helper_free_device() > drm/tests: modes: Remove call to drm_kunit_helper_free_device() > drm/tests: probe-helper: Remove call to drm_kunit_helper_free_device() > drm/tests: helpers: Create an helper to allocate a locking ctx > drm/tests: helpers: Create an helper to allocate an atomic state a helper or an helper ? Should this two patch be re-titled as following ? I search it on the internet[1], mostly using a helper. drm/tests: helpers: Create a helper to allocate a locking ctx drm/tests: helpers: Create a helper to allocate an atomic state [1] https://www.a-or-an.com/a_an/helper Sorry about the noise if I'm wrong. > drm/vc4: tests: pv-muxing: Remove call to drm_kunit_helper_free_device() > drm/vc4: tests: mock: Use a kunit action to unregister DRM device > drm/vc4: tests: pv-muxing: Switch to managed locking init > drm/vc4: tests: Switch to atomic state allocation helper > drm/vc4: tests: pv-muxing: Document test scenario > > drivers/gpu/drm/tests/drm_client_modeset_test.c | 8 -- > drivers/gpu/drm/tests/drm_kunit_helpers.c | 112 ++++++++++++++++++++++- > drivers/gpu/drm/tests/drm_modes_test.c | 8 -- > drivers/gpu/drm/tests/drm_probe_helper_test.c | 8 -- > drivers/gpu/drm/vc4/tests/vc4_mock.c | 5 ++ > drivers/gpu/drm/vc4/tests/vc4_test_pv_muxing.c | 115 +++++++++--------------- > include/drm/drm_kunit_helpers.h | 7 ++ > 7 files changed, 162 insertions(+), 101 deletions(-) > --- > base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 > change-id: 20230710-kms-kunit-actions-rework-5d163762c93b > > Best regards,
Hi, On Mon, Jul 17, 2023 at 11:24:13PM +0800, suijingfeng wrote: > On 2023/7/10 15:47, Maxime Ripard wrote: > > Hi, > > > > Since v6.5-rc1, kunit gained a devm/drmm-like mechanism that makes tests > > resources much easier to cleanup. > > > > This series converts the existing tests to use those new actions were > > relevant. > > Is the word 'were' here means that 'where' relevant ? Yes :) > Or it is means that it were relevant, after applied you patch it is not > relevant anymore ? > > > Let me know what you think, > > Maxime > > > > Signed-off-by: Maxime Ripard <mripard@kernel.org> > > --- > > Maxime Ripard (11): > > drm/tests: helpers: Switch to kunit actions > > drm/tests: client-modeset: Remove call to drm_kunit_helper_free_device() > > drm/tests: modes: Remove call to drm_kunit_helper_free_device() > > drm/tests: probe-helper: Remove call to drm_kunit_helper_free_device() > > drm/tests: helpers: Create an helper to allocate a locking ctx > > drm/tests: helpers: Create an helper to allocate an atomic state > > a helper or an helper ? > > Should this two patch be re-titled as following ? > > I search it on the internet[1], mostly using a helper. > > > drm/tests: helpers: Create a helper to allocate a locking ctx > drm/tests: helpers: Create a helper to allocate an atomic state > > [1] https://www.a-or-an.com/a_an/helper > > Sorry about the noise if I'm wrong. You're right, I'll fix it Thanks! Maxime
Hi, Since v6.5-rc1, kunit gained a devm/drmm-like mechanism that makes tests resources much easier to cleanup. This series converts the existing tests to use those new actions were relevant. Let me know what you think, Maxime Signed-off-by: Maxime Ripard <mripard@kernel.org> --- Maxime Ripard (11): drm/tests: helpers: Switch to kunit actions drm/tests: client-modeset: Remove call to drm_kunit_helper_free_device() drm/tests: modes: Remove call to drm_kunit_helper_free_device() drm/tests: probe-helper: Remove call to drm_kunit_helper_free_device() drm/tests: helpers: Create an helper to allocate a locking ctx drm/tests: helpers: Create an helper to allocate an atomic state drm/vc4: tests: pv-muxing: Remove call to drm_kunit_helper_free_device() drm/vc4: tests: mock: Use a kunit action to unregister DRM device drm/vc4: tests: pv-muxing: Switch to managed locking init drm/vc4: tests: Switch to atomic state allocation helper drm/vc4: tests: pv-muxing: Document test scenario drivers/gpu/drm/tests/drm_client_modeset_test.c | 8 -- drivers/gpu/drm/tests/drm_kunit_helpers.c | 112 ++++++++++++++++++++++- drivers/gpu/drm/tests/drm_modes_test.c | 8 -- drivers/gpu/drm/tests/drm_probe_helper_test.c | 8 -- drivers/gpu/drm/vc4/tests/vc4_mock.c | 5 ++ drivers/gpu/drm/vc4/tests/vc4_test_pv_muxing.c | 115 +++++++++--------------- include/drm/drm_kunit_helpers.h | 7 ++ 7 files changed, 162 insertions(+), 101 deletions(-) --- base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 change-id: 20230710-kms-kunit-actions-rework-5d163762c93b Best regards,