mbox series

[v2,0/8] ADV7511 driver enhancements

Message ID 20230830142358.275459-1-biju.das.jz@bp.renesas.com (mailing list archive)
Headers show
Series ADV7511 driver enhancements | expand

Message

Biju Das Aug. 30, 2023, 2:23 p.m. UTC
This patch series aims to improve ADV7511 driver by adding
feature bits and data instead of comparing enum adv7511_type for
various hardware differences between ADV7511, ADV7533 and ADV7535.

This patch series tested with[1] on RZ/G2L SMARC EVK which embeds
ADV7535.

[1] https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=762260

v1->v2:
 * Added Rb tag from Adam and Laurent.
 * Added tested by tag from Adam and Fabio.
 * Updated commit description with reason *why* the change is needed.
 * Dropped the local info variable and instead started using
   adv7511->info->type in probe().
 * Replaced max_mode_clock->max_mode_clock_khz in struct adv7511_chip_info
 * Replaced variable type for max_mode_clock_khz from
   unsigned int->unsigned long.
 * Replaced max_lane_freq->max_lane_freq_khz in struct adv7511_chip_info.
 * Replaced max_lane_freq_khz variable type from
   unsigned long->unsigned int.
 * Added trailing commas for num_supplies in adv753{3,5}_chip_info.
 * Added patch#5 for adding the reg_cec_offset variable to struct
   adv7511_chip_info.
 * Replaced has_dsi variable type from unsigned->bool.
 * Restored check using type for low_refresh_rate and
   regmap_register_patch().
 * Replaced link_config variable type from unsigned->bool.
 * Restored enum adv7511_type as there are users.
 * Replaced hpd_override_enable variable type from unsigned->bool.

Biju Das (8):
  drm: adv7511: Add struct adv7511_chip_info and use
    i2c_get_match_data()
  drm: adv7511: Add max_mode_clock_khz variable to struct
    adv7511_chip_info
  drm: adv7511: Add max_lane_freq_khz variable to struct
    adv7511_chip_info
  drm: adv7511: Add supply_names and num_supplies variables to struct
    adv7511_chip_info
  drm: adv7511: Add reg_cec_offset variable to struct adv7511_chip_info
  drm: adv7511: Add has_dsi variable to struct adv7511_chip_info
  drm: adv7511: Add link_config variable to struct adv7511_chip_info
  drm: adv7511: Add hpd_override_enable variable to struct
    adv7511_chip_info

 drivers/gpu/drm/bridge/adv7511/adv7511.h     |  16 ++-
 drivers/gpu/drm/bridge/adv7511/adv7511_cec.c |  14 +--
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 104 +++++++++++--------
 drivers/gpu/drm/bridge/adv7511/adv7533.c     |   7 +-
 4 files changed, 81 insertions(+), 60 deletions(-)

Comments

Biju Das Oct. 2, 2023, 7:14 a.m. UTC | #1
Hi All,

Gentle ping. Are we happy with this patch serries?

Cheers,
Biju

> -----Original Message-----
> From: Biju Das <biju.das.jz@bp.renesas.com>
> Sent: Wednesday, August 30, 2023 3:24 PM
> Subject: [PATCH v2 0/8] ADV7511 driver enhancements
> 
> This patch series aims to improve ADV7511 driver by adding feature bits and
> data instead of comparing enum adv7511_type for various hardware
> differences between ADV7511, ADV7533 and ADV7535.
> 
> This patch series tested with[1] on RZ/G2L SMARC EVK which embeds ADV7535.
> 
> [1]
> 
> v1->v2:
>  * Added Rb tag from Adam and Laurent.
>  * Added tested by tag from Adam and Fabio.
>  * Updated commit description with reason *why* the change is needed.
>  * Dropped the local info variable and instead started using
>    adv7511->info->type in probe().
>  * Replaced max_mode_clock->max_mode_clock_khz in struct adv7511_chip_info
>  * Replaced variable type for max_mode_clock_khz from
>    unsigned int->unsigned long.
>  * Replaced max_lane_freq->max_lane_freq_khz in struct adv7511_chip_info.
>  * Replaced max_lane_freq_khz variable type from
>    unsigned long->unsigned int.
>  * Added trailing commas for num_supplies in adv753{3,5}_chip_info.
>  * Added patch#5 for adding the reg_cec_offset variable to struct
>    adv7511_chip_info.
>  * Replaced has_dsi variable type from unsigned->bool.
>  * Restored check using type for low_refresh_rate and
>    regmap_register_patch().
>  * Replaced link_config variable type from unsigned->bool.
>  * Restored enum adv7511_type as there are users.
>  * Replaced hpd_override_enable variable type from unsigned->bool.
> 
> Biju Das (8):
>   drm: adv7511: Add struct adv7511_chip_info and use
>     i2c_get_match_data()
>   drm: adv7511: Add max_mode_clock_khz variable to struct
>     adv7511_chip_info
>   drm: adv7511: Add max_lane_freq_khz variable to struct
>     adv7511_chip_info
>   drm: adv7511: Add supply_names and num_supplies variables to struct
>     adv7511_chip_info
>   drm: adv7511: Add reg_cec_offset variable to struct adv7511_chip_info
>   drm: adv7511: Add has_dsi variable to struct adv7511_chip_info
>   drm: adv7511: Add link_config variable to struct adv7511_chip_info
>   drm: adv7511: Add hpd_override_enable variable to struct
>     adv7511_chip_info
> 
>  drivers/gpu/drm/bridge/adv7511/adv7511.h     |  16 ++-
>  drivers/gpu/drm/bridge/adv7511/adv7511_cec.c |  14 +--
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 104 +++++++++++--------
>  drivers/gpu/drm/bridge/adv7511/adv7533.c     |   7 +-
>  4 files changed, 81 insertions(+), 60 deletions(-)
> 
> --
> 2.25.1
Biju Das Oct. 9, 2023, 7:04 a.m. UTC | #2
Hi All,

Gentle ping. Are we happy with this patch series?
Is anything to be improved? Please let me know.

Cheers,
Biju

> -----Original Message-----
> From: Biju Das
> Sent: Monday, October 2, 2023 8:15 AM
> Subject: RE: [PATCH v2 0/8] ADV7511 driver enhancements

> > -----Original Message-----
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> > Sent: Wednesday, August 30, 2023 3:24 PM
> > Subject: [PATCH v2 0/8] ADV7511 driver enhancements
> >
> > This patch series aims to improve ADV7511 driver by adding feature
> > bits and data instead of comparing enum adv7511_type for various
> > hardware differences between ADV7511, ADV7533 and ADV7535.
> >
> > This patch series tested with[1] on RZ/G2L SMARC EVK which embeds
> ADV7535.
> >
> > [1]
> >
> > v1->v2:
> >  * Added Rb tag from Adam and Laurent.
> >  * Added tested by tag from Adam and Fabio.
> >  * Updated commit description with reason *why* the change is needed.
> >  * Dropped the local info variable and instead started using
> >    adv7511->info->type in probe().
> >  * Replaced max_mode_clock->max_mode_clock_khz in struct
> > adv7511_chip_info
> >  * Replaced variable type for max_mode_clock_khz from
> >    unsigned int->unsigned long.
> >  * Replaced max_lane_freq->max_lane_freq_khz in struct adv7511_chip_info.
> >  * Replaced max_lane_freq_khz variable type from
> >    unsigned long->unsigned int.
> >  * Added trailing commas for num_supplies in adv753{3,5}_chip_info.
> >  * Added patch#5 for adding the reg_cec_offset variable to struct
> >    adv7511_chip_info.
> >  * Replaced has_dsi variable type from unsigned->bool.
> >  * Restored check using type for low_refresh_rate and
> >    regmap_register_patch().
> >  * Replaced link_config variable type from unsigned->bool.
> >  * Restored enum adv7511_type as there are users.
> >  * Replaced hpd_override_enable variable type from unsigned->bool.
> >
> > Biju Das (8):
> >   drm: adv7511: Add struct adv7511_chip_info and use
> >     i2c_get_match_data()
> >   drm: adv7511: Add max_mode_clock_khz variable to struct
> >     adv7511_chip_info
> >   drm: adv7511: Add max_lane_freq_khz variable to struct
> >     adv7511_chip_info
> >   drm: adv7511: Add supply_names and num_supplies variables to struct
> >     adv7511_chip_info
> >   drm: adv7511: Add reg_cec_offset variable to struct adv7511_chip_info
> >   drm: adv7511: Add has_dsi variable to struct adv7511_chip_info
> >   drm: adv7511: Add link_config variable to struct adv7511_chip_info
> >   drm: adv7511: Add hpd_override_enable variable to struct
> >     adv7511_chip_info
> >
> >  drivers/gpu/drm/bridge/adv7511/adv7511.h     |  16 ++-
> >  drivers/gpu/drm/bridge/adv7511/adv7511_cec.c |  14 +--
> > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 104 +++++++++++--------
> >  drivers/gpu/drm/bridge/adv7511/adv7533.c     |   7 +-
> >  4 files changed, 81 insertions(+), 60 deletions(-)
> >
> > --
> > 2.25.1
Robert Foss Oct. 16, 2023, 9:12 a.m. UTC | #3
On Wed, 30 Aug 2023 15:23:50 +0100, Biju Das wrote:
> This patch series aims to improve ADV7511 driver by adding
> feature bits and data instead of comparing enum adv7511_type for
> various hardware differences between ADV7511, ADV7533 and ADV7535.
> 
> This patch series tested with[1] on RZ/G2L SMARC EVK which embeds
> ADV7535.
> 
> [...]

I aplogize for the delay in merging this very neat series.

Applied, thanks!

[1/8] drm: adv7511: Add struct adv7511_chip_info and use i2c_get_match_data()
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=19e77c7aef57
[2/8] drm: adv7511: Add max_mode_clock_khz variable to struct adv7511_chip_info
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=11ae4e406dd9
[3/8] drm: adv7511: Add max_lane_freq_khz variable to struct adv7511_chip_info
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=399562fc02d8
[4/8] drm: adv7511: Add supply_names and num_supplies variables to struct adv7511_chip_info
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=9ac196fb9a17
[5/8] drm: adv7511: Add reg_cec_offset variable to struct adv7511_chip_info
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=8d6cf5719011
[6/8] drm: adv7511: Add has_dsi variable to struct adv7511_chip_info
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=c75551214858
[7/8] drm: adv7511: Add link_config variable to struct adv7511_chip_info
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=7618aa3ab38e
[8/8] drm: adv7511: Add hpd_override_enable variable to struct adv7511_chip_info
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=e12c4703cec0



Rob
Biju Das Oct. 16, 2023, 9:28 a.m. UTC | #4
> Subject: Re: [PATCH v2 0/8] ADV7511 driver enhancements
> 
> On Wed, 30 Aug 2023 15:23:50 +0100, Biju Das wrote:
> > This patch series aims to improve ADV7511 driver by adding feature
> > bits and data instead of comparing enum adv7511_type for various
> > hardware differences between ADV7511, ADV7533 and ADV7535.
> >
> > This patch series tested with[1] on RZ/G2L SMARC EVK which embeds
> > ADV7535.
> >
> > [...]
> 
> I aplogize for the delay in merging this very neat series.
> 
> Applied, thanks!

Thank you

Biju Das