[drm-misc-next,0/5] PowerVR VM fixes

Message

Danilo Krummrich Nov. 24, 2023, 11:36 p.m. UTC

Hi,

Some major GPUVM changes landed just before v8 of the PowerVR series. Since v8
went in rather quickly (review process was finished otherwise) I haven't had the
chance to review the subsequent code changes.

Hence, this series with a few fixes in this context. Plus a minor GPUVM patch to
make the drm_gpuvm_prepare_* helpers useful for PowerVR.

- Danilo


Danilo Krummrich (5):
  drm/imagination: vm: prevent duplicate drm_gpuvm_bo instances
  drm/imagination: vm: check for drm_gpuvm_range_valid()
  drm/imagination: vm: fix drm_gpuvm reference count
  drm/gpuvm: fall back to drm_exec_lock_obj()
  drm/imagination: vm: make use of GPUVM's drm_exec helper

 drivers/gpu/drm/drm_gpuvm.c          | 36 ++++++++++++++++++++--
 drivers/gpu/drm/imagination/pvr_vm.c | 46 +++++++++++++++-------------
 drivers/gpu/drm/imagination/pvr_vm.h |  3 +-
 include/drm/drm_gpuvm.h              | 23 ++------------
 4 files changed, 63 insertions(+), 45 deletions(-)


base-commit: 46990918f35c1bf6e367cf8e0423e7344fec9fcb

Comments

Frank Binns Nov. 27, 2023, 10:53 a.m. UTC | #1

Hi,

Thank you for the patches.

On Sat, 2023-11-25 at 00:36 +0100, Danilo Krummrich wrote:
> Hi,
> 
> Some major GPUVM changes landed just before v8 of the PowerVR series. Since v8
> went in rather quickly (review process was finished otherwise) I haven't had the
> chance to review the subsequent code changes.
> 
> Hence, this series with a few fixes in this context. Plus a minor GPUVM patch to
> make the drm_gpuvm_prepare_* helpers useful for PowerVR.
> 
> - Danilo
> 
> 
> Danilo Krummrich (5):
>   drm/imagination: vm: prevent duplicate drm_gpuvm_bo instances
>   drm/imagination: vm: check for drm_gpuvm_range_valid()
>   drm/imagination: vm: fix drm_gpuvm reference count
>   drm/gpuvm: fall back to drm_exec_lock_obj()
>   drm/imagination: vm: make use of GPUVM's drm_exec helper
> 
>  drivers/gpu/drm/drm_gpuvm.c          | 36 ++++++++++++++++++++--
>  drivers/gpu/drm/imagination/pvr_vm.c | 46 +++++++++++++++-------------
>  drivers/gpu/drm/imagination/pvr_vm.h |  3 +-
>  include/drm/drm_gpuvm.h              | 23 ++------------
>  4 files changed, 63 insertions(+), 45 deletions(-)
> 
> 
> base-commit: 46990918f35c1bf6e367cf8e0423e7344fec9fcb

For the series:

Tested-by: Frank Binns <[e-mail]>

I'll leave it to Donald to do the review.

Thanks
Frank