[v5,0/4] drm/solomon: Add support for the SSD133x controller family

Message

Javier Martinez Canillas Dec. 29, 2023, 11:20 a.m. UTC

Hello,

This patch-set adds support for the family of SSD133x Solomon controllers,
such as the SSD1331. These are used for RGB Dot Matrix OLED/PLED panels.

This is a v5 that is basically the same than the previous v4 but dropping
support for I2C since the ssd133x family does not support that interface.

The patches were tested on a Waveshare SSD1331 display using glmark2-drm,
fbcon, fbtests and the retroarch emulator. The binding schema were tested
using the `make W=1 dt_binding_check` target.

Patch #1 and #2 are fixes for the DT binding schema of the existing SSD130x
and SSD132x families.

Patch #3 adds a DT binding schema for the SSD133x controllers and patch #4
extends the ssd130x DRM driver to support the SSD133x controller family.

Best regards,
Javier

Changes in v5:
- Drop I2C example in DT binding schema due that bus not being supported.
- Drop "solomon,ssd1331" entry from ssd130x-i2c due I2C bus not being supported.

Changes in v4:
- Fix typo in commit message (Jocelyn Falempe).
- Add collected tags.

Changes in v3:
- Move solomon,ssd-common.yaml ref before the properties section and
  width/height constraints after the other properties (Conor Dooley).

Changes in v2:
- Unconditionally set the width and height constraints (Conor Dooley).
- Fix indentation in the DTS examples (Krzysztof Kozlowski).

Javier Martinez Canillas (4):
  dt-bindings: display: ssd1307fb: Add vendor prefix to width and height
  dt-bindings: display: ssd132x: Add vendor prefix to width and height
  dt-bindings: display: Add SSD133x OLED controllers
  drm/ssd130x: Add support for the SSD133x OLED controller family

 .../bindings/display/solomon,ssd1307fb.yaml   |  20 +-
 .../bindings/display/solomon,ssd132x.yaml     |  12 +-
 .../bindings/display/solomon,ssd133x.yaml     |  45 +++
 drivers/gpu/drm/solomon/ssd130x-spi.c         |   7 +
 drivers/gpu/drm/solomon/ssd130x.c             | 370 ++++++++++++++++++
 drivers/gpu/drm/solomon/ssd130x.h             |   5 +-
 6 files changed, 442 insertions(+), 17 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/display/solomon,ssd133x.yaml

Comments

Javier Martinez Canillas Jan. 1, 2024, 12:09 p.m. UTC | #1

Javier Martinez Canillas <[e-mail]> writes:

> Hello,
>
> This patch-set adds support for the family of SSD133x Solomon controllers,
> such as the SSD1331. These are used for RGB Dot Matrix OLED/PLED panels.
>
> This is a v5 that is basically the same than the previous v4 but dropping
> support for I2C since the ssd133x family does not support that interface.
>
> The patches were tested on a Waveshare SSD1331 display using glmark2-drm,
> fbcon, fbtests and the retroarch emulator. The binding schema were tested
> using the `make W=1 dt_binding_check` target.
>
> Patch #1 and #2 are fixes for the DT binding schema of the existing SSD130x
> and SSD132x families.
>
> Patch #3 adds a DT binding schema for the SSD133x controllers and patch #4
> extends the ssd130x DRM driver to support the SSD133x controller family.
>
> Best regards,
> Javier

Pushed to drm-misc (drm-misc-next). Thanks!