mbox series

[v3,0/8] dma-fence, drm, amdgpu new trace events

Message ID 20240216151006.475077-1-pierre-eric.pelloux-prayer@amd.com (mailing list archive)
Headers show
Series dma-fence, drm, amdgpu new trace events | expand

Message

Pierre-Eric Pelloux-Prayer Feb. 16, 2024, 3:09 p.m. UTC
This series adds new events to make it easier for tools
like gpuvis or umr to graph the GPUs, kernel and applications
activity.

UMR patches using these events can be found here:
https://gitlab.freedesktop.org/tomstdenis/umr/-/merge_requests/37

V1:
https://patchwork.kernel.org/project/linux-media/patch/20240117184329.479554-1-pierre-eric.pelloux-prayer@amd.com/

Changes from V1:
* uses trace_dma_fence_sync_to from dma-fence-chain.c
* new amdgpu events
* new drm plane commit event

Changes from V2:
* uses trace_dma_fence_used_as_dependency from drm_sched_job_add_dependency
* add devname attribute to the trace_amdgpu_sched_run_job event
* addressed review comments

Pierre-Eric Pelloux-Prayer (8):
  tracing, dma-buf: add a trace_dma_fence_sync_to event
  dma-buf/fence-chain: use trace_dma_fence_sync_to
  amdgpu: use trace_dma_fence_sync_to in amdgpu_fence_sync
  drm/amdgpu: add a amdgpu_bo_fill trace event
  drm/amdgpu: add a amdgpu_cs_start trace event
  drm: add drm_mode_atomic_commit event
  drm/sched: use trace_dma_fence_used_as_dependency
  drm/amdgpu: add devname to trace_amdgpu_sched_run_job

 drivers/dma-buf/dma-fence-chain.c         |  4 +++
 drivers/dma-buf/dma-fence.c               |  1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c    |  2 ++
 drivers/gpu/drm/amd/amdgpu/amdgpu_job.c   |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c  |  9 +++--
 drivers/gpu/drm/amd/amdgpu/amdgpu_sync.h  |  4 ++-
 drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 42 ++++++++++++++++++++---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c   |  2 ++
 drivers/gpu/drm/drm_atomic_uapi.c         | 21 ++++++++++++
 drivers/gpu/drm/drm_trace.h               | 23 +++++++++++++
 drivers/gpu/drm/scheduler/sched_main.c    |  4 +++
 include/trace/events/dma_fence.h          | 27 +++++++++++++++
 12 files changed, 133 insertions(+), 8 deletions(-)

Comments

Christian König Feb. 16, 2024, 3:20 p.m. UTC | #1
Am 16.02.24 um 16:09 schrieb Pierre-Eric Pelloux-Prayer:
> This series adds new events to make it easier for tools
> like gpuvis or umr to graph the GPUs, kernel and applications
> activity.
>
> UMR patches using these events can be found here:
> https://gitlab.freedesktop.org/tomstdenis/umr/-/merge_requests/37
>
> V1:
> https://patchwork.kernel.org/project/linux-media/patch/20240117184329.479554-1-pierre-eric.pelloux-prayer@amd.com/

I need to separate this patch set a bit. The DMA-buf stuff usually goes 
upstream through drm-misc-next while the amdgpu only patches go upstream 
through our internal branch.

I will keep you looped in which patch I pick from this set to which branch.

Oh, that's going to be fun.

Christian.

>
> Changes from V1:
> * uses trace_dma_fence_sync_to from dma-fence-chain.c
> * new amdgpu events
> * new drm plane commit event
>
> Changes from V2:
> * uses trace_dma_fence_used_as_dependency from drm_sched_job_add_dependency
> * add devname attribute to the trace_amdgpu_sched_run_job event
> * addressed review comments
>
> Pierre-Eric Pelloux-Prayer (8):
>    tracing, dma-buf: add a trace_dma_fence_sync_to event
>    dma-buf/fence-chain: use trace_dma_fence_sync_to
>    amdgpu: use trace_dma_fence_sync_to in amdgpu_fence_sync
>    drm/amdgpu: add a amdgpu_bo_fill trace event
>    drm/amdgpu: add a amdgpu_cs_start trace event
>    drm: add drm_mode_atomic_commit event
>    drm/sched: use trace_dma_fence_used_as_dependency
>    drm/amdgpu: add devname to trace_amdgpu_sched_run_job
>
>   drivers/dma-buf/dma-fence-chain.c         |  4 +++
>   drivers/dma-buf/dma-fence.c               |  1 +
>   drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c    |  2 ++
>   drivers/gpu/drm/amd/amdgpu/amdgpu_job.c   |  2 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c  |  9 +++--
>   drivers/gpu/drm/amd/amdgpu/amdgpu_sync.h  |  4 ++-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 42 ++++++++++++++++++++---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c   |  2 ++
>   drivers/gpu/drm/drm_atomic_uapi.c         | 21 ++++++++++++
>   drivers/gpu/drm/drm_trace.h               | 23 +++++++++++++
>   drivers/gpu/drm/scheduler/sched_main.c    |  4 +++
>   include/trace/events/dma_fence.h          | 27 +++++++++++++++
>   12 files changed, 133 insertions(+), 8 deletions(-)
>