From patchwork Wed Mar 13 00:13:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13590783 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45C2DC54E5D for ; Wed, 13 Mar 2024 00:14:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2243210F532; Wed, 13 Mar 2024 00:13:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="nhBftxKP"; dkim-atps=neutral Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by gabe.freedesktop.org (Postfix) with ESMTPS id B414E10F3E3 for ; Wed, 13 Mar 2024 00:13:57 +0000 (UTC) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1dc49b00bdbso37227775ad.3 for ; Tue, 12 Mar 2024 17:13:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1710288837; x=1710893637; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=roioUGnaxY6AvjIUwtL2u9LanxRAGecYCXou90dLIu4=; b=nhBftxKP14Px4+BBEzBU+o8Zrme3AgMdTg+fYFNe3HRdZebJpC4ooZopU/JVdovw2T OVpnduMtKczBidQ6SFc8QFX4zHPQ18GEGZ8hu5Y/kqkDXtuvdUM8QPyH2kUXFphLhmxH RNILB7/kCRl2FwB8c8ndv+mvjF4e5lxCsJw9Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710288837; x=1710893637; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=roioUGnaxY6AvjIUwtL2u9LanxRAGecYCXou90dLIu4=; b=IasCcw4ozkriEzIKO2Zlkgh20+6hbOSm1C8IYWqF9DB0Hzppb3OnedXa91oVYacdrU CO9JcQGBKNqJa7u+EuL0zGOn5aSFSaqmilB9yWzrQZ9QY5DsOS2/qnWjBsGXT+y0dQdn u/5mxp2u4xUgWvgHq/gN6Q4RMEdaHautz8ksBJINn8yWZB6jm6kcIL9MUAC4cqP8fCcZ yYRT23L0aly+pn5ANo7dDYW4b3EV0Jx38LZnGhItAHIuHA2lO097H5lhBEdqjQQd/gPN 6gvdQlU6rR7QTQCmOeftx3AzGHQ3b5bc+h8QfPxuHjiL3XK8RbU7afEJaAeYha7nWHsB JsRA== X-Forwarded-Encrypted: i=1; AJvYcCVXSCfLx3k5pRKA/crqGPgYhXd9VOFMoBcWcBgIXV6oH6fe++FOdjYOy6IlhzS5E2LaZTY2oWryufvpcdNNRYttVP/NH7lnour/JsVewrGw X-Gm-Message-State: AOJu0Yx3Wj6q3NF2f0Zh6SJQlejwpRMpF3SzAtQfQHy+graNJSwUVz/7 FnWm21dI+/TVpnjGuh0+TAxlp1BGlPPbJx2YLMfcA9HCIuHgvUUk1GzCMmkrhg== X-Google-Smtp-Source: AGHT+IG58PN3ouLt4+V6o22EJ3ezJVOTQSf28+tSjOkyWRU31OXa8iIFliZtabjLxDQCMZq9cqjRsA== X-Received: by 2002:a17:902:c947:b0:1dd:8daf:99b2 with SMTP id i7-20020a170902c94700b001dd8daf99b2mr9535150pla.13.1710288837058; Tue, 12 Mar 2024 17:13:57 -0700 (PDT) Received: from dianders.sjc.corp.google.com ([2620:15c:9d:2:f8dd:895c:e876:6edb]) by smtp.gmail.com with ESMTPSA id x8-20020a170902a38800b001dd761faec3sm7432924pla.251.2024.03.12.17.13.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 17:13:56 -0700 (PDT) From: Douglas Anderson To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov Cc: Douglas Anderson , Bjorn Andersson , Daniel Vetter , David Airlie , Guenter Roeck , Kuogee Hsieh , Marijn Suijten , Sankeerth Billakanti , Sean Paul , Tanmay Shah , Vinod Polimera , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/3] drm/msm/dp: Improve DP AUX transfer vs. HPD interactions Date: Tue, 12 Mar 2024 17:13:15 -0700 Message-ID: <20240313001345.2623074-1-dianders@chromium.org> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The main goal of this patch series is to avoid problems running "fwupd" on Qualcomm devices. Right now several of the plugins used with fwupd try talking over all DP AUX busses and this results in a very long timeout on Qualcomm devices. As part of fixing this, I noticed a case where the MSM DP code wasn't respecing the timeout properly when asked to wait for HPD. I also noticed that, now that we've implemented wait_hpd_asserted(), we no longer need the long hardcoded timeout / special cse for eDP in the AUX transfer function. NOTE: I no longer have any hardware setup that uses this driver for eDP so I've only tested the DP case. The eDP changes are straightforward so hopefully there are no problems there. Douglas Anderson (3): drm/msm/dp: Avoid a long timeout for AUX transfer if nothing connected drm/msm/dp: Account for the timeout in wait_hpd_asserted() callback drm/msm/dp: Delete the old 500 ms wait for eDP HPD in aux transfer drivers/gpu/drm/msm/dp/dp_aux.c | 21 ++++++++------------- drivers/gpu/drm/msm/dp/dp_catalog.c | 17 ++++++++++++++--- drivers/gpu/drm/msm/dp/dp_catalog.h | 4 +++- 3 files changed, 25 insertions(+), 17 deletions(-)