| Message ID | 20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/panel: small fixes for visionox and novatek panel drivers | expand |
On Thu, 04 Apr 2024 13:07:58 +0300, Dmitry Baryshkov wrote: > While taking a glance at the novatek-nt36672e driver I stumbled upon a > call to unregister the DSI device for the panel, although it was not the > panel driver that registered the device. > > Remove this call and a similar call from the visionox-rm69299 driver. > While we are at it, also optimize regulator API calls in these two > drivers and in the novatek-nt36672a driver. > > [...] Applied to drm-misc-fixes, thanks! [1/6] drm/panel: visionox-rm69299: don't unregister DSI device commit: 9e4d3f4f34455abbaa9930bf6b7575a5cd081496 [2/6] drm/panel: novatek-nt36682e: don't unregister DSI device commit: 941c0bdbc176df825adf77052263b2d63db6fef7 Other four patches were not reviewed and they are not fixes, so they are still pending. Best regards,
Hi, On Thu, 04 Apr 2024 13:07:58 +0300, Dmitry Baryshkov wrote: > While taking a glance at the novatek-nt36672e driver I stumbled upon a > call to unregister the DSI device for the panel, although it was not the > panel driver that registered the device. > > Remove this call and a similar call from the visionox-rm69299 driver. > While we are at it, also optimize regulator API calls in these two > drivers and in the novatek-nt36672a driver. > > [...] Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [3/6] drm/panel: novatek-nt36672e: stop setting register load before disable https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/302aeb946731923c4ff7cca093868e4148ebc701 [4/6] drm/panel: novatek-nt36672e: stop calling regulator_set_load manually https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/9dab1af1e7592d9317bf3857e8cf019120973053 [5/6] drm/panel: novatek-nt36672a: stop calling regulator_set_load manually https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/a8ee5f50a9d87f35ca80d6ea74ac07ae97d5a21b [6/6] drm/panel: visionox-rm69299: stop calling regulator_set_load manually https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/251e3c1fe15cb8bf71a834f863f6225b8164f7b8
While taking a glance at the novatek-nt36672e driver I stumbled upon a call to unregister the DSI device for the panel, although it was not the panel driver that registered the device. Remove this call and a similar call from the visionox-rm69299 driver. While we are at it, also optimize regulator API calls in these two drivers and in the novatek-nt36672a driver. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Dmitry Baryshkov (6): drm/panel: visionox-rm69299: don't unregister DSI device drm/panel: novatek-nt36682e: don't unregister DSI device drm/panel: novatek-nt36672e: stop setting register load before disable drm/panel: novatek-nt36672e: stop calling regulator_set_load manually drm/panel: novatek-nt36672a: stop calling regulator_set_load manually drm/panel: visionox-rm69299: stop calling regulator_set_load manually drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 11 +++----- drivers/gpu/drm/panel/panel-novatek-nt36672e.c | 35 +++----------------------- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 18 ++----------- 3 files changed, 9 insertions(+), 55 deletions(-) --- base-commit: a6bd6c9333397f5a0e2667d4d82fef8c970108f2 change-id: 20240404-drop-panel-unregister-744a9fd41cc6 Best regards,