| Message ID | 20240408170426.9285-1-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm: Increase COMPILE_TEST=y coverage | expand |
April 8, 2024 at 8:04 PM, "Ville Syrjala" <ville.syrjala@linux.intel.com mailto:ville.syrjala@linux.intel.com?to=%22Ville%20Syrjala%22%20%3Cville.syrjala%40linux.intel.com%3E > wrote: > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > __iowmb() isn't available on most architectures. Make > its use optional so that the driver can be built on > other architectures with COMPILE_TEST=y. > > Cc: Jyri Sarha <jyri.sarha@iki.fi> > Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Acked-by: Jyri Sarha <jyri.sarha@iki.fi> Thanks, Jyri > --- > drivers/gpu/drm/tilcdc/tilcdc_regs.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_regs.h b/drivers/gpu/drm/tilcdc/tilcdc_regs.h > index f90e2dc3457c..44e4ada30fba 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_regs.h > +++ b/drivers/gpu/drm/tilcdc/tilcdc_regs.h > @@ -125,7 +125,9 @@ static inline void tilcdc_write64(struct drm_device *dev, u32 reg, u64 data) > #if defined(iowrite64) !defined(iowrite64_is_nonatomic) > iowrite64(data, addr); > #else > +#ifdef __iowmb > __iowmb(); > +#endif > /* This compiles to strd (=64-bit write) on ARM7 */ > *(volatile u64 __force *)addr = __cpu_to_le64(data); > #endif > -- > 2.43.2 >
April 8, 2024 at 8:04 PM, "Ville Syrjala" <ville.syrjala@linux.intel.com mailto:ville.syrjala@linux.intel.com?to=%22Ville%20Syrjala%22%20%3Cville.syrjala%40linux.intel.com%3E > wrote: > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Allow tilcdc to be built with COMPILE_TEST=y for greater > coverage. Builds fine on x86/x86_64 at least. > > Cc: Jyri Sarha <jyri.sarha@iki.fi> > Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Acked-by: Jyri Sarha <jyri.sarha@iki.fi> Thanks, Jyri > --- > drivers/gpu/drm/tilcdc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig > index d3bd2d7a181e..1897ef91c70b 100644 > --- a/drivers/gpu/drm/tilcdc/Kconfig > +++ b/drivers/gpu/drm/tilcdc/Kconfig > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0-only > config DRM_TILCDC > tristate "DRM Support for TI LCDC Display Controller" > - depends on DRM OF && ARM > + depends on DRM && OF && (ARM || COMPILE_TEST) > select DRM_KMS_HELPER > select DRM_GEM_DMA_HELPER > select DRM_BRIDGE > -- > 2.43.2 >
On Mon, Apr 08, 2024 at 08:04:05PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > I got fed up having to build multiple architectures when > doing subsystem wide refactoring. So I decided to attack > the low hanging COMPILE_TEST=y fruit. Here are the > results. All of these drivers now build with COMPILE_TEST=y > on x86/x86_64 > > Ville Syrjälä (21): > drm/hisilicon/kirin: Include linux/io.h for readl()/writel() > drm/hisilicon/kirin: Fix 64bit divisions > drm/hisilicon/kirin: Fix MASK(32) on 32bit architectures > drm/hisilicon/kirin: Allow build with COMPILE_TEST=y > drm/omap: Open code phys_to_page() > drm/omap: Allow build with COMPILE_TEST=y > drm/atmel-hlcdc: Allow build with COMPILE_TEST=y > drm/rcar-du: Allow build with COMPILE_TEST=y > drm/stm: Allow build with COMPILE_TEST=y ^ pushed to drm-misc-next. Thanks for the reviews. > drm/armada: Fix printk arguments > drm/armada: Fix armada_debugfs_crtc_reg_write() return type > drm/armada: Allow build with COMPILE_TEST=y > drm/imx/dcss: Fix 64bit divisions > drm/imx/dcss: Allow build with COMPILE_TEST=y > drm/sti: Include linux/io.h for devm_ioremap() > drm/sti: Allow build with COMPILE_TEST=y > drm/fsl-dcu: Allow build with COMPILE_TEST=y > drm/mediatek: Allow build with COMPILE_TEST=y > drm/meson: Allow build with COMPILE_TEST=y ^ are all still without comments. > drm/tilcdc: Allow build without __iowmb() > drm/tilcdc: Allow build with COMPILE_TEST=y ^ I need to respin.
From: Ville Syrjälä <ville.syrjala@linux.intel.com> I got fed up having to build multiple architectures when doing subsystem wide refactoring. So I decided to attack the low hanging COMPILE_TEST=y fruit. Here are the results. All of these drivers now build with COMPILE_TEST=y on x86/x86_64 Ville Syrjälä (21): drm/armada: Fix printk arguments drm/armada: Fix armada_debugfs_crtc_reg_write() return type drm/armada: Allow build with COMPILE_TEST=y drm/imx/dcss: Fix 64bit divisions drm/imx/dcss: Allow build with COMPILE_TEST=y drm/sti: Include linux/io.h for devm_ioremap() drm/sti: Allow build with COMPILE_TEST=y drm/hisilicon/kirin: Include linux/io.h for readl()/writel() drm/hisilicon/kirin: Fix 64bit divisions drm/hisilicon/kirin: Fix MASK(32) on 32bit architectures drm/hisilicon/kirin: Allow build with COMPILE_TEST=y drm/tilcdc: Allow build without __iowmb() drm/tilcdc: Allow build with COMPILE_TEST=y drm/omap: Open code phys_to_page() drm/omap: Allow build with COMPILE_TEST=y drm/atmel-hlcdc: Allow build with COMPILE_TEST=y drm/fsl-dcu: Allow build with COMPILE_TEST=y drm/mediatek: Allow build with COMPILE_TEST=y drm/meson: Allow build with COMPILE_TEST=y drm/rcar-du: Allow build with COMPILE_TEST=y drm/stm: Allow build with COMPILE_TEST=y drivers/gpu/drm/armada/Kconfig | 2 +- drivers/gpu/drm/armada/armada_debugfs.c | 2 +- drivers/gpu/drm/armada/armada_gem.c | 2 +- drivers/gpu/drm/atmel-hlcdc/Kconfig | 2 +- drivers/gpu/drm/fsl-dcu/Kconfig | 2 +- drivers/gpu/drm/hisilicon/kirin/Kconfig | 2 +- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 11 +++++------ drivers/gpu/drm/hisilicon/kirin/dw_dsi_reg.h | 2 ++ drivers/gpu/drm/hisilicon/kirin/kirin_ade_reg.h | 2 +- drivers/gpu/drm/imx/dcss/Kconfig | 2 +- drivers/gpu/drm/imx/dcss/dcss-scaler.c | 4 ++-- drivers/gpu/drm/mediatek/Kconfig | 4 ++-- drivers/gpu/drm/meson/Kconfig | 2 +- drivers/gpu/drm/omapdrm/Kconfig | 2 +- drivers/gpu/drm/omapdrm/omap_gem.c | 4 ++-- drivers/gpu/drm/renesas/rcar-du/Kconfig | 2 +- drivers/gpu/drm/sti/Kconfig | 2 +- drivers/gpu/drm/sti/sti_dvo.c | 1 + drivers/gpu/drm/stm/Kconfig | 2 +- drivers/gpu/drm/tilcdc/Kconfig | 2 +- drivers/gpu/drm/tilcdc/tilcdc_regs.h | 2 ++ 21 files changed, 30 insertions(+), 26 deletions(-)