mbox series

[0/2] Add TDM setting support

Message ID 20240502-anx-tdm-v1-0-894a9f634f44@chromium.org (mailing list archive)
Headers show
Series Add TDM setting support | expand

Message

Hsin-Te Yuan May 2, 2024, 9:03 a.m. UTC 
The anx7625 supports two different TDM settings, which determine whether
or not the first audio data bit should be shifted. This series adds the
support for configuring TDM setting through a property in the device
tree.

Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
---
Hsin-Te Yuan (2):
      dt-bindings: drm/bridge: anx7625: Add a perporty to change TDM setting
      drm/bridge: anx7625: Change TDM setting accroding to dt property

 .../devicetree/bindings/display/bridge/analogix,anx7625.yaml      | 4 ++++
 drivers/gpu/drm/bridge/analogix/anx7625.c                         | 8 ++++++++
 drivers/gpu/drm/bridge/analogix/anx7625.h                         | 1 +
 3 files changed, 13 insertions(+)
---
base-commit: 90d35da658da8cff0d4ecbb5113f5fac9d00eb72
change-id: 20240430-anx-tdm-7ce41a0a901d

Best regards,

Comments

Chen-Yu Tsai May 2, 2024, 9:33 a.m. UTC | #1 
On Thu, May 2, 2024 at 5:03 PM Hsin-Te Yuan <yuanhsinte@chromium.org> wrote:
>
> The anx7625 supports two different TDM settings, which determine whether
> or not the first audio data bit should be shifted. This series adds the
> support for configuring TDM setting through a property in the device
> tree.

As mentioned offline, this shouldn't need a DT property. Instead the
machine driver dictates which format is used to the DAIs, and the
DAIs set their respective settings accordingly. It would seem that
one of the drivers is misbehaving.

ChenYu

> Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
> ---
> Hsin-Te Yuan (2):
>       dt-bindings: drm/bridge: anx7625: Add a perporty to change TDM setting
>       drm/bridge: anx7625: Change TDM setting accroding to dt property
>
>  .../devicetree/bindings/display/bridge/analogix,anx7625.yaml      | 4 ++++
>  drivers/gpu/drm/bridge/analogix/anx7625.c                         | 8 ++++++++
>  drivers/gpu/drm/bridge/analogix/anx7625.h                         | 1 +
>  3 files changed, 13 insertions(+)
> ---
> base-commit: 90d35da658da8cff0d4ecbb5113f5fac9d00eb72
> change-id: 20240430-anx-tdm-7ce41a0a901d
>
> Best regards,
> --
> Hsin-Te Yuan <yuanhsinte@chromium.org>
>