[RFC,0/4] drm/msm: add a display mmu fault handler

Message

Abhinav Kumar May 17, 2024, 11:37 p.m. UTC

To debug display mmu faults, this series introduces a display fault
handler similar to the gpu one.

This is only compile tested at the moment, till a suitable method
to trigger the fault is found and see if this handler does the needful
on the device.

Abhinav Kumar (4):
  drm/msm: register a fault handler for display mmu faults
  drm/msm/iommu: rename msm_fault_handler to msm_gpu_fault_handler
  drm/msm/iommu: introduce msm_iommu_disp_new() for msm_kms
  drm/msm: switch msm_kms to use msm_iommu_disp_new()

 drivers/gpu/drm/msm/msm_iommu.c | 34 ++++++++++++++++++++++++++++++---
 drivers/gpu/drm/msm/msm_kms.c   | 27 +++++++++++++++++++++++++-
 drivers/gpu/drm/msm/msm_mmu.h   |  1 +
 3 files changed, 58 insertions(+), 4 deletions(-)

Comments

Dmitry Baryshkov May 19, 2024, 8:17 a.m. UTC | #1

On Fri, May 17, 2024 at 04:37:55PM -0700, Abhinav Kumar wrote:
> To debug display mmu faults, this series introduces a display fault
> handler similar to the gpu one.
> 
> This is only compile tested at the moment, till a suitable method
> to trigger the fault is found and see if this handler does the needful
> on the device.

You should always be able to trigger the issue by programming wrong
values to the SSPP.

> 
> Abhinav Kumar (4):
>   drm/msm: register a fault handler for display mmu faults
>   drm/msm/iommu: rename msm_fault_handler to msm_gpu_fault_handler
>   drm/msm/iommu: introduce msm_iommu_disp_new() for msm_kms
>   drm/msm: switch msm_kms to use msm_iommu_disp_new()
> 
>  drivers/gpu/drm/msm/msm_iommu.c | 34 ++++++++++++++++++++++++++++++---
>  drivers/gpu/drm/msm/msm_kms.c   | 27 +++++++++++++++++++++++++-
>  drivers/gpu/drm/msm/msm_mmu.h   |  1 +
>  3 files changed, 58 insertions(+), 4 deletions(-)
> 
> -- 
> 2.44.0
>