mbox series

[v3,0/4] Fix memory limits for STDU

Message ID 20240521184720.767-1-ian.forbes@broadcom.com (mailing list archive)
Headers show
Series Fix memory limits for STDU | expand

Message

Ian Forbes May 21, 2024, 6:47 p.m. UTC 
Fixes a bug where modes that are too large for the device are exposed
and set causing a black screen on boot.

v2: Fixed llvmpipe over-alignment bug.
v3: Fix comment formatting.

Ian Forbes (4):
  drm/vmwgfx: Filter modes which exceed graphics memory
  drm/vmwgfx: 3D disabled should not effect STDU memory limits
  drm/vmwgfx: Remove STDU logic from generic mode_valid function
  drm/vmwgfx: Standardize use of kibibytes when logging

 drivers/gpu/drm/vmwgfx/vmwgfx_drv.c           | 19 +++-----
 drivers/gpu/drm/vmwgfx/vmwgfx_drv.h           |  3 --
 drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c |  4 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c           | 26 ++++-------
 drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c          | 45 ++++++++++++++++++-
 5 files changed, 60 insertions(+), 37 deletions(-)

Comments

Zack Rusin May 21, 2024, 10:41 p.m. UTC | #1 
On Tue, May 21, 2024 at 2:47 PM Ian Forbes <ian.forbes@broadcom.com> wrote:
>
> Fixes a bug where modes that are too large for the device are exposed
> and set causing a black screen on boot.
>
> v2: Fixed llvmpipe over-alignment bug.
> v3: Fix comment formatting.
>
> Ian Forbes (4):
>   drm/vmwgfx: Filter modes which exceed graphics memory
>   drm/vmwgfx: 3D disabled should not effect STDU memory limits
>   drm/vmwgfx: Remove STDU logic from generic mode_valid function
>   drm/vmwgfx: Standardize use of kibibytes when logging
>
>  drivers/gpu/drm/vmwgfx/vmwgfx_drv.c           | 19 +++-----
>  drivers/gpu/drm/vmwgfx/vmwgfx_drv.h           |  3 --
>  drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c |  4 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_kms.c           | 26 ++++-------
>  drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c          | 45 ++++++++++++++++++-
>  5 files changed, 60 insertions(+), 37 deletions(-)

Looks great. For the series:
Reviewed-by: Zack Rusin <zack.rusin@broadcom.com>

z