[v5,0/3] SII902X HDMI Bridge fixups

Message

Jayesh Choudhary June 13, 2024, 8:38 a.m. UTC

- Move the mode_valid hook to drm_bridge_funcs structure to take care
  of the case when the encoder attaches the bridge chain with the
  DRM_BRIDGE_ATTACH_NO_CONNECTOR flag in which case, the connector is
  not initialized in the bridge's attach call and mode_valid is not
  called.

- Also add this check to the atomic_check call as suggested by Maxime in
  v1 patch.

- Move from deprecated enable()/disable() hooks to atomic hooks as
  suggested in v4 by Sam

Testing has been done on AM62X platform which have SII902X HDMI bridge.
From the logs we can see the propagated modes and flip test for 1080p
resolution.

Testlog:
<https://gist.github.com/Jayesh2000/9bea6840672869337039296bc1145df4>

Changelog v4->v5:
- Add followup patch to replace deprecated bridge hooks
- Fix atomic check to return negative value
- Made commit message for [1/2] in v4 more clear while keeping the R-by and
  Acked-by tags.
- Fix commit header for [2/2] in v4

v4 patch:
<https://lore.kernel.org/all/[e-mail]/>

Changelog v3->v4:
- Remove mode_valid hook from connector_helper_funcs as it is not needed.

v3 patch:
<https://lore.kernel.org/all/[e-mail]/>

Changelog v2->v3:
- Remove newline that was introduced in [1/2] and later deleted in [2/2]
  in v2

v2 patch:
<https://lore.kernel.org/all/[e-mail]/>

Changelog v1->v2:
- Add KHZ suffix in the macros to be more clear
- Add the hook for drm_bridge_funcs as well
- Add check in atomic_check dunction call (in a separate patch)

v1 patch:
<https://lore.kernel.org/all/[e-mail]/>

Jayesh Choudhary (3):
  drm/bridge: sii902x: Fix mode_valid hook
  drm/bridge: sii902x: Support atomic bridge APIs
  drm/bridge: sii902x: Add pixel clock check in atomic_check

 drivers/gpu/drm/bridge/sii902x.c | 46 +++++++++++++++++++++++---------
 1 file changed, 33 insertions(+), 13 deletions(-)

Comments

Maxime Ripard June 13, 2024, 3:40 p.m. UTC | #1

On Thu, 13 Jun 2024 14:08:02 +0530, Jayesh Choudhary wrote:
> - Move the mode_valid hook to drm_bridge_funcs structure to take care
>   of the case when the encoder attaches the bridge chain with the
>   DRM_BRIDGE_ATTACH_NO_CONNECTOR flag in which case, the connector is
>   not initialized in the bridge's attach call and mode_valid is not
>   called.
> 
> - Also add this check to the atomic_check call as suggested by Maxime in
>   v1 patch.
> 
> [...]

Applied to misc/kernel.git (drm-misc-next).

Thanks!
Maxime