| Message ID | 20240617184243.330231-1-andi.shyti@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Sparse errors on the i915_gem_stolen | expand |
-----Original Message----- From: Andi Shyti <andi.shyti@linux.intel.com> Sent: Monday, June 17, 2024 11:43 AM To: intel-gfx <intel-gfx@lists.freedesktop.org>; dri-devel <dri-devel@lists.freedesktop.org> Cc: Andi Shyti <andi.shyti@linux.intel.com>; Cavitt, Jonathan <jonathan.cavitt@intel.com>; De Marchi, Lucas <lucas.demarchi@intel.com> Subject: [PATCH v2 0/2] Sparse errors on the i915_gem_stolen > > Hi Jonathan, > > Commit 05da7d9f717b ("drm/i915/gem: Downgrade stolen lmem setup > warning") produces two sparse warnings. The first one being a bit > more sever as it might cause a segmentation fault. > > The difference between v1 and v2 is that the patch should return > a NULL, which won't cause any issues. > > Andi Sure. Apply to all: Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com> -Jonathan Cavitt > > Cc: Jonathan Cavitt <jonathan.cavitt@intel.com> > Cc: Lucas De Marchi <lucas.demarchi@intel.com> > > Andi Shyti (2): > drm/i915/gem: Return NULL instead of '0' > drm/i915/gem: Use the correct format specifier for resource_size_t > > drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > -- > 2.45.1 > >
Hi, On Tue, Jun 18, 2024 at 07:34:22PM +0000, Cavitt, Jonathan wrote: > > Commit 05da7d9f717b ("drm/i915/gem: Downgrade stolen lmem setup > > warning") produces two sparse warnings. The first one being a bit > > more sever as it might cause a segmentation fault. > > > > The difference between v1 and v2 is that the patch should return > > a NULL, which won't cause any issues. > > > > Andi > > Sure. Apply to all: > Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com> Thanks, if no other comments, I'm going to merge this soon, Thanks, Andi
Hi Jonathan, Commit 05da7d9f717b ("drm/i915/gem: Downgrade stolen lmem setup warning") produces two sparse warnings. The first one being a bit more sever as it might cause a segmentation fault. The difference between v1 and v2 is that the patch should return a NULL, which won't cause any issues. Andi Cc: Jonathan Cavitt <jonathan.cavitt@intel.com> Cc: Lucas De Marchi <lucas.demarchi@intel.com> Andi Shyti (2): drm/i915/gem: Return NULL instead of '0' drm/i915/gem: Use the correct format specifier for resource_size_t drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)