| Message ID | 20240627-tdp158-v3-0-fb2fbc808346@freebox.fr (mailing list archive) |
|---|---|
| Headers | show |
| Series | Basic support for TI TDP158 | expand |
On 27/06/2024 13:13, Marc Gonzalez wrote: > Changes in v3: > - Add 'select DRM_PANEL_BRIDGE' in driver Kconfig > - Fix checkpatch errors > - log errors using dev_err (so save dev pointer) > - expand a few error messages > - expand commit messages with info from the datasheet > - mark regulators as required in the DT binding > - Link to v2: https://lore.kernel.org/r/20240625-tdp158-v2-0-a3b344707fa7@freebox.fr Series has been rebased on top of v6.11-rc1 Current changelog is: Changes in v4: - Add blurb about I2C vs pin strap mode in cover letter - Add blurb about I2C vs pin strap mode in binding commit message - Add blurb about I2C mode in driver commit message - Add comment in binding explaining when reg is required - Add comment in binding describing Operation Enable / Reset Pin - Link to v3: https://lore.kernel.org/r/20240627-tdp158-v3-0-fb2fbc808346@freebox.fr For reference, binding commit message blurb: Like the TFP410, the TDP158 can be set up in 2 different ways: 1) hard-coding its configuration settings using pin-strapping resistors 2) placing it on an I2C bus, and defer set-up until run-time The mode is selected via pin 8 = I2C_EN I2C_EN high = I2C Control Mode I2C_EN low = Pin Strap Mode On our board, I2C_EN is pulled high. driver commit message blurb: On our board, I2C_EN is pulled high. Thus, this code defines a module_i2c_driver. The default settings work fine for our use-case. So this basic driver doesn't need to tweak any I2C registers. binding comments: +# The reg property is required if and only if the device is connected +# to an I2C bus. In pin strap mode, reg must not be specified. + reg: + description: I2C address of the device + +# Pin 36 = Operation Enable / Reset Pin +# OE = L: Power Down Mode +# OE = H: Normal Operation +# Internal weak pullup: device resets on H to L transitions + enable-gpios: + description: GPIO controlling bridge enable I plan to send a formal v4 in a few hours. Regards
--- Changes in v3: - Add 'select DRM_PANEL_BRIDGE' in driver Kconfig - Fix checkpatch errors - log errors using dev_err (so save dev pointer) - expand a few error messages - expand commit messages with info from the datasheet - mark regulators as required in the DT binding - Link to v2: https://lore.kernel.org/r/20240625-tdp158-v2-0-a3b344707fa7@freebox.fr Changes in v2: - Don't overload simple-bridge, spin new minimal driver - New driver, new binding - Default device settings work fine for us, so we don't tweak registers - Link to v1: https://lore.kernel.org/r/20240617-tdp158-v1-0-df98ef7dec6d@freebox.fr Getting unusual message at run-time, need to check. [ 2.389848] platform c9a0000.hdmi-tx: Fixed dependency cycle(s) with /soc@0/i2c@c1b5000/tdp158@5e [ 2.391089] i2c 2-005e: Fixed dependency cycle(s) with /soc@0/display-subsystem@c900000/hdmi-tx@c9a0000 --- Marc Gonzalez (2): dt-bindings: display: bridge: add TI TDP158 drm/bridge: add support for TI TDP158 .../bindings/display/bridge/ti,tdp158.yaml | 51 ++++++++++ drivers/gpu/drm/bridge/Kconfig | 7 ++ drivers/gpu/drm/bridge/Makefile | 1 + drivers/gpu/drm/bridge/ti-tdp158.c | 108 +++++++++++++++++++++ 4 files changed, 167 insertions(+) --- base-commit: d47e2c964a51cbaa14a8c0ac641f85349584fae9 change-id: 20240617-tdp158-418200d6cc0b Best regards,