[0/5] drm/ast: Fix DP hotplugging and clean up

Message

Thomas Zimmermann July 17, 2024, 2:24 p.m. UTC

Here are a number of updates for ast's ASTDP transmitter code.

So far the ast driver required the DisplayPort to be connected
at boot. Later detection was not supported. Re-connecting the
cable was also not supported. Once atomic_disable powered off
the physical ASTDP connector, there was no way of detecting a
conencted display. Patch 1 makes Hot Plug Detection work. If
ncesessary, the connector's detect helper powers up the physical
connector to read the HPD status.

That's a good oportunity to clean up ast's whole detection code
for ASTDP transmitters. So patch 2 to 4 remove duplicated status
tests throughout the ASTDP code.

Patch 5 simplified the code for reading the display's EDID data
from the firmware.

Tested on AST2600 hardware with an ASTDP transmitter.

Thomas Zimmermann (5):
  drm/ast: astdp: Wake up during connector status detection
  drm/ast: astdp: Test firmware status once during probing
  drm/ast: astdp: Only test HDP state in ast_astdp_is_connected()
  drm/ast: astdp: Perform link training during atomic_enable
  drm/ast: astdp: Clean up EDID reading

 drivers/gpu/drm/ast/ast_dp.c   | 186 +++++++++++++++------------------
 drivers/gpu/drm/ast/ast_drv.h  |   4 +-
 drivers/gpu/drm/ast/ast_main.c |   6 +-
 drivers/gpu/drm/ast/ast_mode.c |  31 +++++-
 drivers/gpu/drm/ast/ast_post.c |   2 +-
 drivers/gpu/drm/ast/ast_reg.h  |  22 ++--
 6 files changed, 126 insertions(+), 125 deletions(-)

Comments

Thomas Zimmermann July 29, 2024, 12:31 p.m. UTC | #1

Ping for review

Am 17.07.24 um 16:24 schrieb Thomas Zimmermann:
> Here are a number of updates for ast's ASTDP transmitter code.
>
> So far the ast driver required the DisplayPort to be connected
> at boot. Later detection was not supported. Re-connecting the
> cable was also not supported. Once atomic_disable powered off
> the physical ASTDP connector, there was no way of detecting a
> conencted display. Patch 1 makes Hot Plug Detection work. If
> ncesessary, the connector's detect helper powers up the physical
> connector to read the HPD status.
>
> That's a good oportunity to clean up ast's whole detection code
> for ASTDP transmitters. So patch 2 to 4 remove duplicated status
> tests throughout the ASTDP code.
>
> Patch 5 simplified the code for reading the display's EDID data
> from the firmware.
>
> Tested on AST2600 hardware with an ASTDP transmitter.
>
> Thomas Zimmermann (5):
>    drm/ast: astdp: Wake up during connector status detection
>    drm/ast: astdp: Test firmware status once during probing
>    drm/ast: astdp: Only test HDP state in ast_astdp_is_connected()
>    drm/ast: astdp: Perform link training during atomic_enable
>    drm/ast: astdp: Clean up EDID reading
>
>   drivers/gpu/drm/ast/ast_dp.c   | 186 +++++++++++++++------------------
>   drivers/gpu/drm/ast/ast_drv.h  |   4 +-
>   drivers/gpu/drm/ast/ast_main.c |   6 +-
>   drivers/gpu/drm/ast/ast_mode.c |  31 +++++-
>   drivers/gpu/drm/ast/ast_post.c |   2 +-
>   drivers/gpu/drm/ast/ast_reg.h  |  22 ++--
>   6 files changed, 126 insertions(+), 125 deletions(-)
>