| Message ID | 20240801100640.462606-1-jfalempe@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/log: Introduce a new boot logger to draw the kmsg on the screen | expand |
On 2024-08-01, Jocelyn Falempe <jfalempe@redhat.com> wrote: > * I tried to use the new nbcon interface, but didn't get any message > from the write_atomic() callback, but the goal is to use that when > it's ready. Be aware that the write_atomic() callback _must_ also print from NMI context. write_thread() may be the callback you are interested instead. Note that for CON_NBCON, write_atomic() is optional, write_thread() is mandatory. Disclaimer: All of this currently only available in the PREEMPT_RT patchset. So until it hits mainline, semantics may yet change. John Ogness
drm_log is a simple logger that uses the drm_client API to print the kmsg boot log on the screen. This is not a full replacement to fbcon, as it will only print the kmsg. It will never handle user input, or a terminal because this is better done in userspace. If you're curious on how it looks like, I've put a small demo here: https://people.redhat.com/jfalempe/drm_log/drm_log_draft_preview.webm Design decisions: * It uses the drm_client API, so it should work on all drm drivers from the start. * It doesn't scroll the message, that way it doesn't need to redraw the whole screen for each new message. It also means it doesn't have to keep drawn messages in memory, to redraw them when scrolling. * It uses a circular buffer so the console->write() callback is very quick, and will never stall. * Drawing is done asynchronously using a workqueue. * drm_log can only be built-in (and drm must be built-in too). The reason is that, if you build it as a module, then a userspace application will be more appropriate than this module. TODO items: * It currently only handles the first drm_client hotplug event, I need a bit more time to fix that. * I didn't find a way to know when drm_log loses focus, I would like to unregister it, so it won't waste CPU cycles in the background. * I copied the drm_client API usage from drm_fbdev_shmem, so there might be some adjustment to work on DMA GPU (I didn't try yet). * Flicker-free boot: I don't want drm_log to introduce new modeset during the boot, so it may need some adjustment. * I tried to use the new nbcon interface, but didn't get any message from the write_atomic() callback, but the goal is to use that when it's ready. * Add color support, to make timestamp, or error message, in different color for better visibility. * If built with VT_CONSOLE=n and FRAMEBUFFER_CONSOLE=y, fbcon is taking the focus, and you won't see the drm_log. It would be nice to have drm_log for boot logs, and still use fbcon for terminal, when userspace is started. The first patch is not for review/merge, it's a squash of my pending drm_panic series: https://patchwork.freedesktop.org/series/136377/ https://patchwork.freedesktop.org/series/135944/ The second patch, moves the drawing function from drm_panic.c, to drm_draw.c, so they can be re-used by drm_log. The third patch is the actual drm_log implementation. I want to get some feedbacks before spending more time on this, and make sure I'm heading in the right direction. Thanks and best regards,