From patchwork Tue Sep 3 02:01:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13787858 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 002D8C54FC6 for ; Tue, 3 Sep 2024 02:02:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 67A3110E162; Tue, 3 Sep 2024 02:02:07 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="LD8r+U1l"; dkim-atps=neutral Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by gabe.freedesktop.org (Postfix) with ESMTPS id DFD7410E16A for ; Tue, 3 Sep 2024 02:02:05 +0000 (UTC) Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2f409c87b07so59857151fa.0 for ; Mon, 02 Sep 2024 19:02:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725328924; x=1725933724; darn=lists.freedesktop.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=Jaon4WakhCpB6iL+hPLr96orgJfk9v1/Fqkvo3LCw0o=; b=LD8r+U1lhNMt7i4fDu8aumH0FXafs9NENNKa/6n553Q/AHRZlLKZKKr8xfFrN7FigU Tg4HbpbvwH5aiA2nbYxwhVflv6ye9TKh/21lJJPfGnkY5FOAuh6UBHh/OA2GbPEvrwhY Sbel/i9fyAI8pPQwTJktXxT8pXcoQzGAAxkr4YiMU/C1tS/BOW21+jgIPBbo5OW78VcU X9EKXsbObJgvc1E/Gs7eAbOeJAJALrcdzMQ0ZJ55zlu5jlr2tjLMpzC8IyqSY3EjfjIx QYR7Z2NRim01o9OEkR2I/q4o9MkCyRbYdj4PlnIQyAo3e851tmSTsfaFm3aXrR4EqiHi AlYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725328924; x=1725933724; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Jaon4WakhCpB6iL+hPLr96orgJfk9v1/Fqkvo3LCw0o=; b=CNeXEf0x83YTfmRUmPYWArPre8Sj+NjLtYFLByHtB0Ea2dcCfOjmELtjuDNB7I3iyH 4YHXfCVoRqgkImdKyMkVOrBw9zF4J0U/G6Dj1TWNudrCSvUn6HMZv1Cd0iXQx/04qp/k na/dhaYnyuibqpa4od9atZdftw3RjFc84NOUEzgITmzc8PGnFMz7geyKW4e7PZQva4XB /yw7+yC5cLbEht+py1Xx0xB+bRY8hS+LZFV1wfl6+k28yGgv0fKXqN56IRzK8y/C2Q3O FZG+qOsc8vgTb4L2QQqrf7cPuevVblxVjF36gzKacbd2f7y4kar39nOfM18hCpxp/lgC tlcg== X-Gm-Message-State: AOJu0YyBcbCJIwuXWf8Ic5HkWFJuQTXM62/fSfwzEHZ85hYt68L7he78 QoB78e5ws44D0M3z5XEO4r36yq77Dz3D9bX3fiZW62B0qiImGMfBZhHmIEvlPiY= X-Google-Smtp-Source: AGHT+IH2ddOPWpP9vOPua5bV93XUii65ilyuJnbCbqXryT6U4fN0EdmF5ySMd7clEDi4r6Z/lY2Rhw== X-Received: by 2002:a2e:4c09:0:b0:2ef:290e:4a39 with SMTP id 38308e7fff4ca-2f626bbbd74mr47016851fa.35.1725328922705; Mon, 02 Sep 2024 19:02:02 -0700 (PDT) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f614ed15a5sm20827761fa.8.2024.09.02.19.02.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Sep 2024 19:02:01 -0700 (PDT) From: Dmitry Baryshkov Subject: [PATCH v5 0/3] drm: fix two issues related to HDMI Connector implementation Date: Tue, 03 Sep 2024 05:01:55 +0300 Message-Id: <20240903-drm-bridge-connector-fix-hdmi-reset-v5-0-daebde6d9857@linaro.org> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIABNu1mYC/53NTW7CMBAF4KsgrzvIHk9C3BX3QF0Ye0IsFbuyU QRCuXsHNi1iQ7t88/O9q2pcEzf1vrqqynNqqWQJ3dtKhcnnA0OKkhVqJN2jhViPsK8pyiaUnDm cSoUxnWGKxwSVG59ABx56P+rOeq9E+qosF/eW3YfkKTX5utxLZ3Ob/s2fDWggw25wFEPksP1M2 deyLvWgbgUz/gNFQYfO6UjkDAZ+Qu0PutH4GmoFNbjXbA1S8PSE0i/UdK+hJGhvuCezCWN07gF dluUbDBv28dYBAAA= To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Laurentiu Palcu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Anitha Chrisanthus , Edmund Dea , Chun-Kuang Hu , Philipp Zabel , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Tomi Valkeinen , Kieran Bingham , Biju Das , Geert Uytterhoeven , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Jyri Sarha , Matthias Brugger , AngeloGioacchino Del Regno Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3353; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=EYI46Bz/nggRktCfUc4nuXKd2sUlD/7bxU6zar/vXO0=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBm1m4YRSvsImJpHuC/wcLa1DcZOPuYqAiynu6nD hrSfiRv7eOJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZtZuGAAKCRCLPIo+Aiko 1T8VB/4laRhXOUULaJ+JMQI12xMPUKXQH5ph8rJNcS9B/gmLgbcPLgMhO/fJS4iK0YjhNZoPI0W NJ70iNUleeMx0GBlB+RyVJuS/d1SFgtPXp/jx2RDS0Wm21hPh/X3Fm1nEQ2eqX6oz939nxLb2g1 hrjPMsp+fy/DoJp+WyPqy/YwSqHBZlcYwPUPH1mctmZwJC1GkTrajvdYFKB188SS/N9bztPoBUy kG2weWvQkMNcYmSOjnh5gEtxQ6gHkWX2ve9pRhaVXOiHiWkM0q1mHZF6HXhCeGTAAhhiSv/+N17 PRBvnlt91b/RQK3b1NoB53F/rapRdYsKJEf9cpwjn7/ZFhmz X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Running IGT tests on Qualcomm Dragonboard820c uncovered two issues with the HDMI Connector implementation and with its integration into the drm_bridge_connector. Fix those issues. Note, I'm not fully satisfied with the drm_bridge_connector move. Maybe it's better to add drm_bridge_funcs::connector_reset() and call it from __drm_atomic_helper_connector_reset(). Depends on https://lore.kernel.org/dri-devel/20240704-panel-sw43408-fix-v6-1-3ea1c94bbb9b@linaro.org Signed-off-by: Dmitry Baryshkov --- Changes in v5: - Rebased on top of drm-misc-next - Dropped the DRM_MODE_PROP_IMMUTABLE patches, replaced with the IGT patch. - Link to v4: https://lore.kernel.org/r/20240715-drm-bridge-connector-fix-hdmi-reset-v4-0-61e6417cfd99@linaro.org Changes in v4: - Fixed DRM_MODE_PROP_IMMUTABLE to use MUST in the single-value clause (Maxime) - Rebased on top of DRM_DSC_HELPERS patch - Removed 'depends on DRM_DISPLAY_HELPER' (Maxime) - Link to v3: https://lore.kernel.org/r/20240702-drm-bridge-connector-fix-hdmi-reset-v3-0-12b0e3124ca4@linaro.org Changes in v3: - Document the DRM_MODE_PROP_IMMUTABLE requirements currently exposed only via IGT tests (Maxime). - Move drm_bridge_connector to drm_display_helper. - Link to v2: https://lore.kernel.org/r/20240623-drm-bridge-connector-fix-hdmi-reset-v2-0-8590d44912ce@linaro.org Changes in v2: - Actually pass the flags to drm_property_create_range(). - Link to v1: https://lore.kernel.org/r/20240623-drm-bridge-connector-fix-hdmi-reset-v1-0-41e9894dcdec@linaro.org --- Dmitry Baryshkov (3): drm/display: stop depending on DRM_DISPLAY_HELPER drm/bridge-connector: move to DRM_DISPLAY_HELPER module drm/bridge-connector: reset the HDMI connector state MAINTAINERS | 2 +- drivers/gpu/drm/Makefile | 1 - drivers/gpu/drm/bridge/Kconfig | 1 + drivers/gpu/drm/display/Kconfig | 25 ++++++++++++---------- drivers/gpu/drm/display/Makefile | 2 ++ .../gpu/drm/{ => display}/drm_bridge_connector.c | 13 ++++++++++- drivers/gpu/drm/imx/dcss/Kconfig | 2 ++ drivers/gpu/drm/imx/lcdc/Kconfig | 2 ++ drivers/gpu/drm/ingenic/Kconfig | 2 ++ drivers/gpu/drm/kmb/Kconfig | 2 ++ drivers/gpu/drm/mediatek/Kconfig | 2 ++ drivers/gpu/drm/meson/Kconfig | 2 ++ drivers/gpu/drm/msm/Kconfig | 1 + drivers/gpu/drm/omapdrm/Kconfig | 2 ++ drivers/gpu/drm/renesas/rcar-du/Kconfig | 2 ++ drivers/gpu/drm/renesas/rz-du/Kconfig | 2 ++ drivers/gpu/drm/renesas/shmobile/Kconfig | 2 ++ drivers/gpu/drm/rockchip/Kconfig | 4 ++++ drivers/gpu/drm/tegra/Kconfig | 1 + drivers/gpu/drm/tidss/Kconfig | 2 ++ drivers/gpu/drm/xlnx/Kconfig | 1 + 21 files changed, 59 insertions(+), 14 deletions(-) --- base-commit: ca097d4d94d808409386fde414370900cc41adad change-id: 20240623-drm-bridge-connector-fix-hdmi-reset-0ce86af053aa Best regards,