| Message ID | 20240912071437.1708969-1-quic_mahap@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add display support for Qualcomm SA8775P platform | expand |
On 9/12/2024 1:26 PM, Dmitry Baryshkov wrote: > On Thu, Sep 12, 2024 at 12:44:32PM GMT, Mahadevan wrote: >> Add support for mdss and dpu driver on Qualcomm SA8775P platform. >> >> --- >> This series depends on following series: >> https://lore.kernel.org/all/20240816-sa8775p-mm-v3-v1-0-77d53c3c0cef@quicinc.com/ > As such, it probably can not be merged before 6.14 (the mentioned series > will go on 6.13, we usually don't do cross-tree merges into drm). Please > rework the bindings to drop the dependency (it is possible, use fake > nodes instead of using dispcc + ID). Then you can specify that only the > DTS patch depends on the dispcc support, allowing driver changes to go > in first. Can we use clocks = <&dummy_dispcc 0>, <&dummy_dispcc 1>, <&dummy_dispcc 2>; instead of clocks = <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>, <&dispcc0 MDSS_DISP_CC_MDSS_MDP_LUT_CLK>, <&dispcc0 MDSS_DISP_CC_MDSS_MDP_CLK>; in dt bindings? > >> --- >> >> Mahadevan (5): >> dt-bindings: display/msm: Document MDSS on SA8775P >> dt-bindings: display/msm: Document the DPU for SA8775P >> drm/msm: mdss: Add SA8775P support >> drm/msm/dpu: Add SA8775P support >> arm64: dts: qcom: sa8775p: add display dt nodes >> >> .../display/msm/qcom,sa8775p-dpu.yaml | 120 +++++ >> .../display/msm/qcom,sa8775p-mdss.yaml | 225 ++++++++ >> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 85 +++ >> .../msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h | 485 ++++++++++++++++++ >> .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 3 +- >> .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 3 +- >> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 +- >> drivers/gpu/drm/msm/msm_mdss.c | 10 + >> 8 files changed, 931 insertions(+), 3 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,sa8775p-dpu.yaml >> create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml >> create mode 100644 drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h >> >> -- >> 2.34.1 >>
On Tue, 24 Sept 2024 at 09:16, Mahadevan P <quic_mahap@quicinc.com> wrote: > > > On 9/12/2024 1:26 PM, Dmitry Baryshkov wrote: > > On Thu, Sep 12, 2024 at 12:44:32PM GMT, Mahadevan wrote: > >> Add support for mdss and dpu driver on Qualcomm SA8775P platform. > >> > >> --- > >> This series depends on following series: > >> https://lore.kernel.org/all/20240816-sa8775p-mm-v3-v1-0-77d53c3c0cef@quicinc.com/ > > As such, it probably can not be merged before 6.14 (the mentioned series > > will go on 6.13, we usually don't do cross-tree merges into drm). Please > > rework the bindings to drop the dependency (it is possible, use fake > > nodes instead of using dispcc + ID). Then you can specify that only the > > DTS patch depends on the dispcc support, allowing driver changes to go > > in first. > > > Can we use clocks = <&dummy_dispcc 0>, <&dummy_dispcc 1>, > <&dummy_dispcc 2>; instead of clocks = <&dispcc0 > MDSS_DISP_CC_MDSS_AHB_CLK>, <&dispcc0 MDSS_DISP_CC_MDSS_MDP_LUT_CLK>, > <&dispcc0 MDSS_DISP_CC_MDSS_MDP_CLK>; in dt bindings? Please take a look at how other platforms solved that already rather than inventing a new way. For example, see sm7150, sm8650, x1e80100. > > > > >> --- > >> > >> Mahadevan (5): > >> dt-bindings: display/msm: Document MDSS on SA8775P > >> dt-bindings: display/msm: Document the DPU for SA8775P > >> drm/msm: mdss: Add SA8775P support > >> drm/msm/dpu: Add SA8775P support > >> arm64: dts: qcom: sa8775p: add display dt nodes > >> > >> .../display/msm/qcom,sa8775p-dpu.yaml | 120 +++++ > >> .../display/msm/qcom,sa8775p-mdss.yaml | 225 ++++++++ > >> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 85 +++ > >> .../msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h | 485 ++++++++++++++++++ > >> .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 3 +- > >> .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 3 +- > >> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 +- > >> drivers/gpu/drm/msm/msm_mdss.c | 10 + > >> 8 files changed, 931 insertions(+), 3 deletions(-) > >> create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,sa8775p-dpu.yaml > >> create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml > >> create mode 100644 drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h > >> > >> -- > >> 2.34.1 > >>