[0/6] Samsung Exynos 7870 DECON driver support

Message

Kaustabh Chakraborty Sept. 19, 2024, 3:10 p.m. UTC

This patch series aims at adding support for Exynos7870's DECON in the
Exynos7 DECON driver. It introduces a driver data struct so that support
for DECON on other SoCs can be added to it in the future.

It also fixes a few bugs in the driver, such as functions recieving bad
pointers.

Tested on Samsung Galaxy J7 Prime and Samsung Galaxy A2 Core.

Signed-off-by: Kaustabh Chakraborty <[e-mail]>
---
Kaustabh Chakraborty (6):
      drm/exynos: exynos7_drm_decon: fix uninitialized crtc reference in functions
      drm/exynos: exynos7_drm_decon: fix suspended condition in decon_commit()
      drm/exynos: exynos7_drm_decon: fix ideal_clk by converting it to Hz
      drm/exynos: exynos7_drm_decon: properly clear channels during bind
      drm/exynos: exynos7_drm_decon: add driver data and support for Exynos7870
      dt-bindings: display: samsung,exynos7-decon: add exynos7870 compatible

 .../display/samsung/samsung,exynos7-decon.yaml     |   4 +-
 drivers/gpu/drm/exynos/exynos7_drm_decon.c         | 124 +++++++++++++--------
 drivers/gpu/drm/exynos/regs-decon7.h               |  15 ++-
 3 files changed, 90 insertions(+), 53 deletions(-)
---
base-commit: 4f3e012d4cfd1d9bf837870c961f462ca9f23ebe
change-id: 20240917-exynosdrm-decon-4c228dd1d2bf

Best regards,

Comments

Inki Dae Nov. 1, 2024, 5:08 a.m. UTC | #1

Hi Kaustabh Chakraborty,

Sorry for late.

> -----Original Message-----
> From: Kaustabh Chakraborty <[e-mail]>
> Sent: Friday, September 20, 2024 12:11 AM
> To: Inki Dae <[e-mail]>; Seung-Woo Kim
> <[e-mail]>; Kyungmin Park <[e-mail]>; David
> Airlie <[e-mail]>; Simona Vetter <[e-mail]>; Krzysztof
> Kozlowski <[e-mail]>; Alim Akhtar <[e-mail]>;
> Maarten Lankhorst <[e-mail]>; Maxime Ripard
> <[e-mail]>; Thomas Zimmermann <[e-mail]>; Rob Herring
> <[e-mail]>; Conor Dooley <[e-mail]>
> Cc: [e-mail]; [e-mail];
> [e-mail]; [e-mail];
> [e-mail]; Kaustabh Chakraborty <[e-mail]>
> Subject: [PATCH 0/6] Samsung Exynos 7870 DECON driver support
> 
> This patch series aims at adding support for Exynos7870's DECON in the
> Exynos7 DECON driver. It introduces a driver data struct so that support
> for DECON on other SoCs can be added to it in the future.
> 
> It also fixes a few bugs in the driver, such as functions recieving bad
> pointers.
> 
> Tested on Samsung Galaxy J7 Prime and Samsung Galaxy A2 Core.
> 
> Signed-off-by: Kaustabh Chakraborty <[e-mail]>
> ---
> Kaustabh Chakraborty (6):
>       drm/exynos: exynos7_drm_decon: fix uninitialized crtc reference in
> functions
>       drm/exynos: exynos7_drm_decon: fix suspended condition in
> decon_commit()
>       drm/exynos: exynos7_drm_decon: fix ideal_clk by converting it to Hz
>       drm/exynos: exynos7_drm_decon: properly clear channels during bind
>       drm/exynos: exynos7_drm_decon: add driver data and support for
> Exynos7870
>       dt-bindings: display: samsung,exynos7-decon: add exynos7870
> compatible

I will apply all except for the two patches below,
[PATCH 2/6] drm/exynos: exynos7_drm_decon: fix suspended condition in decon_commit()
[PATCH 6/6] dt-bindings: display: samsung,exynos7-decon: add exynos7870 compatible

Thanks,
Inki Dae

> 
>  .../display/samsung/samsung,exynos7-decon.yaml     |   4 +-
>  drivers/gpu/drm/exynos/exynos7_drm_decon.c         | 124 +++++++++++++-----
> ---
>  drivers/gpu/drm/exynos/regs-decon7.h               |  15 ++-
>  3 files changed, 90 insertions(+), 53 deletions(-)
> ---
> base-commit: 4f3e012d4cfd1d9bf837870c961f462ca9f23ebe
> change-id: 20240917-exynosdrm-decon-4c228dd1d2bf
> 
> Best regards,
> --
> Kaustabh Chakraborty <[e-mail]>

Rob Herring (Arm) Nov. 5, 2024, 8:11 p.m. UTC | #2

On Fri, Nov 1, 2024 at 12:08 AM 대인기/Tizen Platform Lab(SR)/삼성전자
<[e-mail]> wrote:
>
> Hi Kaustabh Chakraborty,
>
> Sorry for late.
>
> > -----Original Message-----
> > From: Kaustabh Chakraborty <[e-mail]>
> > Sent: Friday, September 20, 2024 12:11 AM
> > To: Inki Dae <[e-mail]>; Seung-Woo Kim
> > <[e-mail]>; Kyungmin Park <[e-mail]>; David
> > Airlie <[e-mail]>; Simona Vetter <[e-mail]>; Krzysztof
> > Kozlowski <[e-mail]>; Alim Akhtar <[e-mail]>;
> > Maarten Lankhorst <[e-mail]>; Maxime Ripard
> > <[e-mail]>; Thomas Zimmermann <[e-mail]>; Rob Herring
> > <[e-mail]>; Conor Dooley <[e-mail]>
> > Cc: [e-mail]; [e-mail];
> > [e-mail]; [e-mail];
> > [e-mail]; Kaustabh Chakraborty <[e-mail]>
> > Subject: [PATCH 0/6] Samsung Exynos 7870 DECON driver support
> >
> > This patch series aims at adding support for Exynos7870's DECON in the
> > Exynos7 DECON driver. It introduces a driver data struct so that support
> > for DECON on other SoCs can be added to it in the future.
> >
> > It also fixes a few bugs in the driver, such as functions recieving bad
> > pointers.
> >
> > Tested on Samsung Galaxy J7 Prime and Samsung Galaxy A2 Core.
> >
> > Signed-off-by: Kaustabh Chakraborty <[e-mail]>
> > ---
> > Kaustabh Chakraborty (6):
> >       drm/exynos: exynos7_drm_decon: fix uninitialized crtc reference in
> > functions
> >       drm/exynos: exynos7_drm_decon: fix suspended condition in
> > decon_commit()
> >       drm/exynos: exynos7_drm_decon: fix ideal_clk by converting it to Hz
> >       drm/exynos: exynos7_drm_decon: properly clear channels during bind
> >       drm/exynos: exynos7_drm_decon: add driver data and support for
> > Exynos7870
> >       dt-bindings: display: samsung,exynos7-decon: add exynos7870
> > compatible
>
> I will apply all except for the two patches below,
> [PATCH 2/6] drm/exynos: exynos7_drm_decon: fix suspended condition in decon_commit()
> [PATCH 6/6] dt-bindings: display: samsung,exynos7-decon: add exynos7870 compatible

Now we have a warning in linux-next that samsung,exynos7870-decon is
not documented.

Please apply the binding patch. Or let me know if it missed 6.13 for
DRM tree and I'll apply it.

Rob

Inki Dae Nov. 5, 2024, 11:54 p.m. UTC | #3

Hi Rob Herring,

> -----Original Message-----
> From: Rob Herring <[e-mail]>
> Sent: Wednesday, November 6, 2024 5:11 AM
> To: 대인기/Tizen Platform Lab(SR)/삼성전자 <[e-mail]>
> Cc: Kaustabh Chakraborty <[e-mail]>; Seung-Woo Kim
> <[e-mail]>; Kyungmin Park <[e-mail]>; David
> Airlie <[e-mail]>; Simona Vetter <[e-mail]>; Krzysztof
> Kozlowski <[e-mail]>; Alim Akhtar <[e-mail]>;
> Maarten Lankhorst <[e-mail]>; Maxime Ripard
> <[e-mail]>; Thomas Zimmermann <[e-mail]>; Conor
> Dooley <[e-mail]>; [e-mail]; linux-arm-
> [e-mail]; [e-mail]; linux-
> [e-mail]; [e-mail]
> Subject: Re: [PATCH 0/6] Samsung Exynos 7870 DECON driver support
> 
> On Fri, Nov 1, 2024 at 12:08 AM 대인기/Tizen Platform Lab(SR)/삼성전자
> <[e-mail]> wrote:
> >
> > Hi Kaustabh Chakraborty,
> >
> > Sorry for late.
> >
> > > -----Original Message-----
> > > From: Kaustabh Chakraborty <[e-mail]>
> > > Sent: Friday, September 20, 2024 12:11 AM
> > > To: Inki Dae <[e-mail]>; Seung-Woo Kim
> > > <[e-mail]>; Kyungmin Park <[e-mail]>;
> David
> > > Airlie <[e-mail]>; Simona Vetter <[e-mail]>; Krzysztof
> > > Kozlowski <[e-mail]>; Alim Akhtar <[e-mail]>;
> > > Maarten Lankhorst <[e-mail]>; Maxime Ripard
> > > <[e-mail]>; Thomas Zimmermann <[e-mail]>; Rob
> Herring
> > > <[e-mail]>; Conor Dooley <[e-mail]>
> > > Cc: [e-mail]; linux-arm-
> [e-mail];
> > > [e-mail]; [e-mail];
> > > [e-mail]; Kaustabh Chakraborty
> <[e-mail]>
> > > Subject: [PATCH 0/6] Samsung Exynos 7870 DECON driver support
> > >
> > > This patch series aims at adding support for Exynos7870's DECON in the
> > > Exynos7 DECON driver. It introduces a driver data struct so that
> support
> > > for DECON on other SoCs can be added to it in the future.
> > >
> > > It also fixes a few bugs in the driver, such as functions recieving
> bad
> > > pointers.
> > >
> > > Tested on Samsung Galaxy J7 Prime and Samsung Galaxy A2 Core.
> > >
> > > Signed-off-by: Kaustabh Chakraborty <[e-mail]>
> > > ---
> > > Kaustabh Chakraborty (6):
> > >       drm/exynos: exynos7_drm_decon: fix uninitialized crtc reference
> in
> > > functions
> > >       drm/exynos: exynos7_drm_decon: fix suspended condition in
> > > decon_commit()
> > >       drm/exynos: exynos7_drm_decon: fix ideal_clk by converting it to
> Hz
> > >       drm/exynos: exynos7_drm_decon: properly clear channels during
> bind
> > >       drm/exynos: exynos7_drm_decon: add driver data and support for
> > > Exynos7870
> > >       dt-bindings: display: samsung,exynos7-decon: add exynos7870
> > > compatible
> >
> > I will apply all except for the two patches below,
> > [PATCH 2/6] drm/exynos: exynos7_drm_decon: fix suspended condition in
> decon_commit()
> > [PATCH 6/6] dt-bindings: display: samsung,exynos7-decon: add exynos7870
> compatible
> 
> Now we have a warning in linux-next that samsung,exynos7870-decon is
> not documented.
> 
> Please apply the binding patch. Or let me know if it missed 6.13 for
> DRM tree and I'll apply it.
> 

Ah... sorry for this. I didn't check the warning. Will apply the binding patch. I was awaiting the submission of DTS.

Thanks,
Inki Dae

> Rob